Skip to content

Clean up some CI failures for GuC submission

Matthew Brost dri-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 9 repliesIn review

v2 from the cover letter

(Daniel Vetter)
- Split fixes into individual patches
- A kernel doc
- A VLK ref for selftest workaround
(Checkpatch)
- Fix warnings

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9drm/i915/guc: Fix blocked context accountingdrivers/gpu/drm/i915/gt/uc/intel_guc_submission.c+1 -12 replies
2/9drm/i915/guc: outstanding G2H accountingdrivers/gpu/drm/i915/gt/uc/intel_guc_submission.c+5 -30 replies
3/9drm/i915/guc: Unwind context requests in reverse orderdrivers/gpu/drm/i915/gt/uc/intel_guc_submission.c+4 -40 replies
4/9drm/i915/guc: Don't drop ce->guc_active.lock when unwinding contextdrivers/gpu/drm/i915/gt/uc/intel_guc_submission.c+0 -40 replies
5/9drm/i915/guc: Flush the work queue for GuC generated G2Hdrivers/gpu/drm/i915/gt/uc/intel_guc_submission.c+5 -07 replies
6/9drm/i915/guc: Do not clear enable during reset in an enable is inflightdrivers/gpu/drm/i915/gt/uc/intel_guc_submission.c+11 -50 replies
7/9drm/i915/guc: Don't enable scheduling on a banned contextdrivers/gpu/drm/i915/gt/uc/intel_guc_submission.c+1 -00 replies
8/9drm/i915/selftests: Fix memory corruption in live_lrc_isolationdrivers/gpu/drm/i915/gt/selftest_lrc.c+28 -10 replies
9/9drm/i915/selftests: Add initial GuC selftest for scrubbing lost G2Hdrivers/gpu/drm/i915/gt/intel_context_types.h drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c drivers/gpu/drm/i915/gt/uc/selftest_guc.c +3 more+184 -00 replies

Reviews trailers per patch

1 of 9 patches has a Reviewed-by or Acked-by.

PatchDaniel Vetter
1/9R-b
2/9
3/9
4/9
5/9
6/9
7/9
8/9
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/9] Clean up some CI failures for GuC submission

Resets are notoriously hard to get fully working and notoriously racey, especially with selftests / IGTs that do all sorts of wild things that would be near impossible to hit during normal use cases. Even though likely impossible to hit, anything selftests / IGTs uncover needs to be fixed. This series addresses 7 such issues, adds a workaround to a selftest, and add another selftest to prove scrubbing of G2H during a reset works.

v2:
(Daniel Vetter)
- Split fixes into individual patches
- A kernel doc
- A VLK ref for selftest workaround
(Checkpatch)
- Fix warnings

Matthew Brost (9):
drm/i915/guc: Fix blocked context accounting drm/i915/guc: outstanding G2H accounting
drm/i915/guc: Unwind context requests in reverse order drm/i915/guc: Don't drop ce->guc_active.lock when unwinding context drm/i915/guc: Flush the work queue for GuC generated G2H drm/i915/guc: Do not clear enable during reset in an enable is
inflight
drm/i915/guc: Don't enable scheduling on a banned context drm/i915/selftests: Fix memory corruption in live_lrc_isolation drm/i915/selftests: Add initial GuC selftest for scrubbing lost G2H

 drivers/gpu/drm/i915/gt/intel_context_types.h |  18 +++
 drivers/gpu/drm/i915/gt/selftest_lrc.c        |  29 +++-
 .../gpu/drm/i915/gt/uc/intel_guc_submission.c |  69 +++++++---
 drivers/gpu/drm/i915/gt/uc/selftest_guc.c     | 126 ++++++++++++++++++
 .../drm/i915/selftests/i915_live_selftests.h  |   1 +
 .../i915/selftests/intel_scheduler_helpers.c  |  12 ++
 .../i915/selftests/intel_scheduler_helpers.h  |   2 +
 7 files changed, 239 insertions(+), 18 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/gt/uc/selftest_guc.c
Signature · 1 line
2.32.0