Skip to content

bnxt: Tx NAPI disabling resiliency improvements

Jakub Kicinski netdev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 3 repliesIn review
  2. v24 patches 7 repliesSuperseded
  3. v14 patches 4 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4bnxt: don't lock the tx queue from napi polldrivers/net/ethernet/broadcom/bnxt/bnxt.c+32 -220 replies
2/4bnxt: disable napi before canceling DIMdrivers/net/ethernet/broadcom/bnxt/bnxt.c+1 -20 replies
3/4bnxt: make sure xmit_more + errors does not miss doorbellsdrivers/net/ethernet/broadcom/bnxt/bnxt.c drivers/net/ethernet/broadcom/bnxt/bnxt.h+27 -130 replies
4/4bnxt: count Tx dropsdrivers/net/ethernet/broadcom/bnxt/bnxt.c+2 -00 replies

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMichael ChanEdwin Peer
SeriesR-b R-b
1/4
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH net v3 0/4] bnxt: Tx NAPI disabling resiliency improvements

A lockdep warning was triggered by netpoll because napi poll was taking the xmit lock. Fix that and a couple more issues noticed while reading the code.

Jakub Kicinski (4):
bnxt: don't lock the tx queue from napi poll
bnxt: disable napi before canceling DIM
bnxt: make sure xmit_more + errors does not miss doorbells
bnxt: count Tx drops

 drivers/net/ethernet/broadcom/bnxt/bnxt.c | 98 ++++++++++++++---------
 drivers/net/ethernet/broadcom/bnxt/bnxt.h |  1 +
 2 files changed, 62 insertions(+), 37 deletions(-)
Signature · 1 line
2.31.1