Remove in-tree usage of MAP_DENYWRITE
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest7 patches 10 repliesIn review
- v17 patches 76 repliesSuperseded
Changes in v2 from the cover letter
- "kernel/fork: factor out replacing the current MM exe_file" -- Call the function "replace_mm_exe_file()" instead
-- Add some doc, similar to set_mm_exe_file()
-- Update patch subject/description
- "kernel/fork: always deny write access to current MM exe_file" -- Introduce dup_mm_exe_file()
-- Make set_mm_exe_file() return an error to make the code easier to
grasp.
-- Improve comments
- Added ACKs
- Mention "sys_prctl(PR_SET_MM_MAP/EXE_FILE)" everywhere instead of only "sys_prctl(PR_SET_MM_EXE_FILE)".
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | binfmt: don't use MAP_DENYWRITE when loading shared libraries via uselib()arch/ fs/ fs/ | +3 | 3 replies | |
| 2/7 | kernel/fork: factor out replacing the current MM exe_fileinclude/ kernel/ kernel/ | +43 | 4 replies | |
| 3/7 | kernel/fork: always deny write access to current MM exe_filefs/ include/ kernel/ | +48 | 0 replies | |
| 4/7 | binfmt: remove in-tree usage of MAP_DENYWRITEarch/ fs/ fs/ +1 more | +7 | 0 replies | |
| 5/7 | mm: remove VM_DENYWRITEfs/ include/ include/ +5 more | +5 | 0 replies | |
| 6/7 | mm: ignore MAP_DENYWRITE in ksys_mmap_pgoff()include/ mm/ mm/ | +2 | 0 replies | |
| 7/7 | fs: update documentation of get_write_access() and friendsinclude/ | +12 | 0 replies |
Reviews trailers per patch
All 7 patches have a Reviewed-by or Acked-by.
| Patch | Eric W. Biederman | Christian Brauner |
|---|---|---|
| 1/7 | A-b | |
| 2/7 | A-b | A-b |
| 3/7 | A-b | |
| 4/7 | A-b | |
| 5/7 | A-b | |
| 6/7 | A-b | |
| 7/7 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/7] Remove in-tree usage of MAP_DENYWRITE
This series removes all in-tree usage of MAP_DENYWRITE from the kernel and removes VM_DENYWRITE. We stopped supporting MAP_DENYWRITE for user space applications a while ago because of the chance for DoS. The last renaming user is binfmt binary loading during exec and legacy library loading via uselib().
With this change, MAP_DENYWRITE is effectively ignored throughout the kernel. Although the net change is small (well, we actually add code and comments), I think the cleanup in mmap() is quite nice.
There are some (minor) user-visible changes with this series:
1. We no longer deny write access to shared libaries loaded via legacy uselib(); this behavior matches modern user space e.g., via dlopen().
2. We no longer deny write access to the elf interpreter after exec completed, treating it just like shared libraries (which it often is).
3. We always deny write access to the file linked via /proc/pid/exe:
sys_prctl(PR_SET_MM_MAP/EXE_FILE) will fail if write access to the file cannot be denied, and write access to the file will remain denied until the link is effectivel gone (exec, termination, sys_prctl(PR_SET_MM_MAP/EXE_FILE)) -- just as if exec'ing the file.
There is a related problem [2] with overlayfs, that should at least partly be tackled by this series. I don't quite understand the interaction of overlayfs and deny_write_access()/allow_write_access() at exec time:
If we end up denying write access to the wrong file and not to the realfile, that would be fundamentally broken. We would have to reroute our deny_write_access()/ allow_write_access() calls for the exec file to the realfile -- but I leave figuring out the details to overlayfs guys, as that would be a related but different issue.
There was a lengthy discussion in [3] whether to remove deny_write_access() completely; however, if we decide to go that way, it would ideally be done on top, because it could be that some applications even rely on the current behavior.
v1 -> v2:
- "kernel/fork: factor out replacing the current MM exe_file" -- Call the function "replace_mm_exe_file()" instead
-- Add some doc, similar to set_mm_exe_file()
-- Update patch subject/description
- "kernel/fork: always deny write access to current MM exe_file" -- Introduce dup_mm_exe_file()
-- Make set_mm_exe_file() return an error to make the code easier to
grasp.
-- Improve comments
- Added ACKs
- Mention "sys_prctl(PR_SET_MM_MAP/EXE_FILE)" everywhere instead of only "sys_prctl(PR_SET_MM_EXE_FILE)".
RFC -> v1:
- "binfmt: remove in-tree usage of MAP_DENYWRITE"
-- Add a note that this should fix part of a problem with overlayfs
[1] https://lore.kernel.org/r/[email protected]/
[2] https://lore.kernel.org/r/[email protected]/
[3] https://lkml.kernel.org/r/[email protected]
David Hildenbrand (7):
binfmt: don't use MAP_DENYWRITE when loading shared libraries via
uselib()
kernel/fork: factor out replacing the current MM exe_file kernel/fork: always deny write access to current MM exe_file
binfmt: remove in-tree usage of MAP_DENYWRITE
mm: remove VM_DENYWRITE
mm: ignore MAP_DENYWRITE in ksys_mmap_pgoff()
fs: update documentation of get_write_access() and friends
arch/x86/ia32/ia32_aout.c | 8 ++- fs/binfmt_aout.c | 7 ++- fs/binfmt_elf.c | 6 +-- fs/binfmt_elf_fdpic.c | 2 +- fs/exec.c | 4 +- fs/proc/task_mmu.c | 1 - include/linux/fs.h | 19 ++++--- include/linux/mm.h | 4 +- include/linux/mman.h | 4 +- include/trace/events/mmflags.h | 1 - kernel/events/core.c | 2 - kernel/fork.c | 95 ++++++++++++++++++++++++++++++---- kernel/sys.c | 33 +----------- lib/test_printf.c | 5 +- mm/mmap.c | 29 ++--------- mm/nommu.c | 2 - 16 files changed, 119 insertions(+), 103 deletions(-)
base-commit: 7c60610d476766e128cc4284bb6349732cbd6606
Signature · 1 line
2.31.1