Skip to content

net: ipa: last things before PM conversion

Alex Elder lkml netdev 1 version Applied

Status from this message: This series was applied to netdev/net-next.git (refs/heads/master):

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 8 repliesApplied 6/6

Patches in v1 All 6 applied

#Subject and filesSizeRepliesApplied
1/6net: ipa: enable wakeup in ipa_power_setup()drivers/net/ipa/ipa_clock.c drivers/net/ipa/ipa_clock.h drivers/net/ipa/ipa_main.c+14 -70 repliesApplied
2/6net: ipa: distinguish system from runtime suspenddrivers/net/ipa/ipa_clock.c+31 -70 repliesApplied
3/6net: ipa: re-enable transmit in PM WQ contextdrivers/net/ipa/ipa_modem.c+28 -22 repliesApplied
4/6net: ipa: ensure hardware has power in ipa_start_xmit()drivers/net/ipa/ipa_modem.c+29 -16 repliesApplied
5/6net: ipa: don't stop TX on suspenddrivers/net/ipa/ipa_modem.c+0 -20 repliesApplied
6/6net: ipa: don't hold clock reference while netdev opendrivers/net/ipa/ipa_modem.c+10 -20 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next 0/6] net: ipa: last things before PM conversion

This series contains a few remaining changes needed before fully switching over to using runtime power management rather than the previous "IPA clock" mechanism.

The first patch moves the calls to enable and disable the IPA interrupt as a system wakeup interrupt into "ipa_clock.c" with the rest of the power-related code.

The second adds a flag to make it possible to distinguish runtime suspend from system suspend.

The third and fourth patches arrange for the ->start_xmit path to resume hardware if necessary, to ensure it is powered. If power is not active, the TX queue is stopped, and arrangements are made for the queue to be restarted once hardware power is active again.

The fifth patch keeps the TX queue active during suspend. This isn't necessary for system suspend but it's important for runtime suspend.

And the last patch makes it so we don't hold the hardware active while the modem network device is open.

-Alex

Alex Elder (6):
net: ipa: enable wakeup in ipa_power_setup()
net: ipa: distinguish system from runtime suspend
net: ipa: re-enable transmit in PM WQ context
net: ipa: ensure hardware has power in ipa_start_xmit()
net: ipa: don't stop TX on suspend
net: ipa: don't hold clock reference while netdev open

 drivers/net/ipa/ipa_clock.c | 49 ++++++++++++++++++++-----
 drivers/net/ipa/ipa_clock.h |  4 ++-
 drivers/net/ipa/ipa_main.c  |  6 +---
 drivers/net/ipa/ipa_modem.c | 72 +++++++++++++++++++++++++++++++++----
 4 files changed, 111 insertions(+), 20 deletions(-)
Signature · 1 line
2.27.0