Skip to content

staging: r8188eu: Fix -Wuninitialized instances from clang

Nathan Chancellor linux-staging lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3staging: r8188eu: Remove unused static inline functions in rtw_recv.hdrivers/staging/r8188eu/include/rtw_recv.h+0 -461 reply
2/3staging: r8188eu: Remove uninitialized use of ether_type in portctrl()drivers/staging/r8188eu/core/rtw_recv.c+0 -41 reply
3/3staging: r8188eu: Reorganize error handling in rtw_drv_init()drivers/staging/r8188eu/os_dep/usb_intf.c+10 -104 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchPhillip PotterFabio M. De Francesco
1/3A-b
2/3A-b
3/3A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] staging: r8188eu: Fix -Wuninitialized instances from clang

Hi all,

Commit 987219ad34a6 ("staging: r8188eu: remove lines from Makefile that silence build warnings") exposed some instances of -Wuninitialized in this driver. This series cleans them up. This passes my build tests with GCC and clang against x86_64 allmodconfig.

Cheers,
Nathan

Nathan Chancellor (3):
staging: r8188eu: Remove unused static inline functions in rtw_recv.h
staging: r8188eu: Remove uninitialized use of ether_type in portctrl()
staging: r8188eu: Reorganize error handling in rtw_drv_init()

 drivers/staging/r8188eu/core/rtw_recv.c    |  4 --
 drivers/staging/r8188eu/include/rtw_recv.h | 46 ----------------------
 drivers/staging/r8188eu/os_dep/usb_intf.c  | 20 +++++-----
 3 files changed, 10 insertions(+), 60 deletions(-)

base-commit: 626520f4ba27d92c8caaf2d1f70c4bca4ea3f9de

Signature · 1 line
2.33.0.rc2