Skip to content

PCI/MSI: Clarify the IRQ sysfs ABI for PCI devices

Barry Song intel-wired-lan linux-pci lkml oe-lkp 3 versions – Applied

Status from this message: I applied the first two (above) to pci/msi for v5.16, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 15 repliesApplied
  2. v22 patches 16 repliesSuperseded
  3. v11 patch 2 repliesSuperseded

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/3Documentation: ABI: sysfs-bus-pci: Add description for IRQ entryDocumentation/ABI/testing/sysfs-bus-pci+10 -00 replies
2/3PCI/sysfs: Don't depend on pci_dev.irq for IRQ entrydrivers/pci/pci-sysfs.c+22 -11 reply
3/3PCI/MSI: remove msi_attrib.default_irq in msi_descdrivers/pci/msi.c include/linux/msi.h+5 -911 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchGreg Kroah-Hartman
1/3A-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/3] PCI/MSI: Clarify the IRQ sysfs ABI for PCI devices

From: Barry Song <[email protected]>

/sys/bus/pci/devices/.../irq has been there for many years but it has never been documented. This patchset is trying to clarify it.

-v3:
- Don't attempt to modify the current behaviour of IRQ ABI for MSI-X
- Make MSI IRQ ABI more explicit(return 1st IRQ of the IRQ vector)
- Add Marc's patch of removing default_irq from the previous comment to the series.
Note patch 3/3 indirectly changed the code of pci_restore_msi_state(), drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c is the only driver calling this API. I would appreciate testing done from this driver's maintainers.

-v2:
- split into two patches according to Bjorn's comments;
- Add Greg's Acked-by, thanks for reviewing!
https://lore.kernel.org/lkml/20210820223744.8439-1-21cnbao at gmail.com/

-v1:
https://lore.kernel.org/lkml/20210813122650.25764-1-21cnbao at gmail.com/#t

Barry Song (2):
Documentation: ABI: sysfs-bus-pci: Add description for IRQ entry PCI/sysfs: Don't depend on pci_dev.irq for IRQ entry

Marc Zyngier (1):
PCI/MSI: remove msi_attrib.default_irq in msi_desc

 Documentation/ABI/testing/sysfs-bus-pci | 10 ++++++++++
 drivers/pci/msi.c                       | 12 +++++-------
 drivers/pci/pci-sysfs.c                 | 23 ++++++++++++++++++++++-
 include/linux/msi.h                     |  2 --
 4 files changed, 37 insertions(+), 10 deletions(-)
Signature · 1 line
1.8.3.1