Skip to content

ethool: make --json reliable

Jakub Kicinski netdev 1 version Applied

Status from this message: This series was applied to ethtool/ethtool.git (refs/heads/master):

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 4 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/3ethtool: remove questionable gotoethtool.c+6 -70 replies
2/3ethtool: use dummy args[] entry for no-args caseethtool.c+14 -203 replies
3/3ethtool: return error if command does not support --jsonethtool.c+11 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH ethtool 0/3] ethool: make --json reliable

This series aims to make --json fail if the output is not JSON formatted. This should make writing scripts around ethtool less error prone and give us stronger signal when produced JSON is invalid.

Jakub Kicinski (3):
ethtool: remove questionable goto
ethtool: use dummy args[] entry for no-args case
ethtool: return error if command does not support --json

 ethtool.c | 52 ++++++++++++++++++++++++++++------------------------
 1 file changed, 28 insertions(+), 24 deletions(-)
Signature · 1 line
2.31.1