Skip to content

RFC PCI/ASPM: Remove struct aspm_latency

Saheed O. Bolarinwa linux-pci lkml 5 versions – Applied

Status from this message: Applied to pci/aspm for v5.17, thanks very much! We're chipping away

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 RFC Latest4 patches 1 replyApplied
  2. v4 RFC4 patches 4 repliesSuperseded
  3. v3 RFC3 patches 1 replySuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v2 RFC1 of 3 patches2 repliesSuperseded
v1 RFC3 patches0 repliesSuperseded

Patches in v5 Applied

#Subject and filesSizeRepliesApplied
1/4PCI/ASPM: Move pci_function_0() upwarddrivers/pci/pcie/aspm.c+14 -140 replies
2/4PCI/ASPM: Do not cache link latenciesdrivers/pci/pcie/aspm.c+20 -110 replies
3/4PCI/ASPM: Remove struct pcie_link_state.acceptabledrivers/pci/pcie/aspm.c+9 -190 replies
4/4PCI/ASPM: Remove struct aspm_latencydrivers/pci/pcie/aspm.c+13 -190 replies

Reviews trailers per patch

2 of 4 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchChristoph Hellwig
SeriesR-b
1/4R-b
2/4
3/4
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [RFC PATCH v5 0/4] PCI/ASPM: Remove struct aspm_latency

To validate and set link latency capability, struct aspm_latency and related members defined within struct pcie_link_state are used. However, since there are not many access to theses values, it is possible to directly access and compute these values.

Doing this will also reduce the dependency on struct pcie_link_state.

The series removes struct aspm_latency and related members within struct pcie_link_state. All latencies are now calculated when needed.

VERSION CHANGES:
- v2:
» - directly access downstream by calling pci_function_0()
» instead of using the struct pcie_link_state
- v3:
» - rebase on Linux 5.15-rc2
- v4
» - Create a seprate path to move pci_function_0() upward
- v5
- shorten long lines as noted in the review

MERGE NOTICE:
These series are based on
» 'commit fa55b7dcdc43 ("Linux 5.16-rc1")'

Bolarinwa O. Saheed (1):
PCI/ASPM: Move pci_function_0() upward

Saheed O. Bolarinwa (3):
PCI/ASPM: Do not cache link latencies PCI/ASPM: Remove struct pcie_link_state.acceptable PCI/ASPM: Remove struct aspm_latency

 drivers/pci/pcie/aspm.c | 95 +++++++++++++++++++----------------------
 1 file changed, 44 insertions(+), 51 deletions(-)
Signature · 1 line
2.20.1