Skip to content

Enable two H264 encoder core on MT8195

Irui Wang linux-arm-kernel linux-devicetree linux-media linux-mediatek lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest10 patches 10 repliesIn review
  2. v210 patches 11 repliesSuperseded
  3. v19 patches 12 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10media: mtk-vcodec: Use core type to indicate h264 and vp8 encdrivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c+18 -160 replies
2/10media: mtk-vcodec: export encoder functionsdrivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_pm.c+5 -00 replies
3/10dt-bindings: media: mtk-vcodec: Adds encoder cores dt-bindings for mt8195Documentation/devicetree/bindings/media/mediatek,vcodec-encoder-core.yaml Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml+181 -18 replies
4/10media: mtk-vcodec: Enable venc dual core usagedrivers/media/platform/mtk-vcodec/Makefile drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_core.c +2 more+235 -340 replies
5/10media: mtk-vcodec: mtk-vcodec: Rewrite venc power manage interfacedrivers/media/platform/mtk-vcodec/mtk_vcodec_enc_core.c drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_pm.c +1 more+13 -90 replies
6/10media: mtk-vcodec: Add venc power on/off interfacedrivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_pm.c +1 more+98 -170 replies
7/10media: mtk-vcodec: Rewrite venc clock interfacedrivers/media/platform/mtk-vcodec/mtk_vcodec_enc_pm.c drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_pm.h drivers/media/platform/mtk-vcodec/venc_drv_if.c+84 -250 replies
8/10media: mtk-vcodec: Add more extra processing for venc_multi_core modedrivers/media/platform/mtk-vcodec/mtk_vcodec_util.c drivers/media/platform/mtk-vcodec/mtk_vcodec_util.h drivers/media/platform/mtk-vcodec/venc/venc_h264_if.c+172 -250 replies
9/10media: mtk-vcodec: Add venc_multi_core mode encode processdrivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.h +7 more+115 -420 replies
10/10media: mtk-vcodec: Done encode result to clientdrivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.h +4 more+120 -70 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3, 00/10] Enable two H264 encoder core on MT8195

MT8195 has two H264 encoder cores, they have their own power-domains, clocks, interrupts, register base. The two H264 encoder cores can work together to achieve higher performance, it's a core mode called frame-racing, one core has 4K@30fps performance, two cores can achieve 4K@60fps.
The two encoder core encoding process looks like this:

    VENC Core0: frm#0....frm#2....frm#4....
    VENC Core1: ..frm#1....frm#3....frm#5....

This series of patches are used to enable the two H264 encoder cores, encoding process will be changed:
As-Is: Synchronous
V4L2_VIDIOC_QBUF#0 --> device_run(triger encoder) --> wait encoder IRQ --> encoding done with result --> job_finish
V4l2_VIDIOC_QBUF#1 --> device_run(triger encoder) --> wait encoder IRQ --> encoding done with result --> job_finish
...

To-Be: Asynchronous
V4L2_VIDIOC_QBUF#0 --> device_run(triger encoder) --> job_finish ..V4l2_VIDIOC_QBUF#1 --> device_run(triger encoder) --> job_finish (venc core0 may encode done here, done the encoding result to client) V4L2_VIDIOC_QBUF#2 --> device_run(triger encoder) --> job_finish.

There is no "wait encoder IRQ" synchronous call during frame-racing mode encoding process, it can full use the two encoder cores to achieve higher performance.

---
This series patches dependent on:
media_stage tree:
[1]
https://git.linuxtv.org/media_stage.git/commit/?id=b3627647f9ea7473d10fb08a95fd7c4133a17ca4

mt8192 decoder:
[2] https://patchwork.kernel.org/project/linux-mediatek/list/?series=616991

patch3 new venc dt-bindings included files
[3] MM IOMMU binding:
https://patchwork.kernel.org/project/linux-mediatek/patch/[email protected]/

[4] MT8195 power domain:
https://patchwork.kernel.org/project/linux-mediatek/list/?series=580579

changes compared with v2:
- update venc core dt-bindings, add two new properties for current usage.
- parse venc multi_core mode from device tree.
- rebase to the newer linux media stage.

changes compared with v1:
- of_platform_populate was used in place of the component framework.
- new yaml file for venc cores.
- some modifications for patch v1's review comments.
---

Irui Wang (10):
media: mtk-vcodec: Use core type to indicate h264 and vp8 enc
media: mtk-vcodec: export encoder functions
dt-bindings: media: mtk-vcodec: Adds encoder cores dt-bindings for

    mt8195

media: mtk-vcodec: Enable venc dual core usage
media: mtk-vcodec: mtk-vcodec: Rewrite venc power manage interface
media: mtk-vcodec: Add venc power on/off interface
media: mtk-vcodec: Rewrite venc clock interface
media: mtk-vcodec: Add more extra processing for venc_multi_core mode
media: mtk-vcodec: Add venc_multi_core mode encode process
media: mtk-vcodec: Done encode result to client

 .../media/mediatek,vcodec-encoder-core.yaml   | 181 +++++++++++++++
 .../media/mediatek,vcodec-encoder.yaml        |   1 -
 drivers/media/platform/mtk-vcodec/Makefile    |   4 +-
 .../platform/mtk-vcodec/mtk_vcodec_drv.h      |  36 ++-
 .../platform/mtk-vcodec/mtk_vcodec_enc.c      | 113 +++++++---
 .../platform/mtk-vcodec/mtk_vcodec_enc.h      |   7 +-
 .../platform/mtk-vcodec/mtk_vcodec_enc_core.c | 169 ++++++++++++++
 .../platform/mtk-vcodec/mtk_vcodec_enc_core.h |  36 +++
 .../platform/mtk-vcodec/mtk_vcodec_enc_drv.c  | 107 +++++----
 .../platform/mtk-vcodec/mtk_vcodec_enc_pm.c   | 183 +++++++++++++--
 .../platform/mtk-vcodec/mtk_vcodec_enc_pm.h   |  11 +-
 .../platform/mtk-vcodec/mtk_vcodec_util.c     |  19 ++
 .../platform/mtk-vcodec/mtk_vcodec_util.h     |   5 +
 .../platform/mtk-vcodec/venc/venc_h264_if.c   | 212 +++++++++++++++---
 .../platform/mtk-vcodec/venc/venc_vp8_if.c    |   3 +-
 .../media/platform/mtk-vcodec/venc_drv_if.c   |  79 +++++--
 .../media/platform/mtk-vcodec/venc_drv_if.h   |   7 +
 .../media/platform/mtk-vcodec/venc_vpu_if.c   |  11 +-
 .../media/platform/mtk-vcodec/venc_vpu_if.h   |   3 +-
 19 files changed, 1026 insertions(+), 161 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/media/mediatek,vcodec-encoder-core.yaml
 create mode 100644 drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_core.c
 create mode 100644 drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_core.h
Signature · 1 line
2.18.0