Skip to content

selftests/bpf: fix flaky send_signal test

Yonghong Song bpf 2 versions New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 0 repliesNew
  2. v12 patches 3 repliesSuperseded

Changes in v2 from the cover letter

remove skip logic where the underlying task in interrupt context is not the intended one.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2selftests/bpf: replace CHECK with ASSERT_* macros in send_signal.ctools/testing/selftests/bpf/prog_tests/send_signal.c+20 -250 replies
2/2selftests/bpf: fix flaky send_signal testtools/testing/selftests/bpf/prog_tests/send_signal.c+16 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH bpf-next v2 0/2] selftests/bpf: fix flaky send_signal test

The bpf selftest send_signal() is flaky for its subtests trying to send signals in softirq/nmi context. To reduce flakiness, the signal-targetted process priority is boosted, which should minimize preemption of that process and improve the possibility that the underlying task in softirq/nmi context is the bpf_send_signal() wanted task.

Patch #1 did a refactoring to use ASSERT_* instead of old CHECK macros. Patch #2 did actual change of boosting priority.

Changelog:
v1 -> v2:
remove skip logic where the underlying task in interrupt context is not the intended one.

Yonghong Song (2):
selftests/bpf: replace CHECK with ASSERT_* macros in send_signal.c selftests/bpf: fix flaky send_signal test

 .../selftests/bpf/prog_tests/send_signal.c    | 61 +++++++++++--------
 1 file changed, 36 insertions(+), 25 deletions(-)
Signature · 1 line
2.30.2