Skip to content

fs/ntfs3: Use kernel alloc wrappers and fix warnings

Kari Argillander lkml ntfs3 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest3 patches 2 repliesIn review
  2. v33 patches 5 repliesSuperseded
  3. v21 patch 0 repliesSuperseded

Changes in v4 from the cover letter

- Wrap whole comment block in patch 1/1 max 80 char. And restyle. Thanks Christoph Hellwig for noting this
- Add Reviewed-by: from Christoph Hellwig to patch 2 and 3

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3fs/ntfs3: Restyle comment block in ni_parse_reparse()fs/ntfs3/frecord.c+10 -61 reply
2/3fs/ntfs3: Do not use driver own alloc wrappersfs/ntfs3/attrib.c fs/ntfs3/attrlist.c fs/ntfs3/bitmap.c +13 more+188 -1940 replies
3/3fs/ntfs3: Use kcalloc/kmalloc_array over kzalloc/kmallocfs/ntfs3/bitmap.c fs/ntfs3/file.c fs/ntfs3/frecord.c+5 -60 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchChristoph Hellwig
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/3] fs/ntfs3: Use kernel alloc wrappers and fix warnings

In ntfs3 driver there is allocation made like this ntfs_malloc(). Patch 2/3 will converter these to kernel ones like kmalloc(). After I did this then checkpatch raise warnings about array allocations so I fix these in patch 3/3.

I also notice when I made patch that there is broken utf8 char so I wanted first fix that because it raised some warning in my editor and did not want to "break" patch 2/3. And because we are editing comment then make whole comment block clean. So patch 1/3 address that. I did try to apply this and it seem to work without issues.

v2:
- Add patch 1/3 because I found broken utf8 char in source file
- Add another patch 3/3 which will fix allocation warnings
- Rewrite some of commit message from first patch
v3:
- Patch series didn't have X/X numbers
- Cover letter didn't have fs/ntfs3 in it
- One kmalloc was converted to kcalloc insted of kmalloc_array Thanks Joe Perches
v4:
- Wrap whole comment block in patch 1/1 max 80 char. And restyle. Thanks Christoph Hellwig for noting this
- Add Reviewed-by: from Christoph Hellwig to patch 2 and 3

Kari Argillander (3):
fs/ntfs3: Restyle comment block in ni_parse_reparse() fs/ntfs3: Do not use driver own alloc wrappers fs/ntfs3: Use kcalloc/kmalloc_array over kzalloc/kmalloc

 fs/ntfs3/attrib.c   |   6 +-
 fs/ntfs3/attrlist.c |  10 +--
 fs/ntfs3/bitmap.c   |   8 +--
 fs/ntfs3/debug.h    |   7 --
 fs/ntfs3/file.c     |   4 +-
 fs/ntfs3/frecord.c  |  42 ++++++-----
 fs/ntfs3/fslog.c    | 172 ++++++++++++++++++++++----------------------
 fs/ntfs3/fsntfs.c   |   8 +--
 fs/ntfs3/index.c    |  54 +++++++-------
 fs/ntfs3/inode.c    |  10 +--
 fs/ntfs3/lznt.c     |   4 +-
 fs/ntfs3/ntfs_fs.h  |  18 ++---
 fs/ntfs3/record.c   |   8 +--
 fs/ntfs3/run.c      |   8 +--
 fs/ntfs3/super.c    |  20 +++---
 fs/ntfs3/xattr.c    |  18 ++---
 16 files changed, 197 insertions(+), 200 deletions(-)
Signature · 1 line
2.25.1