Skip to content

RFC ceph: add debugfs entries signifying new mount syntax support

Venky Shankar ceph-devel oe-kbuild-all 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest2 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2ceph: add helpers to create/cleanup debugfs sub-directories under "ceph" directoryinclude/linux/ceph/debugfs.h net/ceph/debugfs.c+27 -21 reply
2/2ceph: add debugfs entries for v2 (new) mount syntax supportfs/ceph/debugfs.c fs/ceph/super.c fs/ceph/super.h+33 -04 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC 0/2] ceph: add debugfs entries signifying new mount syntax support

[This is based on top of new mount syntax series]

Patrick proposed the idea of having debugfs entries to signify if kernel supports the new (v2) mount syntax. The primary use of this information is to catch any bugs in the new syntax implementation.

This would be done as follows::

The userspace mount helper tries to mount using the new mount syntax and fallsback to using old syntax if the mount using new syntax fails. However, a bug in the new mount syntax implementation can silently result in the mount helper switching to old syntax.

So, the debugfs entries can be relied upon by the mount helper to check if the kernel supports the new mount syntax. Cases when the mount using the new syntax fails, but the kernel does support the new mount syntax, the mount helper could probably log before switching to the old syntax (or fail the mount altogether when run in test mode).

Debugfs entries are as follows::

    /sys/kernel/debug/ceph/
    ....
    ....
    /sys/kernel/debug/ceph/dev_support
    /sys/kernel/debug/ceph/dev_support/v2
    ....
    ....

Note that there is no entry signifying v1 mount syntax. That's because the kernel still supports mounting with old syntax and older kernels do not have debug entries for the same.

Venky Shankar (2):
ceph: add helpers to create/cleanup debugfs sub-directories under
"ceph" directory
ceph: add debugfs entries for v2 (new) mount syntax support

 fs/ceph/debugfs.c            | 28 ++++++++++++++++++++++++++++
 fs/ceph/super.c              |  3 +++
 fs/ceph/super.h              |  2 ++
 include/linux/ceph/debugfs.h |  3 +++
 net/ceph/debugfs.c           | 26 ++++++++++++++++++++++++--
 5 files changed, 60 insertions(+), 2 deletions(-)
Signature · 1 line
2.27.0