Skip to content

Optional counter statistics support

Mark Zhang linux-rdma netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 12 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10net/mlx5: Add support in bth_opcode as a match criteriainclude/linux/mlx5/mlx5_ifc.h+18 -20 replies
2/10net/mlx5: Add priorities for counters in RDMA namespacesdrivers/net/ethernet/mellanox/mlx5/core/fs_core.c include/linux/mlx5/device.h include/linux/mlx5/fs.h+50 -80 replies
3/10RDMA/counters: Support to allocate per-port optional counter statisticsdrivers/infiniband/core/counters.c drivers/infiniband/core/device.c include/rdma/ib_verbs.h +1 more+44 -03 replies
4/10RDMA/mlx5: Add alloc_op_port_stats() supportdrivers/infiniband/hw/mlx5/counters.c drivers/infiniband/hw/mlx5/mlx5_ib.h include/rdma/ib_verbs.h+79 -21 reply
5/10RDMA/mlx5: Add steering support in optional flow countersdrivers/infiniband/hw/mlx5/fs.c drivers/infiniband/hw/mlx5/mlx5_ib.h include/rdma/ib_hdrs.h+124 -00 replies
6/10RDMA/nldev: Add support to add and remove optional countersdrivers/infiniband/core/counters.c drivers/infiniband/core/device.c drivers/infiniband/core/nldev.c +4 more+166 -02 replies
7/10RDMA/mlx5: Add add_op_stat() and remove_op_stat() supportdrivers/infiniband/hw/mlx5/counters.c drivers/infiniband/hw/mlx5/mlx5_ib.h+63 -10 replies
8/10RDMA/nldev: Add support to get optional counters statisticsdrivers/infiniband/core/counters.c drivers/infiniband/core/device.c drivers/infiniband/core/nldev.c +2 more+119 -230 replies
9/10RDMA/mlx5: Add get_op_stats() supportdrivers/infiniband/hw/mlx5/counters.c+23 -00 replies
10/10RDMA/nldev: Add support to get current enabled optional countersdrivers/infiniband/core/nldev.c include/uapi/rdma/rdma_netlink.h+91 -23 replies

Reviews trailers per patch

3 of 10 patches have a Reviewed-by or Acked-by.

PatchMaor Gottlieb
1/10R-b
2/10R-b
3/10
4/10
5/10R-b
6/10
7/10
8/10
9/10
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH rdma-next 00/10] Optional counter statistics support

Hi,

This series from Aharon and Neta provides an extension to the rdma statistics tool that allows to add and remove optional counters dynamically, using new netlink commands.

The idea of having optional counters is to provide to the users the ability to get statistics of counters that hurts performance.

Once an optional counter was added, its statistics will be presented along with all the counters, using the show command.

Binding objects to the optional counters is currently not supported, neither in auto mode nor in manual mode.

To get the list of optional counters that are supported on this device, use "rdma statistic mode supported". To see which counters are currently enabled, use "rdma statistic mode".

$ rdma statistic mode supported
link rocep8s0f0/1
    Optional-set: cc_rx_ce_pkts cc_rx_cnp_pkts cc_tx_cnp_pkts
link rocep8s0f1/1
    Optional-set: cc_rx_ce_pkts cc_rx_cnp_pkts cc_tx_cnp_pkts
$ sudo rdma statistic add link rocep8s0f0/1 optional-set cc_rx_ce_pkts
$ rdma statistic mode
link rocep8s0f0/1
    Optional-set: cc_rx_ce_pkts
$ sudo rdma statistic add link rocep8s0f0/1 optional-set cc_tx_cnp_pkts
$ rdma statistic mode
link rocep8s0f0/1
    Optional-set: cc_rx_ce_pkts cc_tx_cnp_pkts
$ rdma statistic show link rocep8s0f0/1
link rocep8s0f0/1 rx_write_requests 0 rx_read_requests 0 rx_atomic_requests 0 out_of_buffer 0
out_of_sequence 0 duplicate_request 0 rnr_nak_retry_err 0 packet_seq_err 0 implied_nak_seq_err 0
local_ack_timeout_err 0 resp_local_length_error 0 resp_cqe_error 0 req_cqe_error 0
req_remote_invalid_request 0 req_remote_access_errors 0 resp_remote_access_errors 0
resp_cqe_flush_error 0 req_cqe_flush_error 0 roce_adp_retrans 0 roce_adp_retrans_to 0
roce_slow_restart 0 roce_slow_restart_cnps 0 roce_slow_restart_trans 0 rp_cnp_ignored 0
rp_cnp_handled 0 np_ecn_marked_roce_packets 0 np_cnp_sent 0 rx_icrc_encapsulated 0
    Optional-set: cc_rx_ce_pkts 0 cc_tx_cnp_pkts 0
$ sudo rdma statistic remove link rocep8s0f0/1 optional-set cc_rx_ce_pkts
$ sudo rdma statistic remove link rocep8s0f0/1 optional-set cc_tx_cnp_pkts

Thanks

Aharon Landau (9):
net/mlx5: Add support in bth_opcode as a match criteria net/mlx5: Add priorities for counters in RDMA namespaces RDMA/counters: Support to allocate per-port optional counter
statistics
RDMA/mlx5: Add alloc_op_port_stats() support RDMA/mlx5: Add steering support in optional flow counters RDMA/nldev: Add support to add and remove optional counters RDMA/mlx5: Add add_op_stat() and remove_op_stat() support RDMA/mlx5: Add get_op_stats() support
RDMA/nldev: Add support to get current enabled optional counters

Neta Ostrovsky (1):
RDMA/nldev: Add support to get optional counters statistics

 drivers/infiniband/core/counters.c            |  86 +++++
 drivers/infiniband/core/device.c              |   4 +
 drivers/infiniband/core/nldev.c               | 297 ++++++++++++++++--
 drivers/infiniband/hw/mlx5/counters.c         | 157 ++++++++-
 drivers/infiniband/hw/mlx5/fs.c               | 111 +++++++
 drivers/infiniband/hw/mlx5/mlx5_ib.h          |  21 ++
 .../net/ethernet/mellanox/mlx5/core/fs_core.c |  54 +++-
 include/linux/mlx5/device.h                   |   2 +
 include/linux/mlx5/fs.h                       |   2 +
 include/linux/mlx5/mlx5_ifc.h                 |  20 +-
 include/rdma/ib_hdrs.h                        |   1 +
 include/rdma/ib_verbs.h                       |  36 +++
 include/rdma/rdma_counter.h                   |   8 +
 include/rdma/rdma_netlink.h                   |   1 +
 include/uapi/rdma/rdma_netlink.h              |  11 +
 15 files changed, 775 insertions(+), 36 deletions(-)
Signature · 1 line
2.26.2