Skip to content

crypto: remove MD4 generic shash

Ard Biesheuvel keyrings linux-cifs linux-crypto 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 16 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2fs/cifs: Incorporate obsolete MD4 crypto codefs/cifs/Kconfig fs/cifs/cifsfs.c fs/cifs/smbencrypt.c+177 -250 replies
2/2crypto: md4 - Remove obsolete algorithmcrypto/Kconfig crypto/Makefile crypto/md4.c +3 more+1 -3090 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] crypto: remove MD4 generic shash

As discussed on the list [0], MD4 is still being relied upon by the CIFS driver, even though successful attacks on MD4 are as old as Linux itself.

So let's move the code into the CIFS driver, and remove it from the crypto API so that it is no longer exposed to other subsystems or to user space via AF_ALG.

Note: this leaves the code in crypto/asymmetric_keys that is able to parse RSA+MD4 keys if an "md4" shash is available. Given that its Kconfig symbol does not select CRYPTO_MD4, it only has a runtime dependency on md4 and so we can either decide remove it later, or just let it fail on the missing MD4 shash as it would today if the module is not enabled.

[0] https://lore.kernel.org/linux-cifs/[email protected]/

Cc Eric Biggers <[email protected]>
Cc ronnie sahlberg <[email protected]>
Cc linux-cifs <[email protected]>
Cc Steve French <[email protected]>
Cc David Howells <[email protected]>

Ard Biesheuvel (2):
fs/cifs: Incorporate obsolete MD4 crypto code
crypto: md4 - Remove obsolete algorithm

 crypto/Kconfig       |   6 -
 crypto/Makefile      |   1 -
 crypto/md4.c         | 241 --------------------
 crypto/tcrypt.c      |  14 +-
 crypto/testmgr.c     |   6 -
 crypto/testmgr.h     |  42 ----
 fs/cifs/Kconfig      |   1 -
 fs/cifs/cifsfs.c     |   1 -
 fs/cifs/smbencrypt.c | 200 ++++++++++++++--
 9 files changed, 178 insertions(+), 334 deletions(-)
 delete mode 100644 crypto/md4.c
Signature · 1 line
2.20.1