Skip to content

scsi: remove last references to scsi_cmnd.tag

Hannes Reinecke linux-scsi 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4scsi: Introduct scsi_cmd_to_tag()include/scsi/scsi_cmnd.h+7 -02 replies
2/4fas216: kill scmd->tagdrivers/scsi/arm/fas216.c+8 -230 replies
3/4acornscsi: remove tagged queuing vestigesdrivers/scsi/arm/Kconfig drivers/scsi/arm/acornscsi.c drivers/scsi/arm/queue.c+23 -930 replies
4/4scsi: remove 'current_tag'include/scsi/scsi_device.h+0 -10 replies

Reviews trailers per patch

1 of 4 patches has a Reviewed-by or Acked-by.

PatchJohn Garry
1/4R-b
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] scsi: remove last references to scsi_cmnd.tag

Hi all,

with commit 4c7b6ea336c1 ("scsi: core: Remove scsi_cmnd.tag") drivers cannot reference the SCSI command tag anymore.
Arguably these drivers would have stopped working since 2010 with the switch to block layer tags in SCSI anyway, so chances are no-one had been using tagging in these drivers.

This patchset fixes up these usage; for fas216 we're just switching to use the appropriate wrapper.
For acornscsi the tagged queue handling is removed altogether as it was broken in the first place, and no-one since the switch to git could be bothered to fix it.
And the patchset has the nice side-effect that we can remove the scsi_device.current_tag field.

As usual, comments and reviews are welcome.

Hannes Reinecke (4):
scsi: Introduct scsi_cmd_to_tag()
fas216: kill scmd->tag
acornscsi: remove tagged queuing vestiges
scsi: remove 'current_tag'

 drivers/scsi/arm/Kconfig     |  11 ----
 drivers/scsi/arm/acornscsi.c | 103 ++++++++---------------------------
 drivers/scsi/arm/fas216.c    |  31 +++--------
 drivers/scsi/arm/queue.c     |   2 +-
 include/scsi/scsi_cmnd.h     |   7 +++
 include/scsi/scsi_device.h   |   1 -
 6 files changed, 38 insertions(+), 117 deletions(-)
Signature · 1 line
2.29.2