Skip to content

RFC ACPI, PMICs and probing cameras

Sakari Ailus linux-acpi linux-media 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest3 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3imx258: Defer probing on ident register read fail (on ACPI)drivers/media/i2c/imx258.c+8 -04 replies
2/3gpio-tps68470: Allow building as moduledrivers/gpio/Kconfig drivers/gpio/gpio-tps68470.c+4 -21 reply
3/3gpio-tps68470: Add modaliasdrivers/gpio/gpio-tps68470.c+1 -01 reply

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchAndy Shevchenko
1/3
2/3A-b
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC 0/3] ACPI, PMICs and probing cameras

Hi all,

The intel_skl_int3472 driver is required for some of the ACPI power state transitions to function. This driver may be compiled as a module and thus may probe after a sensor driver that depends on it (e.g. imx258).

Make the sensor driver return -EPROBE_DEFER if the sensor cannot be found. This way the sensor driver will be probed when both the intel_skl_int3472 and the gpio-tps68470 drivers have successfully probed while also the gpio-tps68470 driver may be built as a module.

The drawback of the approach is needless probing of the imx258 driver but everything can be built as modules.

I'm posting this as RFC since the approach would require effectively all ACPI based sensor drivers to have the same check. This would be a non-issue to add. I wouldn't mind but...

Is there a way to figure out whether the PMIC opregion callbacks actually succeed? At least the imx258 driver is happily probed even if the driver implementing the opregion callback is not there, and thus the device remains powered off --- and probe fails.

Sakari Ailus (3):
imx258: Defer probing on ident register read fail (on ACPI)
gpio-tps68470: Allow building as module
gpio-tps68470: Add modalias

 drivers/gpio/Kconfig         | 2 +-
 drivers/gpio/gpio-tps68470.c | 5 ++++-
 drivers/media/i2c/imx258.c   | 8 ++++++++
 3 files changed, 13 insertions(+), 2 deletions(-)
Signature · 1 line
2.30.2