Parallel submission aka multi-bb execbuf
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest27 patches 72 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/27 | drm/i915/guc: Squash Clean up GuC CI failures, simplify locking, and kernel DOCdrivers/ drivers/ drivers/ +13 more | +965 | 0 replies | |
| 2/27 | drm/i915/guc: Allow flexible number of context idsdrivers/ drivers/ | +13 | 2 replies | |
| 3/27 | drm/i915/guc: Connect the number of guc_ids to debugfsdrivers/ drivers/ | +33 | 2 replies | |
| 4/27 | drm/i915/guc: Take GT PM ref when deregistering contextdrivers/ drivers/ drivers/ +5 more | +199 | 5 replies | |
| 5/27 | drm/i915: Add GT PM unpark workerdrivers/ drivers/ drivers/ +7 more | +119 | 6 replies | |
| 6/27 | drm/i915/guc: Take engine PM when a context is pinned with GuC submissiondrivers/ drivers/ drivers/ +2 more | +73 | 4 replies | |
| 7/27 | drm/i915/guc: Don't call switch_to_kernel_context with GuC submissiondrivers/ | +9 | 5 replies | |
| 8/27 | drm/i915: Add logical engine mappingdrivers/ drivers/ drivers/ +2 more | +60 | 9 replies | |
| 9/27 | drm/i915: Expose logical engine instance to userdrivers/ include/ | +9 | 2 replies | |
| 10/27 | drm/i915/guc: Introduce context parent-child relationshipdrivers/ drivers/ drivers/ | +91 | 2 replies | |
| 11/27 | drm/i915/guc: Implement parallel context pin / unpin functionsdrivers/ | +70 | 0 replies | |
| 12/27 | drm/i915/guc: Add multi-lrc context registrationdrivers/ drivers/ drivers/ +1 more | +126 | 4 replies | |
| 13/27 | drm/i915/guc: Ensure GuC schedule operations do not operate on child contextsdrivers/ | +18 | 2 replies | |
| 14/27 | drm/i915/guc: Assign contexts in parent-child relationship consecutive guc_idsdrivers/ drivers/ | +86 | 2 replies | |
| 15/27 | drm/i915/guc: Implement multi-lrc submissiondrivers/ drivers/ drivers/ +3 more | +317 | 4 replies | |
| 16/27 | drm/i915/guc: Insert submit fences between requests in parent-child relationshipdrivers/ drivers/ drivers/ +1 more | +109 | 1 reply | |
| 17/27 | drm/i915/guc: Implement multi-lrc resetdrivers/ drivers/ | +51 | 2 replies | |
| 18/27 | drm/i915/guc: Update debugfs for GuC multi-lrcdrivers/ | +37 | 2 replies | |
| 19/27 | drm/i915: Fix bug in user proto-context creation that leaked contextsdrivers/ | +1 | 4 replies | |
| 20/27 | drm/i915/guc: Connect UAPI to GuC multi-lrc interfacedrivers/ drivers/ drivers/ +6 more | +485 | 2 replies | |
| 21/27 | drm/i915/doc: Update parallel submit doc to point to i915_drm.hDocumentation/ Documentation/ | +2 | 1 reply | |
| 22/27 | drm/i915/guc: Add basic GuC multi-lrc selftestdrivers/ drivers/ drivers/ | +182 | 1 reply | |
| 23/27 | drm/i915/guc: Implement no mid batch preemption for multi-lrcdrivers/ drivers/ drivers/ +1 more | +287 | 7 replies | |
| 24/27 | drm/i915: Multi-BB execbufdrivers/ drivers/ drivers/ +4 more | +573 | 1 reply | |
| 25/27 | drm/i915/guc: Handle errors in multi-lrc requestsdrivers/ | +58 | 2 replies | |
| 26/27 | drm/i915: Enable multi-bb execbufdrivers/ | +0 | 0 replies | |
| 27/27 | drm/i915/execlists: Weak parallel submission support for execlistsdrivers/ drivers/ drivers/ +2 more | +65 | 0 replies |
Reviews trailers per patch
5 of 27 patches have a Reviewed-by or Acked-by.
| Patch | Daniel Vetter | John Harrison |
|---|---|---|
| 1/27 | ||
| 2/27 | ||
| 3/27 | ||
| 4/27 | ||
| 5/27 | ||
| 6/27 | ||
| 7/27 | R-b | |
| 8/27 | ||
| 9/27 | R-b | |
| 10/27 | ||
| 11/27 | ||
| 12/27 | ||
| 13/27 | ||
| 14/27 | ||
| 15/27 | ||
| 16/27 | R-b | |
| 17/27 | ||
| 18/27 | ||
| 19/27 | ||
| 20/27 | ||
| 21/27 | R-b | |
| 22/27 | R-b | |
| 23/27 | ||
| 24/27 | ||
| 25/27 | ||
| 26/27 | ||
| 27/27 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 00/27] Parallel submission aka multi-bb execbuf
As discussed in [1] we are introducing a new parallel submission uAPI for the i915 which allows more than 1 BB to be submitted in an execbuf IOCTL. This is the implemenation for both GuC and execlists.
In addition to selftests in the series, an IGT is available implemented in the first 4 patches [2].
Media UMD changes to land soon.
First patch in the series in a squashed patch of [3] and does not need to be reviewed here.
The execbuf IOCTL changes have been done in a single large patch (#24) as all the changes flow together and I believe a single patch will be better if some one has to lookup this change in the future. Can split in a series of smaller patches if desired.
This code is available in a public [4] repo for UMD teams to test there code on.
v2: Drop complicated state machine to block in kernel if no guc_ids available, perma-pin parallel contexts, reworker execbuf IOCTL to be a series of loops inside the IOCTL rather than 1 large one on the outside, address Daniel Vetter's comments, rebase on [3]
[1] https://patchwork.freedesktop.org/series/92028/
[2] https://patchwork.freedesktop.org/series/93071/
[3] https://patchwork.freedesktop.org/series/93704/
[4] https://gitlab.freedesktop.org/mbrost/mbrost-drm-intel/-/tree/drm-intel-parallel
Matthew Brost (27):
drm/i915/guc: Squash Clean up GuC CI failures, simplify locking, and
kernel DOC
drm/i915/guc: Allow flexible number of context ids drm/i915/guc: Connect the number of guc_ids to debugfs drm/i915/guc: Take GT PM ref when deregistering context drm/i915: Add GT PM unpark worker
drm/i915/guc: Take engine PM when a context is pinned with GuC
submission
drm/i915/guc: Don't call switch_to_kernel_context with GuC submission drm/i915: Add logical engine mapping
drm/i915: Expose logical engine instance to user drm/i915/guc: Introduce context parent-child relationship drm/i915/guc: Implement parallel context pin / unpin functions drm/i915/guc: Add multi-lrc context registration drm/i915/guc: Ensure GuC schedule operations do not operate on child
contexts
drm/i915/guc: Assign contexts in parent-child relationship consecutive
guc_ids
drm/i915/guc: Implement multi-lrc submission
drm/i915/guc: Insert submit fences between requests in parent-child
relationship
drm/i915/guc: Implement multi-lrc reset
drm/i915/guc: Update debugfs for GuC multi-lrc
drm/i915: Fix bug in user proto-context creation that leaked contexts drm/i915/guc: Connect UAPI to GuC multi-lrc interface drm/i915/doc: Update parallel submit doc to point to i915_drm.h drm/i915/guc: Add basic GuC multi-lrc selftest drm/i915/guc: Implement no mid batch preemption for multi-lrc drm/i915: Multi-BB execbuf
drm/i915/guc: Handle errors in multi-lrc requests drm/i915: Enable multi-bb execbuf
drm/i915/execlists: Weak parallel submission support for execlists
Documentation/gpu/rfc/i915_parallel_execbuf.h | 122 - Documentation/gpu/rfc/i915_scheduler.rst | 4 +- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/gem/i915_gem_context.c | 222 +- .../gpu/drm/i915/gem/i915_gem_context_types.h | 6 + .../gpu/drm/i915/gem/i915_gem_execbuffer.c | 765 ++++-- drivers/gpu/drm/i915/gt/intel_context.c | 58 +- drivers/gpu/drm/i915/gt/intel_context.h | 52 +- drivers/gpu/drm/i915/gt/intel_context_types.h | 148 +- drivers/gpu/drm/i915/gt/intel_engine.h | 12 +- drivers/gpu/drm/i915/gt/intel_engine_cs.c | 66 +- drivers/gpu/drm/i915/gt/intel_engine_pm.c | 9 + drivers/gpu/drm/i915/gt/intel_engine_pm.h | 20 + drivers/gpu/drm/i915/gt/intel_engine_types.h | 5 + .../drm/i915/gt/intel_execlists_submission.c | 68 +- drivers/gpu/drm/i915/gt/intel_gt.c | 3 + drivers/gpu/drm/i915/gt/intel_gt_pm.c | 8 + drivers/gpu/drm/i915/gt/intel_gt_pm.h | 23 + .../gpu/drm/i915/gt/intel_gt_pm_unpark_work.c | 35 + .../gpu/drm/i915/gt/intel_gt_pm_unpark_work.h | 40 + drivers/gpu/drm/i915/gt/intel_gt_types.h | 10 + drivers/gpu/drm/i915/gt/intel_lrc.c | 7 + drivers/gpu/drm/i915/gt/selftest_execlists.c | 12 +- drivers/gpu/drm/i915/gt/selftest_hangcheck.c | 6 +- drivers/gpu/drm/i915/gt/selftest_lrc.c | 29 +- .../gpu/drm/i915/gt/uc/abi/guc_actions_abi.h | 1 + drivers/gpu/drm/i915/gt/uc/intel_guc.c | 21 + drivers/gpu/drm/i915/gt/uc/intel_guc.h | 61 +- drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c | 2 +- drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 30 +- .../gpu/drm/i915/gt/uc/intel_guc_debugfs.c | 36 + drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h | 10 +- .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 2312 +++++++++++++---- drivers/gpu/drm/i915/gt/uc/selftest_guc.c | 126 + .../drm/i915/gt/uc/selftest_guc_multi_lrc.c | 180 ++ drivers/gpu/drm/i915/i915_gpu_error.c | 39 +- drivers/gpu/drm/i915/i915_query.c | 2 + drivers/gpu/drm/i915/i915_request.c | 120 +- drivers/gpu/drm/i915/i915_request.h | 40 +- drivers/gpu/drm/i915/i915_trace.h | 12 +- drivers/gpu/drm/i915/i915_vma.c | 21 +- drivers/gpu/drm/i915/i915_vma.h | 13 +- drivers/gpu/drm/i915/intel_wakeref.c | 5 + drivers/gpu/drm/i915/intel_wakeref.h | 13 + .../drm/i915/selftests/i915_live_selftests.h | 2 + drivers/gpu/drm/i915/selftests/i915_request.c | 100 + .../i915/selftests/intel_scheduler_helpers.c | 12 + .../i915/selftests/intel_scheduler_helpers.h | 2 + include/uapi/drm/i915_drm.h | 136 +- 49 files changed, 3928 insertions(+), 1099 deletions(-) delete mode 100644 Documentation/gpu/rfc/i915_parallel_execbuf.h create mode 100644 drivers/gpu/drm/i915/gt/intel_gt_pm_unpark_work.c create mode 100644 drivers/gpu/drm/i915/gt/intel_gt_pm_unpark_work.h create mode 100644 drivers/gpu/drm/i915/gt/uc/selftest_guc.c create mode 100644 drivers/gpu/drm/i915/gt/uc/selftest_guc_multi_lrc.c
Signature · 1 line
2.32.0