Skip to content

RFC btrfs: qgroup: rescan enhancement related to INCONSISTENT flag

Qu Wenruo linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest4 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4btrfs: introduce BTRFS_QGROUP_STATUS_FLAGS_MASK for later expansionfs/btrfs/qgroup.c include/uapi/linux/btrfs_tree.h+8 -20 replies
2/4btrfs: introduce BTRFS_QGROUP_RUNTIME_FLAG_CANCEL_RESCANfs/btrfs/qgroup.c fs/btrfs/qgroup.h+33 -180 replies
3/4btrfs: introduce BTRFS_QGROUP_RUNTIME_FLAG_NO_ACCOUNTING to skip qgroup accountingfs/btrfs/qgroup.c fs/btrfs/qgroup.h+15 -40 replies
4/4btrfs: skip subtree scan if it's too high to avoid low stall in btrfs_commit_transaction()fs/btrfs/qgroup.c+13 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH RFC 0/4] btrfs: qgroup: rescan enhancement related to INCONSISTENT flag

There is a long existing window that if we did some operations marking qgroup INCONSISTENT during a qgroup rescan, the INCONSISTENT bit will be cleared by rescan, leaving incorrect qgroup numbers unnoticed.

Furthermore, when we mark qgroup INCONSISTENT, we can in theory skip all qgroup accountings.
Since the numbers are already crazy, we don't really need to waste time updating something that's already wrong.

So here we introduce two runtime flags:

- BTRFS_QGROUP_RUNTIME_FLAG_CANCEL_RESCAN
To inform any running rescan to exit immediately and don't clear the INCONSISTENT bit on its exit.

- BTRFS_QGROUP_RUNTIME_FLAG_NO_ACCOUNTING
To inform qgroup code not to do any accounting for dirty extents.

But still allow operations on qgroup relationship to be continued.

Both flags will be set when an operation marks the qgroup INCONSISTENT and only get cleared when a new rescan is started.

With those flags, we can have the following enhancement:

- Prevent qgroup rescan to clear inconsistent flag which should be kept If an operation marks qgroup inconsistent when a rescan is running, qgroup rescan will clear the inconsistent flag while the qgroup numbers are already wrong.

- Skip qgroup accountings while qgroup numbers are already inconsistent

- Skip huge subtree accounting when dropping subvolumes With the obvious cost of marking qgroup inconsistent

Reason for RFC:
- If the runtime qgroup flags are acceptable

- If the behavior of marking qgroup inconsistent when dropping large subvolumes

- If the lifespan of runtime qgroup flags are acceptable They have longer than needed lifespan (from inconsistent time point to next rescan), not sure if it's OK.

Qu Wenruo (4):
btrfs: introduce BTRFS_QGROUP_STATUS_FLAGS_MASK for later expansion
btrfs: introduce BTRFS_QGROUP_RUNTIME_FLAG_CANCEL_RESCAN
btrfs: introduce BTRFS_QGROUP_RUNTIME_FLAG_NO_ACCOUNTING to skip
qgroup accounting
btrfs: skip subtree scan if it's too high to avoid low stall in
btrfs_commit_transaction()

 fs/btrfs/qgroup.c               | 82 ++++++++++++++++++++++++---------
 fs/btrfs/qgroup.h               |  3 ++
 include/uapi/linux/btrfs_tree.h |  4 ++
 3 files changed, 67 insertions(+), 22 deletions(-)
Signature · 1 line
2.32.0