Skip to content

target/arm: Reduced-IPA space and highmem fixes

Marc Zyngier kvm kvmarm qemu-devel 5 versions – Applied

Status from this message: Applied to target-arm.next, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest6 patches 5 repliesApplied
  2. v46 patches 11 repliesSuperseded
  3. v35 patches 7 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v25 patches17 repliesSuperseded
v13 patches11 repliesApplied

Patches in v5 Applied

#Subject and filesSizeRepliesApplied
1/6hw/arm/virt: Add a control for the the highmem PCIe MMIOhw/arm/virt-acpi-build.c hw/arm/virt.c include/hw/arm/virt.h+10 -81 reply
2/6hw/arm/virt: Add a control for the the highmem redistributorshw/arm/virt-acpi-build.c hw/arm/virt.c include/hw/arm/virt.h+7 -11 reply
3/6hw/arm/virt: Honor highmem setting when computing the memory maphw/arm/virt.c+7 -30 replies
4/6hw/arm/virt: Use the PA range to compute the memory maphw/arm/virt.c+52 -121 reply
5/6hw/arm/virt: Disable highmem devices that don't fit in the PA rangehw/arm/virt.c+28 -61 reply
6/6hw/arm/virt: Drop superfluous checks against highmemhw/arm/virt-acpi-build.c hw/arm/virt.c+1 -60 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchAndrew JonesEric Auger
1/6R-b
2/6R-b R-b
3/6R-b R-b
4/6R-b
5/6R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/6] target/arm: Reduced-IPA space and highmem fixes

Here's yet another stab at enabling QEMU on systems with pathologically reduced IPA ranges such as the Apple M1 (previous version at [1]). Eventually, we're able to run a KVM guest with more than just 3GB of RAM on a system with a 36bit IPA space, and at most 123 vCPUs.

This also addresses some pathological QEMU behaviours, where the highmem property is used as a flag allowing exposure of devices that can't possibly fit in the PA space of the VM, resulting in a guest failure.

In the end, we generalise the notion of PA space when exposing individual devices in the expanded memory map, and treat highmem as another flavour of PA space restriction.

This series does a few things:

- introduce new attributes to control the enabling of the highmem GICv3 redistributors and the highmem PCIe MMIO range

- correctly cap the PA range with highmem is off

- generalise the highmem behaviour to any PA range

- disable each highmem device region that doesn't fit in the PA range

- cleanup uses of highmem outside of virt_set_memmap()

This has been tested on an M1-based Mac-mini running Linux v5.16-rc6 with both KVM and TCG.

* From v4: [1]

- Moved cpu_type_valid() check before we compute the memory map
- Drop useless MAX() when computing highest_gpa
- Fixed more deviations from the QEMU coding style
- Collected Eric's RBs, with thanks

[1]: https://lore.kernel.org/r/[email protected]

Marc Zyngier (6):
hw/arm/virt: Add a control for the the highmem PCIe MMIO hw/arm/virt: Add a control for the the highmem redistributors hw/arm/virt: Honor highmem setting when computing the memory map hw/arm/virt: Use the PA range to compute the memory map hw/arm/virt: Disable highmem devices that don't fit in the PA range hw/arm/virt: Drop superfluous checks against highmem

 hw/arm/virt-acpi-build.c | 10 ++--
 hw/arm/virt.c            | 98 ++++++++++++++++++++++++++++++++++------
 include/hw/arm/virt.h    |  5 +-
 3 files changed, 91 insertions(+), 22 deletions(-)
Signature · 1 line
2.30.2