Skip to content

platform/x86: hp_accel: Clean up and convert

Andy Shevchenko lkml platform-driver-x86 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest2 patches 4 repliesIn review

Changes in v2 from the cover letter

- split to two patches (Hans)
- Cc'ed to Kai-Heng (Hans)
- removed stale data structure field in the header file

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2platform/x86: hp_accel: Remove _INI method calldrivers/misc/lis3lv02d/lis3lv02d.h drivers/platform/x86/hp_accel.c+1 -141 reply
2/2platform/x86: hp_accel: Convert to be a platform driverdrivers/platform/x86/hp_accel.c+14 -502 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by.

PatchKai-Heng Feng
1/2T-b
2/2T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [RFT, PATCH v2 0/2] platform/x86: hp_accel: Clean up and convert

The pure ACPI drivers are not needed since we have a platform glue layer in place. This allow to drop a lot of boiler plate code and duplication.

Patch 1 remove confusing call to _INI method and citing myself from v1:
"Not sure what buys us to run _INI on PM calls. It's against the spec
AFAICT. In any case ACPICA runs _INI as per specification when devices are instantiated."

Patch 2 converts to platform driver.

Both needs to be tested, that's why Hans mentioned Kai-Heng.

Changelog v2:
- split to two patches (Hans)
- Cc'ed to Kai-Heng (Hans)
- removed stale data structure field in the header file

Andy Shevchenko (2):
platform/x86: hp_accel: Remove _INI method call platform/x86: hp_accel: Convert to be a platform driver

 drivers/misc/lis3lv02d/lis3lv02d.h |  1 -
 drivers/platform/x86/hp_accel.c    | 78 ++++++------------------------
 2 files changed, 15 insertions(+), 64 deletions(-)
Signature · 1 line
2.32.0