ksmbd: various fixes
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest11 patches 12 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/11 | ksmbd: fix lookup on idmapped mountsfs/ fs/ fs/ | +37 | 0 replies | |
| 2/11 | ksmbd: fix translation in smb2_populate_readdir_entry()fs/ fs/ fs/ | +3 | 0 replies | |
| 3/11 | ksmbd: fix translation in create_posix_rsp_buf()fs/ | +4 | 0 replies | |
| 4/11 | smb2pdu: fix translation in ksmbd_acls_fattr()fs/ fs/ | +11 | 0 replies | |
| 5/11 | ksmbd: fix translation in acl entriesfs/ fs/ fs/ | +33 | 0 replies | |
| 6/11 | ksmbd: fix subauth 0 handling in sid_to_id()fs/ | +2 | 2 replies | |
| 7/11 | ksmbd: fix translation in sid_to_id()fs/ | +18 | 0 replies | |
| 8/11 | ndr: fix translation in ndr_encode_posix_acl()fs/ | +2 | 0 replies | |
| 9/11 | ksmbd: ensure error is surfaced in set_file_basic_info()fs/ | +1 | 0 replies | |
| 10/11 | ksmbd: remove setattr preparations in set_file_basic_info()fs/ | +0 | 6 replies | |
| 11/11 | ksmbd: defer notify_change() callfs/ | +14 | 4 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 00/11] ksmbd: various fixes
From: Christian Brauner <[email protected]>
Hey everyone,
I took the time to look at ksmbd last week and today. I performed various tests, read a bunch of code and discovered a few bugs that I addressed in this series. Most of them simply deal with the translation of ownership between samba ids and unix ids.
The server client model makes it a bit harder to reason about things but in essence ksmbd behaves like a very simple shim sitting on top of the underlying filesystem and thus bares some _vague_ resemblance to overlayfs and other overlay-style filesystems. The crucial thing is that ksmbd calls into the lower filesystem to create and manage filesystem objects. This is inherently a tricky thing to get right as it essentially involves two-level thinking all of the time. The easiest conceptual model I came up with for me is that ksmbd is similar to a userspace process that calls into the filesystem. With this model in mind it becomes a lot clearer how ownership needs to be managed. I tried to reflect that thinking in the commit message explaining why what happens.
Thanks!
Christian
Christian Brauner (11):
ksmbd: fix lookup on idmapped mounts
ksmbd: fix translation in smb2_populate_readdir_entry()
ksmbd: fix translation in create_posix_rsp_buf()
smb2pdu: fix translation in ksmbd_acls_fattr()
ksmbd: fix translation in acl entries
ksmbd: fix subauth 0 handling in sid_to_id()
ksmbd: fix translation in sid_to_id()
ndr: fix translation in ndr_encode_posix_acl()
ksmbd: ensure error is surfaced in set_file_basic_info()
ksmbd: remove setattr preparations in set_file_basic_info()
ksmbd: defer notify_change() call
fs/ksmbd/ndr.c | 4 +-- fs/ksmbd/oplock.c | 6 ++-- fs/ksmbd/smb2pdu.c | 43 +++++++++++++-------------- fs/ksmbd/smb_common.c | 4 +-- fs/ksmbd/smb_common.h | 1 - fs/ksmbd/smbacl.c | 69 +++++++++++++++++++++++++++---------------- fs/ksmbd/smbacl.h | 25 ++++++++++++++++ fs/ksmbd/vfs.c | 47 ++++++++++++++++------------- fs/ksmbd/vfs.h | 3 +- 9 files changed, 125 insertions(+), 77 deletions(-)
base-commit: 0bffa153a2f46dcbced4a48167e91522d8aabe58
Signature · 1 line
2.30.2