Skip to content

aplay: Fix bugs in peak calculations

Takashi Iwai alsa-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5aplay: Fix conversion of unsigned samples in peak calculationaplay/aplay.c+6 -30 replies
2/5aplay: Handle 16bit sample negative overflow in peak calculationsaplay/aplay.c+3 -30 replies
3/5aplay: Don't pass most negative integer to abs() in peak calculationsaplay/aplay.c+4 -10 replies
4/5aplay: Handle upper bound in peak calculationsaplay/aplay.c+2 -00 replies
5/5aplay: Fix out-of-bound access in stereo VU meter drawingaplay/aplay.c+6 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH alsa-utils 0/5] aplay: Fix bugs in peak calculations

The code in aplay for sample peak calculations and VU-meter representation seems to have a lot of bugs. Let's fix them.

Takashi

===

Takashi Iwai (5):
aplay: Fix conversion of unsigned samples in peak calculation
aplay: Handle 16bit sample negative overflow in peak calculations
aplay: Don't pass most negative integer to abs() in peak calculations
aplay: Handle upper bound in peak calculations
aplay: Fix out-of-bound access in stereo VU meter drawing

 aplay/aplay.c | 28 +++++++++++++++++++---------
 1 file changed, 19 insertions(+), 9 deletions(-)
Signature · 1 line
2.26.2