Skip to content

drm/i915: Enable -Wsometimes-uninitialized

Nathan Chancellor dri-devel intel-gfx lkml llvm 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3drm/i915/selftests: Do not use import_obj uninitializeddrivers/gpu/drm/i915/gem/selftests/i915_gem_dmabuf.c+2 -31 reply
2/3drm/i915/selftests: Always initialize err in igt_dmabuf_import_same_driver_lmem()drivers/gpu/drm/i915/gem/selftests/i915_gem_dmabuf.c+2 -01 reply
3/3drm/i915: Enable -Wsometimes-uninitializeddrivers/gpu/drm/i915/Makefile+0 -11 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchThomas HellströmNick Desaulniers
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] drm/i915: Enable -Wsometimes-uninitialized

Commit 46e2068081e9 ("drm/i915: Disable some extra clang warnings") disabled -Wsometimes-uninitialized as noisy but there have been a few fixes to clang that make the false positive rate fairly low so it should be enabled to help catch obvious mistakes. The first two patches fix revent instances of this warning then enables it for i915 like the rest of the tree.

Cheers,
Nathan

Nathan Chancellor (3):
drm/i915/selftests: Do not use import_obj uninitialized drm/i915/selftests: Always initialize err in
igt_dmabuf_import_same_driver_lmem()
drm/i915: Enable -Wsometimes-uninitialized

 drivers/gpu/drm/i915/Makefile                        | 1 -
 drivers/gpu/drm/i915/gem/selftests/i915_gem_dmabuf.c | 7 ++++---
 2 files changed, 4 insertions(+), 4 deletions(-)

base-commit: fb43ebc83e069625cfeeb2490efc3ffa0013bfa4

Signature · 1 line
2.33.0