Clean up GuC CI failures, simplify locking, and kernel DOC
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest27 patches 14 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/27 | drm/i915/guc: Fix blocked context accountingdrivers/ | +1 | 0 replies | |
| 2/27 | drm/i915/guc: Fix outstanding G2H accountingdrivers/ | +12 | 2 replies | |
| 3/27 | drm/i915/guc: Unwind context requests in reverse orderdrivers/ | +4 | 0 replies | |
| 4/27 | drm/i915/guc: Don't drop ce->guc_active.lock when unwinding contextdrivers/ | +0 | 0 replies | |
| 5/27 | drm/i915/guc: Process all G2H message at once in work queuedrivers/ | +3 | 0 replies | |
| 6/27 | drm/i915/guc: Workaround reset G2H is received after schedule done G2Hdrivers/ | +35 | 1 reply | |
| 7/27 | Revert "drm/i915/gt: Propagate change in error status to children on unhold"drivers/ | +0 | 0 replies | |
| 8/27 | drm/i915/selftests: Add a cancel request selftest that triggers a resetdrivers/ | +100 | 2 replies | |
| 9/27 | drm/i915/guc: Kick tasklet after queuing a requestdrivers/ | +1 | 0 replies | |
| 10/27 | drm/i915/guc: Don't enable scheduling on a banned context, guc_id invalid, not registereddrivers/ | +19 | 0 replies | |
| 11/27 | drm/i915/guc: Copy whole golden context, set engine state size of subsetdrivers/ | +22 | 2 replies | |
| 12/27 | drm/i915/selftests: Add initial GuC selftest for scrubbing lost G2Hdrivers/ drivers/ drivers/ +3 more | +185 | 0 replies | |
| 13/27 | drm/i915/guc: Take context ref when cancelling requestdrivers/ | +4 | 0 replies | |
| 14/27 | drm/i915/guc: Don't touch guc_state.sched_state without a lockdrivers/ | +32 | 0 replies | |
| 15/27 | drm/i915/guc: Reset LRC descriptor if register returns -ENODEVdrivers/ | +4 | 0 replies | |
| 16/27 | drm/i915: Allocate error capture in nowait contextdrivers/ | +19 | 2 replies | |
| 17/27 | drm/i915/guc: Flush G2H work queue during resetdrivers/ | +2 | 0 replies | |
| 18/27 | drm/i915/guc: Release submit fence from an irq_workdrivers/ drivers/ | +24 | 0 replies | |
| 19/27 | drm/i915/guc: Move guc_blocked fence to struct guc_statedrivers/ drivers/ drivers/ | +14 | 0 replies | |
| 20/27 | drm/i915/guc: Rework and simplify lockingdrivers/ drivers/ drivers/ | +89 | 0 replies | |
| 21/27 | drm/i915/guc: Proper xarray usage for contexts_lookupdrivers/ | +87 | 0 replies | |
| 22/27 | drm/i915/guc: Drop pin count check trick between sched_disable and re-pindrivers/ drivers/ | +34 | 0 replies | |
| 23/27 | drm/i915/guc: Move GuC priority fields in context under guc_activedrivers/ drivers/ drivers/ | +46 | 1 reply | |
| 24/27 | drm/i915/guc: Move fields protected by guc->contexts_lock into sub structuredrivers/ drivers/ drivers/ +2 more | +69 | 0 replies | |
| 25/27 | drm/i915/guc: Drop guc_active move everything into guc_statedrivers/ drivers/ drivers/ +1 more | +49 | 0 replies | |
| 26/27 | drm/i915/guc: Add GuC kernel docdrivers/ drivers/ drivers/ +1 more | +132 | 1 reply | |
| 27/27 | drm/i915/guc: Drop static inline functions intel_guc_submission.cdrivers/ | +57 | 1 reply |
Reviews trailers per patch
22 of 27 patches have a Reviewed-by or Acked-by.
| Patch | Daniel Vetter | Daniele Ceraolo Spurio |
|---|---|---|
| 1/27 | R-b | |
| 2/27 | ||
| 3/27 | R-b | |
| 4/27 | R-b | |
| 5/27 | R-b | |
| 6/27 | R-b | |
| 7/27 | R-b | |
| 8/27 | ||
| 9/27 | R-b | |
| 10/27 | R-b | |
| 11/27 | R-b | |
| 12/27 | R-b | |
| 13/27 | R-b | |
| 14/27 | R-b | |
| 15/27 | R-b | |
| 16/27 | ||
| 17/27 | R-b | |
| 18/27 | R-b | |
| 19/27 | R-b | |
| 20/27 | R-b | |
| 21/27 | R-b | |
| 22/27 | R-b | |
| 23/27 | R-b | |
| 24/27 | R-b | |
| 25/27 | R-b | |
| 26/27 | ||
| 27/27 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 00/27] Clean up GuC CI failures, simplify locking, and kernel DOC
Daniel Vetter pointed out that locking in the GuC submission code was overly complicated, let's clean this up a bit before introducing more features in the GuC submission backend.
Also fix some CI failures, port fixes from our internal tree, and add a few more selftests for coverage.
Lastly, add some kernel DOC explaining how the GuC submission backend works.
v2: Fix logic error in 'Workaround reset G2H is received after schedule done G2H', don't propagate errors to dependent fences in execlists submissiom, resolve checkpatch issues, resend to correct lists
v3: Fix issue kicking tasklet, drop guc_active, fix ref counting in xarray, add guc_id sub structure, drop inline fuctions, and various other cleanup suggested by Daniel
v4: Address Daniele's feedback, rebase to tip, resend for CI
Matthew Brost (27):
drm/i915/guc: Fix blocked context accounting
drm/i915/guc: Fix outstanding G2H accounting
drm/i915/guc: Unwind context requests in reverse order drm/i915/guc: Don't drop ce->guc_active.lock when unwinding context drm/i915/guc: Process all G2H message at once in work queue drm/i915/guc: Workaround reset G2H is received after schedule done G2H Revert "drm/i915/gt: Propagate change in error status to children on
unhold"
drm/i915/selftests: Add a cancel request selftest that triggers a
reset
drm/i915/guc: Kick tasklet after queuing a request drm/i915/guc: Don't enable scheduling on a banned context, guc_id
invalid, not registered
drm/i915/guc: Copy whole golden context, set engine state size of
subset
drm/i915/selftests: Add initial GuC selftest for scrubbing lost G2H drm/i915/guc: Take context ref when cancelling request drm/i915/guc: Don't touch guc_state.sched_state without a lock drm/i915/guc: Reset LRC descriptor if register returns -ENODEV drm/i915: Allocate error capture in nowait context drm/i915/guc: Flush G2H work queue during reset drm/i915/guc: Release submit fence from an irq_work drm/i915/guc: Move guc_blocked fence to struct guc_state drm/i915/guc: Rework and simplify locking
drm/i915/guc: Proper xarray usage for contexts_lookup drm/i915/guc: Drop pin count check trick between sched_disable and
re-pin
drm/i915/guc: Move GuC priority fields in context under guc_active drm/i915/guc: Move fields protected by guc->contexts_lock into sub
structure
drm/i915/guc: Drop guc_active move everything into guc_state drm/i915/guc: Add GuC kernel doc
drm/i915/guc: Drop static inline functions intel_guc_submission.c
drivers/gpu/drm/i915/gt/intel_context.c | 19 +- drivers/gpu/drm/i915/gt/intel_context_types.h | 81 +- .../drm/i915/gt/intel_execlists_submission.c | 4 - drivers/gpu/drm/i915/gt/selftest_hangcheck.c | 6 +- drivers/gpu/drm/i915/gt/uc/intel_guc.h | 19 +- drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c | 28 +- drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 6 +- .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 996 +++++++++++------- drivers/gpu/drm/i915/gt/uc/selftest_guc.c | 127 +++ drivers/gpu/drm/i915/i915_gpu_error.c | 39 +- drivers/gpu/drm/i915/i915_request.h | 23 +- drivers/gpu/drm/i915/i915_trace.h | 12 +- .../drm/i915/selftests/i915_live_selftests.h | 1 + drivers/gpu/drm/i915/selftests/i915_request.c | 100 ++ .../i915/selftests/intel_scheduler_helpers.c | 12 + .../i915/selftests/intel_scheduler_helpers.h | 2 + 16 files changed, 983 insertions(+), 492 deletions(-) create mode 100644 drivers/gpu/drm/i915/gt/uc/selftest_guc.c
Signature · 1 line
2.32.0