Skip to content

btrfs-progs: check: enhance the csum mismatch error message

Qu Wenruo linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3btrfs-progs: move btrfs_format_csum() to common/utils.[ch]common/utils.c common/utils.h kernel-shared/disk-io.c+20 -170 replies
2/3btrfs-progs: slightly enhance btrfs_format_csum()common/utils.c common/utils.h+9 -70 replies
3/3btrfs-progs: check: output proper csum values for --check-data-csumcheck/main.c+10 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] btrfs-progs: check: enhance the csum mismatch error message

This patchset will change the csum mismatch error message for data csum mismatch, from the old almost meaningless output:

[5/7] checking csums against data
mirror 1 bytenr 13631488 csum 19 expected csum 152 <<<
ERROR: errors found in csum tree

To a more human readable output:

[5/7] checking csums against data
mirror 1 bytenr 13631488 csum 0x13fec125 expected csum 0x98757625
ERROR: errors found in csum tree

Qu Wenruo (3):
btrfs-progs: move btrfs_format_csum() to common/utils.[ch]
btrfs-progs: slightly enhance btrfs_format_csum()
btrfs-progs: check: output proper csum values for --check-data-csum

 check/main.c            | 13 ++++++++++---
 common/utils.c          | 16 ++++++++++++++++
 common/utils.h          |  4 ++++
 kernel-shared/disk-io.c | 19 ++-----------------
 4 files changed, 32 insertions(+), 20 deletions(-)
Signature · 1 line
2.32.0