Skip to content

Prevent inlining for asm blocks with labels

Bill Wendling kvm 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 5 repliesIn review
  2. v11 patch 1 replySuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5libcflag: define the "noinline" macrolib/libcflat.h x86/pmu_lbr.c+3 -21 reply
2/5x86: realmode: mark exec_in_big_real_mode as noinlinex86/realmode.c+1 -14 replies
3/5x86: svm: mark test_run as noinlinex86/svm.c+1 -10 replies
4/5x86: umip: mark do_ring3 as noinlinex86/umip.c+1 -10 replies
5/5x86: vmx: mark some test_* functions as noinlinex86/vmx.c+3 -30 replies

Reviews trailers per patch

1 of 5 patches has a Reviewed-by or Acked-by.

PatchSean Christopherson
1/5R-b
2/5
3/5
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [kvm-unit-tests PATCH v2 0/5] Prevent inlining for asm blocks with labels

Clang may decide to inline some functions that have inline asm with labels. Doing this duplicates the labels, causing the assembler to be complain. These patches add the "noinline" attribute to the functions to prevent this.

v2: Combine "libcflat.h" change and use the new "noinline" macro.

Bill Wendling (5):
libcflag: define the "noinline" macro
x86: realmode: mark exec_in_big_real_mode as noinline
x86: svm: mark test_run as noinline
x86: umip: mark do_ring3 as noinline
x86: vmx: mark some test_* functions as noinline

 lib/libcflat.h | 1 +
 x86/pmu_lbr.c  | 4 ++--
 x86/realmode.c | 2 +-
 x86/svm.c      | 2 +-
 x86/umip.c     | 2 +-
 x86/vmx.c      | 6 +++---
 6 files changed, 9 insertions(+), 8 deletions(-)
Signature · 1 line
2.33.0.309.g3052b89438-goog