RFC Add AMD Secure Nested Paging (SEV-SNP) support
Get series with b4
b4 am [email protected]Versions newest first
- v2 RFC Latest12 patches 31 repliesIn review
Changes in v2 from the cover letter
- rebased onto latest master
- drop SNP config file in favor of a new 'sev-snp-guest' object where all SNP-related params are passed as strings/integers via command-line
- report specific error if BIOS reports invalid address/len for reserved/pre-validated regions (Connor)
- use Range helpers for handling validated region overlaps (Dave)
- simplify error handling in sev_snp_launch_start, and report the correct return code when handling LAUNCH_START failures (Dov)
- add SEV-SNP bit to CPUID 0x8000001f when SNP enabled
- updated query-sev to handle differences between SEV and SEV-SNP
- updated to work against v5 of SEV-SNP host kernel / hypervisor patches
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/12 | i386/sev: introduce "sev-common" type to encapsulate common SEV stateqapi/ target/ | +214 | 2 replies | |
| 2/12 | linux-header: add the SNP specific commandlinux-headers/ | +50 | 2 replies | |
| 3/12 | i386/sev: introduce 'sev-snp-guest' objectdocs/ qapi/ target/ | +379 | 4 replies | |
| 4/12 | i386/sev: initialize SNP contexttarget/ target/ target/ | +31 | 6 replies | |
| 5/12 | i386/sev: add the SNP launch start contexttarget/ target/ | +29 | 0 replies | |
| 6/12 | i386/sev: add support to encrypt BIOS when SEV-SNP is enabledhw/ include/ target/ +2 more | +45 | 0 replies | |
| 7/12 | i386/sev: populate secrets and cpuid page and finalize the SNP launchtarget/ target/ | +189 | 2 replies | |
| 8/12 | target/i386: set SEV-SNP CPUID bit when SNP enabledtarget/ | +1 | 0 replies | |
| 9/12 | target/i386: allow versioned CPUs to specify new cache_infotarget/ | +33 | 0 replies | |
| 10/12 | target/i386: add new EPYC CPU versions with updated cache_infotarget/ | +184 | 0 replies | |
| 11/12 | i386/sev: sev-snp: add support for CPUID validationtarget/ | +143 | 3 replies | |
| 12/12 | i386/sev: update query-sev QAPI format to handle SEV-SNPqapi/ target/ target/ +1 more | +95 | 10 replies |
Reviews trailers per patch
2 of 12 patches have a Reviewed-by or Acked-by.
| Patch | Markus Armbruster |
|---|---|
| 1/12 | A-b |
| 2/12 | |
| 3/12 | A-b |
| 4/12 | |
| 5/12 | |
| 6/12 | |
| 7/12 | |
| 8/12 | |
| 9/12 | |
| 10/12 | |
| 11/12 | |
| 12/12 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [RFC PATCH v2 00/12] Add AMD Secure Nested Paging (SEV-SNP) support
These patches implement SEV-SNP along with CPUID enforcement support for QEMU, and are also available at:
https://github.com/mdroth/qemu/commits/snp-rfc-v2-upstream
They are based on the initial RFC submitted by Brijesh:
https://lore.kernel.org/qemu-devel/[email protected]/T/
Changes since RFC v1:
- rebased onto latest master
- drop SNP config file in favor of a new 'sev-snp-guest' object where all SNP-related params are passed as strings/integers via command-line
- report specific error if BIOS reports invalid address/len for reserved/pre-validated regions (Connor)
- use Range helpers for handling validated region overlaps (Dave)
- simplify error handling in sev_snp_launch_start, and report the correct return code when handling LAUNCH_START failures (Dov)
- add SEV-SNP bit to CPUID 0x8000001f when SNP enabled
- updated query-sev to handle differences between SEV and SEV-SNP
- updated to work against v5 of SEV-SNP host kernel / hypervisor patches
Overview
--------
SEV-SNP builds upon existing SEV and SEV-ES functionality while adding new hardware-based memory protections. SEV-SNP adds strong memory integrity protection to help prevent malicious hypervisor-based attacks like data replay, memory re-mapping and more in order to create an isolated memory encryption environment.
This series depends on the following patches to support SEV-SNP in Linux kernel and OVMF:
guest kernel (v5, part 1):
https://lore.kernel.org/kvm/[email protected]/T/
host kernel (v5, part 2):
https://lore.kernel.org/lkml/[email protected]/
The Qemu patches uses the command id added by the SEV-SNP hypervisor patches to bootstrap the SEV-SNP VMs.
Additional resources
--------------------
SEV-SNP whitepaper
https://www.amd.com/system/files/TechDocs/SEV-SNP-strengthening-vm-isolation-with-integrity-protection-and-more.pdf
APM 2: https://www.amd.com/system/files/TechDocs/24593.pdf (section 15.36)
GHCB spec:
https://developer.amd.com/wp-content/resources/56421.pdf
SEV-SNP firmware specification:
https://www.amd.com/system/files/TechDocs/56860.pdf
----------------------------------------------------------------
Brijesh Singh (6):
linux-header: add the SNP specific command
i386/sev: introduce 'sev-snp-guest' object
i386/sev: initialize SNP context
i386/sev: add the SNP launch start context
i386/sev: add support to encrypt BIOS when SEV-SNP is enabled i386/sev: populate secrets and cpuid page and finalize the SNP launch
Michael Roth (6):
i386/sev: introduce "sev-common" type to encapsulate common SEV state target/i386: set SEV-SNP CPUID bit when SNP enabled target/i386: allow versioned CPUs to specify new cache_info target/i386: add new EPYC CPU versions with updated cache_info i386/sev: sev-snp: add support for CPUID validation i386/sev: update query-sev QAPI format to handle SEV-SNP
docs/amd-memory-encryption.txt | 77 +++- hw/i386/pc_sysfw.c | 7 +- include/sysemu/sev.h | 2 +- linux-headers/linux/kvm.h | 50 +++ qapi/misc-target.json | 71 ++- qapi/qom.json | 94 +++- target/i386/cpu.c | 221 ++++++++- target/i386/monitor.c | 29 +- target/i386/sev-stub.c | 8 +- target/i386/sev.c | 989 +++++++++++++++++++++++++++++++++++------ target/i386/sev_i386.h | 4 + target/i386/trace-events | 4 + 12 files changed, 1374 insertions(+), 182 deletions(-)