Skip to content

mptcp: Optimize received options handling

Mat Martineau mptcp netdev 1 version Applied

Status from this message: This series was applied to netdev/net-next.git (refs/heads/master):

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 0 repliesApplied 5/5

Patches in v1 All 5 applied

#Subject and filesSizeRepliesApplied
1/5mptcp: do not set unconditionally csum_reqd on incoming optnet/mptcp/options.c+1 -30 repliesApplied
2/5mptcp: better binary layout for mptcp_options_receivednet/mptcp/options.c net/mptcp/protocol.h+13 -150 repliesApplied
3/5mptcp: consolidate in_opt sub-options fields in a bitmasknet/mptcp/options.c net/mptcp/protocol.c net/mptcp/protocol.h +1 more+63 -730 repliesApplied
4/5mptcp: optimize the input options processingnet/mptcp/options.c+37 -340 repliesApplied
5/5mptcp: make the locking tx schema more readablenet/mptcp/protocol.c+7 -30 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next 0/5] mptcp: Optimize received options handling

These patches optimize received MPTCP option handling in terms of both storage and fewer conditionals to evaluate in common cases, and also add a couple of cleanup patches.

Patches 1 and 5 do some cleanup in checksum option parsing and clarification of lock handling.

Patches 2 and 3 rearrange struct mptcp_options_received to shrink it slightly and consolidate frequently used fields in the same cache line.

Patch 4 optimizes incoming MPTCP option parsing to skip many extra comparisons in the common case where only a DSS option is present.

Paolo Abeni (5):
mptcp: do not set unconditionally csum_reqd on incoming opt
mptcp: better binary layout for mptcp_options_received
mptcp: consolidate in_opt sub-options fields in a bitmask
mptcp: optimize the input options processing
mptcp: make the locking tx schema more readable

 net/mptcp/options.c  | 141 +++++++++++++++++++------------------------
 net/mptcp/protocol.c |  14 +++--
 net/mptcp/protocol.h |  36 ++++++-----
 net/mptcp/subflow.c  |  40 ++++++------
 4 files changed, 112 insertions(+), 119 deletions(-)

base-commit: deecae7d96843fceebae06445b3f4bf8cceca31a

Signature · 1 line
2.33.0