Skip to content

staging: r8188eu: refactor rtw_macaddr_cfg()

Michael Straube linux-staging lkml 2 versions New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest8 patches 0 repliesNew
  2. v18 patches 0 repliesSuperseded

Changes in v2 from the cover letter

Fixed typo in commit message of patch 1/8.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8staging: r8188eu: use mac_pton() in rtw_macaddr_cfg()drivers/staging/r8188eu/core/rtw_ieee80211.c+4 -60 replies
2/8staging: r8188eu: ensure mac address buffer is properly aligneddrivers/staging/r8188eu/include/rtw_eeprom.h+1 -10 replies
3/8staging: r8188eu: use ETH_ALENdrivers/staging/r8188eu/include/rtw_eeprom.h+1 -10 replies
4/8staging: r8188eu: use is_*_ether_addr() in rtw_macaddr_cfg()drivers/staging/r8188eu/core/rtw_ieee80211.c+1 -40 replies
5/8staging: r8188eu: use random default mac addressdrivers/staging/r8188eu/core/rtw_ieee80211.c+2 -90 replies
6/8staging: r8188eu: use ether_addr_copy() in rtw_macaddr_cfg()drivers/staging/r8188eu/core/rtw_ieee80211.c+2 -20 replies
7/8staging: r8188eu: add missing blank line after declarationsdrivers/staging/r8188eu/core/rtw_ieee80211.c+1 -00 replies
8/8staging: r8188eu: remove unnecessary parenthesesdrivers/staging/r8188eu/core/rtw_ieee80211.c+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/8] staging: r8188eu: refactor rtw_macaddr_cfg()

This series refactors rtw_macaddr_cfg().
- use mac_pton() instead of custom approach
- use *_ether_addr() functions to copy the mac address and check if it is a broadcast or zero address
- assign random default mac address instead of fixed one
- clean up minor style issues

v1 -> v2
Fixed typo in commit message of patch 1/8.

Michael Straube (8):
staging: r8188eu: use mac_pton() in rtw_macaddr_cfg()
staging: r8188eu: ensure mac address buffer is properly aligned
staging: r8188eu: use ETH_ALEN
staging: r8188eu: use is_*_ether_addr() in rtw_macaddr_cfg()
staging: r8188eu: use random default mac address
staging: r8188eu: use ether_addr_copy() in rtw_macaddr_cfg()
staging: r8188eu: add missing blank line after declarations
staging: r8188eu: remove unnecessary parentheses

 drivers/staging/r8188eu/core/rtw_ieee80211.c | 33 +++++++-------------
 drivers/staging/r8188eu/include/rtw_eeprom.h |  2 +-
 2 files changed, 12 insertions(+), 23 deletions(-)
Signature · 1 line
2.33.0