Skip to content

Enable triggered perf query for Xe_HP

Umesh Nerlige Ramappa dri-devel intel-gfx llvm oe-kbuild-all 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8drm/i915/gt: Lock intel_engine_apply_whitelist with uncore->lockdrivers/gpu/drm/i915/gt/intel_workarounds.c+32 -140 replies
2/8drm/i915/gt: Refactor _wa_add to reuse wa_index and wa_list_growdrivers/gpu/drm/i915/gt/intel_workarounds.c+71 -530 replies
3/8drm/i915/gt: Check for conflicting RING_NONPRIVdrivers/gpu/drm/i915/gt/intel_workarounds.c+42 -240 replies
4/8drm/i915/gt: Enable dynamic adjustment of RING_NONPRIVdrivers/gpu/drm/i915/gt/intel_workarounds.c drivers/gpu/drm/i915/gt/intel_workarounds.h drivers/gpu/drm/i915/gt/selftest_workarounds.c+333 -00 replies
5/8drm/i915/perf: Ensure observation logic is not clock gateddrivers/gpu/drm/i915/i915_perf.c drivers/gpu/drm/i915/i915_reg.h+11 -00 replies
6/8drm/i915/perf: Whitelist OA report trigger registersdrivers/gpu/drm/i915/i915_perf.c drivers/gpu/drm/i915/i915_perf_types.h drivers/gpu/drm/i915/i915_reg.h+92 -70 replies
7/8drm/i915/perf: Whitelist OA counter and buffer registersdrivers/gpu/drm/i915/i915_perf.c drivers/gpu/drm/i915/i915_reg.h+31 -30 replies
8/8drm/i915/perf: Map OA buffer to user space for gen12 performance querydrivers/gpu/drm/i915/gem/i915_gem_mman.c drivers/gpu/drm/i915/gem/i915_gem_mman.h drivers/gpu/drm/i915/i915_perf.c +1 more+161 -22 replies

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchUmesh Nerlige RamappaChris WilsonLionel Landwerlin
1/8R-b
2/8R-b
3/8R-b
4/8R-b
5/8R-b
6/8R-b
7/8R-b
8/8R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 0/8] Enable triggered perf query for Xe_HP

This is a revival of the patch series to support triggered perf query reports from here - https://patchwork.freedesktop.org/series/83831/

The patches were not pushed earlier because corresponding UMD changes were missing. This revival addresses UMD changes in GPUvis for this series. GPUvis uses the perf library in igt-gpu-tools. Changes to the library are here -
https://patchwork.freedesktop.org/series/93355/

GPUvis changes will be posted as a PR once the above library and kernel changes are pushed.

Summary of the feature:

Current platforms provide MI_REPORT_PERF_COUNT to query a snapshot of perf counters from a batch. This mechanism does not have consistent support on all engines for newer platforms. To support perf query, all new platforms use a mechanism to trigger OA report snapshots into the OA buffer by writing to a HW register from a batch. To lookup this report in the OA buffer quickly, the OA buffer is mmapped into the user space.

This series implements the new query mechanism.

v2: Fix BAT failure (Umesh)
v3: Fix selftest (Umesh)
v4: Update uapi comment (Umesh)

Test-with: [email protected]

Chris Wilson (3):
drm/i915/gt: Refactor _wa_add to reuse wa_index and wa_list_grow drm/i915/gt: Check for conflicting RING_NONPRIV drm/i915/gt: Enable dynamic adjustment of RING_NONPRIV

Piotr Maciejewski (1):
drm/i915/perf: Ensure observation logic is not clock gated

Umesh Nerlige Ramappa (4):
drm/i915/gt: Lock intel_engine_apply_whitelist with uncore->lock drm/i915/perf: Whitelist OA report trigger registers drm/i915/perf: Whitelist OA counter and buffer registers drm/i915/perf: Map OA buffer to user space for gen12 performance query

 drivers/gpu/drm/i915/gem/i915_gem_mman.c      |   2 +-
 drivers/gpu/drm/i915/gem/i915_gem_mman.h      |   2 +
 drivers/gpu/drm/i915/gt/intel_workarounds.c   | 269 +++++++++++++-----
 drivers/gpu/drm/i915/gt/intel_workarounds.h   |   7 +
 .../gpu/drm/i915/gt/selftest_workarounds.c    | 267 +++++++++++++++++
 drivers/gpu/drm/i915/i915_perf.c              | 228 ++++++++++++++-
 drivers/gpu/drm/i915/i915_perf_types.h        |   8 +
 drivers/gpu/drm/i915/i915_reg.h               |  30 +-
 include/uapi/drm/i915_drm.h                   |  33 +++
 9 files changed, 758 insertions(+), 88 deletions(-)
Signature · 1 line
2.20.1