Skip to content

qapi: Fixes and cleanups for recent work (mostly)

Markus Armbruster qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest12 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12qapi: Simplify QAPISchemaIfCond's interface for generating Cscripts/qapi/gen.py scripts/qapi/introspect.py scripts/qapi/schema.py +2 more+29 -290 replies
2/12qapi: Simplify how QAPISchemaIfCond represents "no condition"scripts/qapi/common.py scripts/qapi/schema.py+3 -30 replies
3/12tests/qapi-schema: Correct two 'if' conditionalstests/qapi-schema/qapi-schema-test.json tests/qapi-schema/qapi-schema-test.out+6 -70 replies
4/12tests/qapi-schema: Demonstrate broken C code for 'if'tests/qapi-schema/doc-good.json tests/qapi-schema/doc-good.out tests/qapi-schema/doc-good.txt +2 more+11 -30 replies
5/12qapi: Fix C code generation for 'if'scripts/qapi/common.py tests/qapi-schema/qapi-schema-test.json+2 -30 replies
6/12qapi: Factor common recursion out of cgen_ifcond(), docgen_ifcond()scripts/qapi/common.py+25 -200 replies
7/12qapi: Avoid redundant parens in code generated for conditionalsscripts/qapi/common.py tests/qapi-schema/doc-good.txt+9 -70 replies
8/12qapi: Use "not COND" instead of "!COND" for generated documentationscripts/qapi/common.py tests/qapi-schema/doc-good.txt+2 -20 replies
9/12qapi: Use re.fullmatch() where appropriatescripts/qapi/expr.py+1 -10 replies
10/12tests/qapi-schema: Hide OrderedDict in test outputtests/qapi-schema/doc-good.out tests/qapi-schema/qapi-schema-test.out tests/qapi-schema/test-qapi.py+28 -190 replies
11/12qapi: Tweak error messages for missing / conflicting meta-typescripts/qapi/expr.py tests/qapi-schema/double-type.err tests/qapi-schema/missing-type.err+11 -180 replies
12/12qapi: Tweak error messages for unknown / conflicting 'if' keysscripts/qapi/expr.py tests/qapi-schema/bad-if-key.err tests/qapi-schema/bad-if-keys.err +1 more+6 -70 replies

Reviews trailers per patch

None of the 12 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMarc-André Lureau
SeriesR-b
1/12
2/12
3/12
4/12
5/12
6/12
7/12
8/12
9/12
10/12
11/12
12/12

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/12] qapi: Fixes and cleanups for recent work (mostly)

Markus Armbruster (12):
qapi: Simplify QAPISchemaIfCond's interface for generating C
qapi: Simplify how QAPISchemaIfCond represents "no condition" tests/qapi-schema: Correct two 'if' conditionals tests/qapi-schema: Demonstrate broken C code for 'if'
qapi: Fix C code generation for 'if'
qapi: Factor common recursion out of cgen_ifcond(), docgen_ifcond()
qapi: Avoid redundant parens in code generated for conditionals
qapi: Use "not COND" instead of "!COND" for generated documentation
qapi: Use re.fullmatch() where appropriate tests/qapi-schema: Hide OrderedDict in test output
qapi: Tweak error messages for missing / conflicting meta-type
qapi: Tweak error messages for unknown / conflicting 'if' keys

 scripts/qapi/common.py                  | 51 ++++++++++++++-----------
 scripts/qapi/expr.py                    | 32 +++++++---------
 scripts/qapi/gen.py                     |  6 +--
 scripts/qapi/introspect.py              |  6 +--
 scripts/qapi/schema.py                  | 12 +++++-
 scripts/qapi/types.py                   | 22 +++++------
 scripts/qapi/visit.py                   | 14 +++----
 tests/qapi-schema/bad-if-key.err        |  2 +-
 tests/qapi-schema/bad-if-keys.err       |  2 +-
 tests/qapi-schema/doc-good.json         |  2 +-
 tests/qapi-schema/doc-good.out          |  6 +--
 tests/qapi-schema/doc-good.txt          |  8 ++--
 tests/qapi-schema/double-type.err       |  4 +-
 tests/qapi-schema/enum-if-invalid.err   |  2 +-
 tests/qapi-schema/missing-type.err      |  2 +-
 tests/qapi-schema/qapi-schema-test.json |  9 +++--
 tests/qapi-schema/qapi-schema-test.out  | 31 ++++++++-------
 tests/qapi-schema/test-qapi.py          | 11 +++++-
 18 files changed, 118 insertions(+), 104 deletions(-)
Signature · 1 line
2.31.1