qapi: Fixes and cleanups for recent work (mostly)
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest12 patches 6 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/12 | qapi: Simplify QAPISchemaIfCond's interface for generating Cscripts/ scripts/ scripts/ +2 more | +29 | 0 replies | |
| 2/12 | qapi: Simplify how QAPISchemaIfCond represents "no condition"scripts/ scripts/ | +3 | 0 replies | |
| 3/12 | tests/qapi-schema: Correct two 'if' conditionalstests/ tests/ | +6 | 0 replies | |
| 4/12 | tests/qapi-schema: Demonstrate broken C code for 'if'tests/ tests/ tests/ +2 more | +11 | 0 replies | |
| 5/12 | qapi: Fix C code generation for 'if'scripts/ tests/ | +2 | 0 replies | |
| 6/12 | qapi: Factor common recursion out of cgen_ifcond(), docgen_ifcond()scripts/ | +25 | 0 replies | |
| 7/12 | qapi: Avoid redundant parens in code generated for conditionalsscripts/ tests/ | +9 | 0 replies | |
| 8/12 | qapi: Use "not COND" instead of "!COND" for generated documentationscripts/ tests/ | +2 | 0 replies | |
| 9/12 | qapi: Use re.fullmatch() where appropriatescripts/ | +1 | 0 replies | |
| 10/12 | tests/qapi-schema: Hide OrderedDict in test outputtests/ tests/ tests/ | +28 | 0 replies | |
| 11/12 | qapi: Tweak error messages for missing / conflicting meta-typescripts/ tests/ tests/ | +11 | 0 replies | |
| 12/12 | qapi: Tweak error messages for unknown / conflicting 'if' keysscripts/ tests/ tests/ +1 more | +6 | 0 replies |
Reviews trailers per patch
None of the 12 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Marc-André Lureau |
|---|---|
| Series | R-b |
| 1/12 | |
| 2/12 | |
| 3/12 | |
| 4/12 | |
| 5/12 | |
| 6/12 | |
| 7/12 | |
| 8/12 | |
| 9/12 | |
| 10/12 | |
| 11/12 | |
| 12/12 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 00/12] qapi: Fixes and cleanups for recent work (mostly)
Markus Armbruster (12):
qapi: Simplify QAPISchemaIfCond's interface for generating C
qapi: Simplify how QAPISchemaIfCond represents "no condition" tests/qapi-schema: Correct two 'if' conditionals tests/qapi-schema: Demonstrate broken C code for 'if'
qapi: Fix C code generation for 'if'
qapi: Factor common recursion out of cgen_ifcond(), docgen_ifcond()
qapi: Avoid redundant parens in code generated for conditionals
qapi: Use "not COND" instead of "!COND" for generated documentation
qapi: Use re.fullmatch() where appropriate tests/qapi-schema: Hide OrderedDict in test output
qapi: Tweak error messages for missing / conflicting meta-type
qapi: Tweak error messages for unknown / conflicting 'if' keys
scripts/qapi/common.py | 51 ++++++++++++++----------- scripts/qapi/expr.py | 32 +++++++--------- scripts/qapi/gen.py | 6 +-- scripts/qapi/introspect.py | 6 +-- scripts/qapi/schema.py | 12 +++++- scripts/qapi/types.py | 22 +++++------ scripts/qapi/visit.py | 14 +++---- tests/qapi-schema/bad-if-key.err | 2 +- tests/qapi-schema/bad-if-keys.err | 2 +- tests/qapi-schema/doc-good.json | 2 +- tests/qapi-schema/doc-good.out | 6 +-- tests/qapi-schema/doc-good.txt | 8 ++-- tests/qapi-schema/double-type.err | 4 +- tests/qapi-schema/enum-if-invalid.err | 2 +- tests/qapi-schema/missing-type.err | 2 +- tests/qapi-schema/qapi-schema-test.json | 9 +++-- tests/qapi-schema/qapi-schema-test.out | 31 ++++++++------- tests/qapi-schema/test-qapi.py | 11 +++++- 18 files changed, 118 insertions(+), 104 deletions(-)
Signature · 1 line
2.31.1