Skip to content

fs/ntfs3: Refactor header includes

Kari Argillander lkml ntfs3 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest8 patches 1 replyIn review
  2. v17 patches 1 replySuperseded

Changes in v2 from the cover letter

Add missing first patch
Rebase
Use base-commit with format-patch

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8fs/ntfs3. Add forward declarations for structs to debug.hfs/ntfs3/debug.h+3 -00 replies
2/8fs/ntfs3: Add missing header files to ntfs.hfs/ntfs3/ntfs.h+9 -00 replies
3/8fs/ntfs3: Add missing headers and forward declarations to ntfs_fs.hfs/ntfs3/ntfs_fs.h+31 -00 replies
4/8fs/ntfs3: Add missing header and guards to lib/ headersfs/ntfs3/lib/decompress_common.h fs/ntfs3/lib/lib.h+11 -00 replies
5/8fs/ntfs3: Change right headers to bitfunc.cfs/ntfs3/bitfunc.c+1 -60 replies
6/8fs/ntfs3: Change right headers to upcase.cfs/ntfs3/upcase.c+2 -60 replies
7/8fs/ntfs3: Change right headers to lznt.cfs/ntfs3/lznt.c+5 -50 replies
8/8fs/ntfs3: Remove unneeded header files from c filesfs/ntfs3/attrib.c fs/ntfs3/attrlist.c fs/ntfs3/bitmap.c +12 more+0 -400 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/8] fs/ntfs3: Refactor header includes

Right now header includes are big mess with ntfs3 imo. We cannot example include ntfs3 headers without need of punch of includes to source file. This patch set try to address that. When this patch series is applied we can include any header file without need of include anything else. This does not mean source file should rely what header file includes. Instead it should include them by self also if it needs them.

When some include is added I have write why this is needed to commit message. Hopefully this will help when someone wants to correct them again. I have also just delete unnecessary headers from some .c files and not added what is needed. Usually deleted headers where there because ntfs_fs.h need them not file itself. When file was simple enough I added all necessary linux headers.

I did not add linux/headers to all files yet. That is big job. This is good starting point. I did try to build every file itself so this will build like it should.

Please do not hesitate to tell if there is something wrong with this series or somethings could be done better.

V2:
Add missing first patch
Rebase
Use base-commit with format-patch

Kari Argillander (8):
fs/ntfs3. Add forward declarations for structs to debug.h fs/ntfs3: Add missing header files to ntfs.h
fs/ntfs3: Add missing headers and forward declarations to ntfs_fs.h fs/ntfs3: Add missing header and guards to lib/ headers fs/ntfs3: Change right headers to bitfunc.c
fs/ntfs3: Change right headers to upcase.c
fs/ntfs3: Change right headers to lznt.c
fs/ntfs3: Remove unneeded header files from c files

 fs/ntfs3/attrib.c                |  5 -----
 fs/ntfs3/attrlist.c              |  3 ---
 fs/ntfs3/bitfunc.c               |  7 +------
 fs/ntfs3/bitmap.c                |  3 ---
 fs/ntfs3/debug.h                 |  3 +++
 fs/ntfs3/dir.c                   |  3 ---
 fs/ntfs3/file.c                  |  1 -
 fs/ntfs3/frecord.c               |  3 ---
 fs/ntfs3/fslog.c                 |  4 ----
 fs/ntfs3/fsntfs.c                |  1 -
 fs/ntfs3/index.c                 |  1 -
 fs/ntfs3/inode.c                 |  2 --
 fs/ntfs3/lib/decompress_common.h |  5 +++++
 fs/ntfs3/lib/lib.h               |  6 ++++++
 fs/ntfs3/lznt.c                  | 10 +++++-----
 fs/ntfs3/namei.c                 |  4 ----
 fs/ntfs3/ntfs.h                  |  9 +++++++++
 fs/ntfs3/ntfs_fs.h               | 31 +++++++++++++++++++++++++++++++
 fs/ntfs3/record.c                |  3 ---
 fs/ntfs3/run.c                   |  2 --
 fs/ntfs3/super.c                 |  2 --
 fs/ntfs3/upcase.c                |  8 ++------
 fs/ntfs3/xattr.c                 |  3 ---
 23 files changed, 62 insertions(+), 57 deletions(-)

base-commit: d3624466b56dd5b1886c1dff500525b544c19c83

Signature · 1 line
2.25.1