Skip to content

staging: r8188eu: remove function pointers from struct hal_ops

Michael Straube linux-staging lkml 3 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest40 patches 2 repliesIn review
  2. v240 patches 0 repliesSuperseded
  3. v140 patches 1 replySuperseded

Changes in v3 from the cover letter

Added this missing patchset version changelog.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/40staging: r8188eu: remove InitSwLeds from hal_opsdrivers/staging/r8188eu/hal/hal_intf.c drivers/staging/r8188eu/hal/usb_halinit.c drivers/staging/r8188eu/include/hal_intf.h +2 more+4 -120 replies
2/40staging: r8188eu: remove DeInitSwLeds from hal_opsdrivers/staging/r8188eu/hal/hal_intf.c drivers/staging/r8188eu/hal/usb_halinit.c drivers/staging/r8188eu/include/hal_intf.h +2 more+2 -120 replies
3/40staging: r8188eu: remove dm_init from hal_opsdrivers/staging/r8188eu/hal/hal_intf.c drivers/staging/r8188eu/hal/rtl8188e_hal_init.c drivers/staging/r8188eu/include/hal_intf.h +1 more+2 -100 replies
4/40staging: r8188eu: remove dm_deinit from hal_opsdrivers/staging/r8188eu/hal/hal_intf.c drivers/staging/r8188eu/hal/rtl8188e_hal_init.c drivers/staging/r8188eu/include/hal_intf.h +1 more+1 -140 replies
5/40staging: r8188eu: remove SetHalODMVarHandler from hal_opsdrivers/staging/r8188eu/core/rtw_ap.c drivers/staging/r8188eu/core/rtw_mlme.c drivers/staging/r8188eu/core/rtw_p2p.c +4 more+10 -270 replies
6/40staging: r8188eu: remove empty functionsdrivers/staging/r8188eu/hal/rtl8188e_hal_init.c drivers/staging/r8188eu/hal/usb_halinit.c drivers/staging/r8188eu/include/rtl8188e_hal.h+0 -200 replies
7/40staging: r8188eu: remove unused function rtw_interface_ps_func()drivers/staging/r8188eu/core/rtw_pwrctrl.c drivers/staging/r8188eu/include/rtw_pwrctrl.h+0 -100 replies
8/40staging: r8188eu: remove interface_ps_func from hal_opsdrivers/staging/r8188eu/hal/hal_intf.c drivers/staging/r8188eu/hal/usb_halinit.c drivers/staging/r8188eu/include/hal_intf.h+0 -230 replies
9/40staging: r8188eu: remove hal_dm_watchdog from hal_opsdrivers/staging/r8188eu/core/rtw_cmd.c drivers/staging/r8188eu/hal/hal_intf.c drivers/staging/r8188eu/hal/rtl8188e_hal_init.c +1 more+2 -120 replies
10/40staging: r8188eu: remove set_bwmode_handler from hal_opsdrivers/staging/r8188eu/core/rtw_wlan_util.c drivers/staging/r8188eu/hal/hal_intf.c drivers/staging/r8188eu/hal/rtl8188e_hal_init.c +1 more+1 -150 replies
11/40staging: r8188eu: remove set_channel_handler from hal_opsdrivers/staging/r8188eu/core/rtw_wlan_util.c drivers/staging/r8188eu/hal/hal_intf.c drivers/staging/r8188eu/hal/rtl8188e_hal_init.c +1 more+2 -140 replies
12/40staging: r8188eu: remove unused enum hal_intf_ps_funcdrivers/staging/r8188eu/include/hal_intf.h+0 -50 replies
13/40staging: r8188eu: remove Add_RateATid from hal_opsdrivers/staging/r8188eu/core/rtw_ap.c drivers/staging/r8188eu/hal/hal_intf.c drivers/staging/r8188eu/hal/rtl8188e_hal_init.c +1 more+3 -140 replies
14/40staging: r8188eu: remove hal_power_on from hal_opsdrivers/staging/r8188eu/hal/hal_intf.c drivers/staging/r8188eu/hal/rtl8188e_hal_init.c drivers/staging/r8188eu/hal/usb_halinit.c +1 more+3 -130 replies
15/40staging: r8188eu: remove sreset_init_value from hal_opsdrivers/staging/r8188eu/hal/hal_intf.c drivers/staging/r8188eu/hal/rtl8188e_hal_init.c drivers/staging/r8188eu/include/hal_intf.h +1 more+2 -100 replies
16/40staging: r8188eu: remove sreset_reset_value from hal_opsdrivers/staging/r8188eu/hal/hal_intf.c drivers/staging/r8188eu/hal/rtl8188e_hal_init.c drivers/staging/r8188eu/include/hal_intf.h +1 more+1 -100 replies
17/40staging: r8188eu: remove silentreset from hal_opsdrivers/staging/r8188eu/hal/hal_intf.c drivers/staging/r8188eu/hal/rtl8188e_hal_init.c drivers/staging/r8188eu/include/hal_intf.h +1 more+1 -100 replies
18/40staging: r8188eu: remove sreset_xmit_status_check from hal_opsdrivers/staging/r8188eu/core/rtw_cmd.c drivers/staging/r8188eu/hal/hal_intf.c drivers/staging/r8188eu/hal/rtl8188e_hal_init.c +1 more+2 -100 replies
19/40staging: r8188eu: remove sreset_linked_status_check from hal_opsdrivers/staging/r8188eu/core/rtw_mlme_ext.c drivers/staging/r8188eu/hal/hal_intf.c drivers/staging/r8188eu/hal/rtl8188e_hal_init.c +1 more+2 -100 replies
20/40staging: r8188eu: remove sreset_get_wifi_status from hal_opsdrivers/staging/r8188eu/hal/hal_intf.c drivers/staging/r8188eu/hal/rtl8188e_hal_init.c drivers/staging/r8188eu/include/hal_intf.h +1 more+1 -160 replies
21/40staging: r8188eu: remove EfusePowerSwitch from hal_opsdrivers/staging/r8188eu/core/rtw_efuse.c drivers/staging/r8188eu/hal/rtl8188e_hal_init.c drivers/staging/r8188eu/include/hal_intf.h+4 -90 replies
22/40staging: r8188eu: rename hal_EfusePowerSwitch_RTL8188E()drivers/staging/r8188eu/hal/rtl8188e_hal_init.c+1 -100 replies
23/40staging: r8188eu: remove wrapper Efuse_PowerSwitch()drivers/staging/r8188eu/core/rtw_efuse.c drivers/staging/r8188eu/core/rtw_mp_ioctl.c drivers/staging/r8188eu/include/rtw_efuse.h+18 -460 replies
24/40staging: r8188eu: remove ReadEFuse from hal_opsdrivers/staging/r8188eu/core/rtw_efuse.c drivers/staging/r8188eu/hal/rtl8188e_hal_init.c drivers/staging/r8188eu/include/hal_intf.h+9 -140 replies
25/40staging: r8188eu: remove EFUSEGetEfuseDefinition from hal_opsdrivers/staging/r8188eu/core/rtw_efuse.c drivers/staging/r8188eu/core/rtw_mp_ioctl.c drivers/staging/r8188eu/hal/rtl8188e_hal_init.c +3 more+32 -590 replies
26/40staging: r8188eu: remove EfuseGetCurrentSize from hal_opsdrivers/staging/r8188eu/core/rtw_efuse.c drivers/staging/r8188eu/hal/rtl8188e_hal_init.c drivers/staging/r8188eu/include/hal_intf.h +1 more+5 -370 replies
27/40staging: r8188eu: remove empty commentsdrivers/staging/r8188eu/core/rtw_efuse.c+5 -70 replies
28/40staging: r8188eu: remove Efuse_PgPacketRead from hal_opsdrivers/staging/r8188eu/core/rtw_efuse.c drivers/staging/r8188eu/core/rtw_mp_ioctl.c drivers/staging/r8188eu/hal/rtl8188e_hal_init.c +2 more+4 -160 replies
29/40staging: r8188eu: remove Efuse_PgPacketWrite from hal_opsdrivers/staging/r8188eu/core/rtw_efuse.c drivers/staging/r8188eu/core/rtw_mp_ioctl.c drivers/staging/r8188eu/hal/rtl8188e_hal_init.c +2 more+7 -200 replies
30/40staging: r8188eu: remove Efuse_WordEnableDataWrite from hal_opsdrivers/staging/r8188eu/core/rtw_efuse.c drivers/staging/r8188eu/hal/rtl8188e_hal_init.c drivers/staging/r8188eu/include/hal_intf.h +1 more+3 -210 replies
31/40staging: r8188eu: remove useless assignmentdrivers/staging/r8188eu/hal/rtl8188e_hal_init.c+1 -20 replies
32/40staging: r8188eu: remove AntDivBeforeLinkHandler from hal_opsdrivers/staging/r8188eu/core/rtw_mlme_ext.c drivers/staging/r8188eu/hal/hal_intf.c drivers/staging/r8188eu/hal/rtl8188e_hal_init.c +1 more+1 -110 replies
33/40staging: r8188eu: remove AntDivCompareHandler from hal_opsdrivers/staging/r8188eu/core/rtw_mlme.c drivers/staging/r8188eu/hal/hal_intf.c drivers/staging/r8188eu/hal/rtl8188e_hal_init.c +1 more+2 -180 replies
34/40staging: r8188eu: remove empty function rtl8188e_start_thread()drivers/staging/r8188eu/hal/hal_intf.c drivers/staging/r8188eu/hal/rtl8188e_hal_init.c drivers/staging/r8188eu/include/hal_intf.h +2 more+0 -160 replies
35/40staging: r8188eu: remove empty function rtl8188e_stop_thread()drivers/staging/r8188eu/hal/hal_intf.c drivers/staging/r8188eu/hal/rtl8188e_hal_init.c drivers/staging/r8188eu/include/hal_intf.h +2 more+0 -190 replies
36/40staging: r8188eu: remove hal_notch_filter from hal_opsdrivers/staging/r8188eu/hal/hal_intf.c drivers/staging/r8188eu/hal/rtl8188e_hal_init.c drivers/staging/r8188eu/include/hal_intf.h+4 -140 replies
37/40staging: r8188eu: remove free_hal_data from hal_opsdrivers/staging/r8188eu/hal/hal_intf.c drivers/staging/r8188eu/hal/rtl8188e_hal_init.c drivers/staging/r8188eu/include/hal_intf.h +1 more+3 -160 replies
38/40staging: r8188eu: remove unused function rtl8188e_clone_haldata()drivers/staging/r8188eu/hal/rtl8188e_hal_init.c drivers/staging/r8188eu/include/rtl8188e_hal.h+0 -70 replies
39/40staging: r8188eu: remove SetBeaconRelatedRegistersHandler from hal_opsdrivers/staging/r8188eu/core/rtw_wlan_util.c drivers/staging/r8188eu/hal/hal_intf.c drivers/staging/r8188eu/hal/usb_halinit.c +1 more+4 -120 replies
40/40staging: r8188eu: remove UpdateHalRAMask8188EUsb from hal_opsdrivers/staging/r8188eu/hal/hal_intf.c drivers/staging/r8188eu/hal/usb_halinit.c drivers/staging/r8188eu/include/hal_intf.h+3 -90 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 00/40] staging: r8188eu: remove function pointers from struct hal_ops

In order to get rid of the HAL layer this series removes the next bunch of function pointers from struct hal_ops.

Also it removes some empty functions and cleans up some minor style issues I stumbled upon.

Tested on x86_64 with Inter-Tech DMG-02.

v1 -> v2
Fixed typos in commit messages.

v2 -> v3
Added this missing patchset version changelog.

Michael Straube (40):
staging: r8188eu: remove InitSwLeds from hal_ops
staging: r8188eu: remove DeInitSwLeds from hal_ops
staging: r8188eu: remove dm_init from hal_ops
staging: r8188eu: remove dm_deinit from hal_ops
staging: r8188eu: remove SetHalODMVarHandler from hal_ops
staging: r8188eu: remove empty functions
staging: r8188eu: remove unused function rtw_interface_ps_func()
staging: r8188eu: remove interface_ps_func from hal_ops
staging: r8188eu: remove hal_dm_watchdog from hal_ops
staging: r8188eu: remove set_bwmode_handler from hal_ops
staging: r8188eu: remove set_channel_handler from hal_ops
staging: r8188eu: remove unused enum hal_intf_ps_func
staging: r8188eu: remove Add_RateATid from hal_ops
staging: r8188eu: remove hal_power_on from hal_ops
staging: r8188eu: remove sreset_init_value from hal_ops
staging: r8188eu: remove sreset_reset_value from hal_ops
staging: r8188eu: remove silentreset from hal_ops
staging: r8188eu: remove sreset_xmit_status_check from hal_ops
staging: r8188eu: remove sreset_linked_status_check from hal_ops
staging: r8188eu: remove sreset_get_wifi_status from hal_ops
staging: r8188eu: remove EfusePowerSwitch from hal_ops
staging: r8188eu: rename hal_EfusePowerSwitch_RTL8188E()
staging: r8188eu: remove wrapper Efuse_PowerSwitch()
staging: r8188eu: remove ReadEFuse from hal_ops
staging: r8188eu: remove EFUSEGetEfuseDefinition from hal_ops
staging: r8188eu: remove EfuseGetCurrentSize from hal_ops
staging: r8188eu: remove empty comments
staging: r8188eu: remove Efuse_PgPacketRead from hal_ops
staging: r8188eu: remove Efuse_PgPacketWrite from hal_ops
staging: r8188eu: remove Efuse_WordEnableDataWrite from hal_ops
staging: r8188eu: remove useless assignment
staging: r8188eu: remove AntDivBeforeLinkHandler from hal_ops
staging: r8188eu: remove AntDivCompareHandler from hal_ops
staging: r8188eu: remove empty function rtl8188e_start_thread()
staging: r8188eu: remove empty function rtl8188e_stop_thread()
staging: r8188eu: remove hal_notch_filter from hal_ops
staging: r8188eu: remove free_hal_data from hal_ops
staging: r8188eu: remove unused function rtl8188e_clone_haldata()
staging: r8188eu: remove SetBeaconRelatedRegistersHandler from hal_ops
staging: r8188eu: remove UpdateHalRAMask8188EUsb from hal_ops

 drivers/staging/r8188eu/core/rtw_ap.c         |   9 +-
 drivers/staging/r8188eu/core/rtw_cmd.c        |   6 +-
 drivers/staging/r8188eu/core/rtw_efuse.c      | 182 ++++--------------
 drivers/staging/r8188eu/core/rtw_mlme.c       |   7 +-
 drivers/staging/r8188eu/core/rtw_mlme_ext.c   |   5 +-
 drivers/staging/r8188eu/core/rtw_mp_ioctl.c   |  18 +-
 drivers/staging/r8188eu/core/rtw_p2p.c        |   4 +-
 drivers/staging/r8188eu/core/rtw_pwrctrl.c    |   8 -
 drivers/staging/r8188eu/core/rtw_sta_mgt.c    |   2 +-
 drivers/staging/r8188eu/core/rtw_wlan_util.c  |   8 +-
 drivers/staging/r8188eu/hal/hal_intf.c        | 170 +---------------
 .../staging/r8188eu/hal/rtl8188e_hal_init.c   | 123 +++---------
 drivers/staging/r8188eu/hal/usb_halinit.c     |  36 +---
 drivers/staging/r8188eu/include/hal_intf.h    | 123 ++----------
 .../staging/r8188eu/include/rtl8188e_hal.h    |   5 -
 drivers/staging/r8188eu/include/rtw_efuse.h   |   9 -
 drivers/staging/r8188eu/include/rtw_pwrctrl.h |   2 -
 drivers/staging/r8188eu/os_dep/ioctl_linux.c  |  31 +--
 drivers/staging/r8188eu/os_dep/os_intfs.c     |  21 +-
 19 files changed, 142 insertions(+), 627 deletions(-)
Signature · 1 line
2.33.0