i915: Prepare for Xe_HP compute engines
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest13 patches 7 repliesIn review
- v213 patches 6 repliesSuperseded
- v18 patches 12 repliesSuperseded
Changes in v3 from the cover letter
- Flip order of RCU_MODE patch and GuC's ADS update to enable compute engines. (Daniele)
- Replace fls(CCS_MASK) condition on fusing check with a simple IP version test to omit pre-Xe_HP platforms.
- Fix a handful of checkpatch warnings.
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/13 | drm/i915/xehp: Define compute class and enginedrivers/ drivers/ drivers/ +3 more | +71 | 0 replies | |
| 2/13 | drm/i915/xehp: CCS shares the render reset domaindrivers/ | +4 | 0 replies | |
| 3/13 | drm/i915/xehp: Add Compute CS IRQ handlersdrivers/ drivers/ drivers/ | +19 | 0 replies | |
| 4/13 | drm/i915/xehp: compute engine pipe_controldrivers/ drivers/ | +40 | 0 replies | |
| 5/13 | drm/i915/xehp: CCS should use RCS setup functionsdrivers/ drivers/ drivers/ +3 more | +16 | 0 replies | |
| 6/13 | drm/i915: Move context descriptor fields to intel_lrc.hdrivers/ drivers/ drivers/ | +35 | 0 replies | |
| 7/13 | drm/i915/xehp: Define context scheduling attributes in lrc descriptordrivers/ drivers/ drivers/ +1 more | +26 | 0 replies | |
| 8/13 | drm/i915/xehp: Enable ccs/dual-ctx in RCU_MODEdrivers/ drivers/ drivers/ +3 more | +58 | 3 replies | |
| 9/13 | drm/i915/xehp/guc: enable compute engine inside GuCdrivers/ | +1 | 2 replies | |
| 10/13 | drm/i915/xehp: Don't support parallel submission on compute / renderdrivers/ drivers/ | +14 | 0 replies | |
| 11/13 | drm/i915/xehp: handle fused off CCS enginesdrivers/ drivers/ drivers/ | +42 | 2 replies | |
| 12/13 | drm/i915/xehp: Add compute workaroundsdrivers/ drivers/ drivers/ | +56 | 0 replies | |
| 13/13 | drm/i915/xehpsdv: Move render/compute engine reset domains related workaroundsdrivers/ | +13 | 1 reply |
Reviews trailers per patch
All 13 patches have a Reviewed-by or Acked-by.
| Patch | Tvrtko Ursulin | Lucas De Marchi | Daniele Ceraolo Spurio | Matt Roper | Umesh Nerlige Ramappa |
|---|---|---|---|---|---|
| 1/13 | R-b | ||||
| 2/13 | R-b | ||||
| 3/13 | R-b | ||||
| 4/13 | R-b | ||||
| 5/13 | R-b | ||||
| 6/13 | R-b | ||||
| 7/13 | R-b | ||||
| 8/13 | R-b R-b | ||||
| 9/13 | R-b | R-b | |||
| 10/13 | R-b | ||||
| 11/13 | R-b | ||||
| 12/13 | R-b | ||||
| 13/13 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.
Cover letter [PATCH v3 00/13] i915: Prepare for Xe_HP compute engines
The Xe_HP architecture introduces compute engines as a new engine class. These compute command streamers (CCS) are similar to the render engine, except that they're intended for GPGPU usage and lack support for the 3D pipeline.
For now we're just sending some initial "under the hood" preparation for CCS engines without actually exposing them to userspace or adding them to any platform's engine list yet. There may be a bit more GuC-related updates necessary before it's safe to expose them, so the actual uabi bits will come later once that's all worked out.
v2:
- General rebase of patches from September.
- Drop ABI bits for now; we'll make it visible to userspace later once all the GuC work is hammered out.
v3:
- Flip order of RCU_MODE patch and GuC's ADS update to enable compute engines. (Daniele)
- Replace fls(CCS_MASK) condition on fusing check with a simple IP version test to omit pre-Xe_HP platforms.
- Fix a handful of checkpatch warnings.
Daniele Ceraolo Spurio (3):
drm/i915/xehp: compute engine pipe_control drm/i915/xehp/guc: enable compute engine inside GuC drm/i915/xehp: handle fused off CCS engines
Matt Roper (8):
drm/i915/xehp: Define compute class and engine drm/i915/xehp: CCS shares the render reset domain drm/i915/xehp: Add Compute CS IRQ handlers
drm/i915/xehp: CCS should use RCS setup functions drm/i915: Move context descriptor fields to intel_lrc.h drm/i915/xehp: Define context scheduling attributes in lrc descriptor drm/i915/xehp: Enable ccs/dual-ctx in RCU_MODE drm/i915/xehp: Add compute workarounds
Matthew Brost (1):
drm/i915/xehp: Don't support parallel submission on compute / render
Srinivasan Shanmugam (1):
drm/i915/xehpsdv: Move render/compute engine reset domains related
workarounds
drivers/gpu/drm/i915/gem/i915_gem_context.c | 10 +++ .../drm/i915/gem/selftests/i915_gem_context.c | 8 +- drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 34 ++++++-- drivers/gpu/drm/i915/gt/intel_engine.h | 2 + drivers/gpu/drm/i915/gt/intel_engine_cs.c | 83 +++++++++++++++++++ drivers/gpu/drm/i915/gt/intel_engine_types.h | 11 ++- drivers/gpu/drm/i915/gt/intel_engine_user.c | 5 +- .../drm/i915/gt/intel_execlists_submission.c | 24 +++++- drivers/gpu/drm/i915/gt/intel_gpu_commands.h | 15 ++++ drivers/gpu/drm/i915/gt/intel_gt_irq.c | 15 +++- drivers/gpu/drm/i915/gt/intel_gt_regs.h | 45 +++------- drivers/gpu/drm/i915/gt/intel_lrc.c | 12 ++- drivers/gpu/drm/i915/gt/intel_lrc.h | 51 ++++++++++++ drivers/gpu/drm/i915/gt/intel_sseu.c | 17 +++- drivers/gpu/drm/i915/gt/intel_sseu.h | 4 +- drivers/gpu/drm/i915/gt/intel_workarounds.c | 73 +++++++++++++--- drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c | 5 ++ drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h | 32 +++++-- .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 18 +++- .../drm/i915/gt/uc/selftest_guc_multi_lrc.c | 4 + drivers/gpu/drm/i915/i915_drv.h | 2 + drivers/gpu/drm/i915/i915_reg.h | 4 + 22 files changed, 394 insertions(+), 80 deletions(-)
Signature · 1 line
2.34.1