Skip to content

x86: Fix duplicate symbols w/ clang

Sean Christopherson kvm 1 version Applied

Status from this message: Queued, thanks.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v3 Latest7 patches 8 repliesApplied

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/7lib: Drop x86/processor.h's barrier() in favor of compiler.h versionlib/libcflat.h lib/x86/processor.h+1 -51 reply
2/7lib: define the "noinline" macrolib/linux/compiler.h x86/pmu_lbr.c+3 -21 reply
3/7lib: Move __unused attribute macro to compiler.hlib/libcflat.h lib/linux/compiler.h+1 -21 reply
4/7x86: realmode: mark exec_in_big_real_mode as noinlinex86/realmode.c+3 -11 reply
5/7x86: svm: mark test_run as noinlinex86/svm.c+1 -11 reply
6/7x86: umip: mark do_ring3 as noinlinex86/umip.c+1 -11 reply
7/7x86: vmx: mark some test_* functions as noinlinex86/vmx.c+3 -31 reply

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchJim Mattson
1/7R-b
2/7R-b
3/7R-b
4/7R-b
5/7R-b
6/7R-b
7/7R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [kvm-unit-tests PATCH v3 0/7] x86: Fix duplicate symbols w/ clang

Add a "noinline" macro to mirror the kernel's wrapping of the attribute and to save typing, and use it to fix a variety of duplicate symbol errors that pop up with some versions of clang due to clang aggressively inlining functions that define globally visible labels in inline asm blobs.

Bill Wendling (5):
lib: define the "noinline" macro
x86: realmode: mark exec_in_big_real_mode as noinline
x86: svm: mark test_run as noinline
x86: umip: mark do_ring3 as noinline
x86: vmx: mark some test_* functions as noinline

Sean Christopherson (2):
lib: Drop x86/processor.h's barrier() in favor of compiler.h version
lib: Move __unused attribute macro to compiler.h

 lib/libcflat.h       | 3 +--
 lib/linux/compiler.h | 2 ++
 lib/x86/processor.h  | 5 -----
 x86/pmu_lbr.c        | 4 ++--
 x86/realmode.c       | 4 +++-
 x86/svm.c            | 2 +-
 x86/umip.c           | 2 +-
 x86/vmx.c            | 6 +++---
 8 files changed, 13 insertions(+), 15 deletions(-)
Signature · 1 line
2.33.0.309.g3052b89438-goog