Skip to content

NFS: Clean up nfs4_label allocation

[email protected] linux-nfs llvm oe-kbuild-all 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest14 patches 0 repliesNew
  2. v114 patches 0 repliesSuperseded

Changes in v2 from the cover letter

- Rebased on v5.15-rc6

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14NFS: Create a new nfs_alloc_fattr_with_label() functionfs/nfs/getroot.c fs/nfs/inode.c fs/nfs/internal.h +1 more+36 -200 replies
2/14NFS: Remove the nfs4_label from the nfs_entry structfs/nfs/dir.c fs/nfs/nfs4xdr.c include/linux/nfs_xdr.h+8 -160 replies
3/14NFS: Remove the nfs4_label from the nfs4_create_res structfs/nfs/nfs4proc.c fs/nfs/nfs4xdr.c include/linux/nfs_xdr.h+6 -90 replies
4/14NFS: Remove the nfs4_label from the nfs4_link_res structfs/nfs/nfs4proc.c fs/nfs/nfs4xdr.c include/linux/nfs_xdr.h+4 -150 replies
5/14NFS: Remove the label from the nfs4_lookup_res structfs/nfs/dir.c fs/nfs/namespace.c fs/nfs/nfs3proc.c +4 more+25 -420 replies
6/14NFS: Remove the nfs4_label from the nfs4_lookupp_res structfs/nfs/export.c fs/nfs/nfs3proc.c fs/nfs/nfs4proc.c +2 more+14 -290 replies
7/14NFS: Remove the f_label from the nfs4_opendata and nfs_openresfs/nfs/nfs4_fs.h fs/nfs/nfs4proc.c fs/nfs/nfs4xdr.c +1 more+12 -270 replies
8/14NFS: Remove the nfs4_label from the nfs4_getattr_resfs/nfs/client.c fs/nfs/dir.c fs/nfs/export.c +8 more+28 -560 replies
9/14NFS: Remove the nfs4_label from the nfs_setattrresfs/nfs/inode.c fs/nfs/nfs4proc.c fs/nfs/nfs4xdr.c +1 more+18 -430 replies
10/14NFS: Remove the nfs4_label argument from nfs_instantiate()fs/nfs/dir.c fs/nfs/nfs4proc.c fs/nfs/proc.c +1 more+8 -90 replies
11/14NFS: Remove the nfs4_label argument from nfs_add_or_obtain()fs/nfs/dir.c fs/nfs/nfs3proc.c include/linux/nfs_fs.h+5 -70 replies
12/14NFS: Remove the nfs4_label argument from nfs_fhget()fs/nfs/dir.c fs/nfs/export.c fs/nfs/getroot.c +4 more+11 -120 replies
13/14NFS: Remove the nfs4_label argument from nfs_setsecurityfs/nfs/dir.c fs/nfs/getroot.c fs/nfs/inode.c +2 more+17 -220 replies
14/14NFS: Remove the nfs4_label argument from decode_getattr_*() functionsfs/nfs/nfs4xdr.c+17 -260 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 00/14] NFS: Clean up nfs4_label allocation

From: Anna Schumaker <[email protected]>

In the functions where we want a label we also tend to allocate a struct fattr, which happens to have a field for labels that goes unused in most cases. Let's just allocate the label at the same time as the fattr if we know we'll want one. This lets us pass fattrs around by themselves, and also remove the struct nfs4_label argument from functions like nfs3_proc_getattr().

Changes in v2:
- Rebased on v5.15-rc6

Thoughts?
Anna

Anna Schumaker (14):
NFS: Create a new nfs_alloc_fattr_with_label() function
NFS: Remove the nfs4_label from the nfs_entry struct
NFS: Remove the nfs4_label from the nfs4_create_res struct
NFS: Remove the nfs4_label from the nfs4_link_res struct
NFS: Remove the label from the nfs4_lookup_res struct
NFS: Remove the nfs4_label from the nfs4_lookupp_res struct
NFS: Remove the f_label from the nfs4_opendata and nfs_openres
NFS: Remove the nfs4_label from the nfs4_getattr_res
NFS: Remove the nfs4_label from the nfs_setattrres
NFS: Remove the nfs4_label argument from nfs_instantiate()
NFS: Remove the nfs4_label argument from nfs_add_or_obtain()
NFS: Remove the nfs4_label argument from nfs_fhget()
NFS: Remove the nfs4_label argument from nfs_setsecurity
NFS: Remove the nfs4_label argument from decode_getattr_*() functions

 fs/nfs/client.c         |   2 +-
 fs/nfs/dir.c            |  66 ++++++----------
 fs/nfs/export.c         |  44 +++--------
 fs/nfs/getroot.c        |  21 ++---
 fs/nfs/inode.c          |  59 +++++++-------
 fs/nfs/internal.h       |   9 ---
 fs/nfs/namespace.c      |   3 +-
 fs/nfs/nfs3proc.c       |  10 +--
 fs/nfs/nfs4_fs.h        |   4 +-
 fs/nfs/nfs4file.c       |   5 +-
 fs/nfs/nfs4proc.c       | 165 +++++++++++++---------------------------
 fs/nfs/nfs4xdr.c        |  43 +++++------
 fs/nfs/proc.c           |  14 ++--
 include/linux/nfs_fs.h  |  23 ++++--
 include/linux/nfs_xdr.h |  16 +---
 15 files changed, 180 insertions(+), 304 deletions(-)
Signature · 1 line
2.33.1