Skip to content

integrity: support including firmware ".platform" keys at build time

Nayna Jain keyrings linux-integrity linux-security-module lkml 12 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v12 Latest4 patches 3 repliesIn review
  2. v114 patches 9 repliesSuperseded
  3. v103 patches 4 repliesSuperseded
Earlier versions · 9
VersionPostedPatchesRepliesStatus
v93 patches5 repliesApplied
v83 patches4 repliesSuperseded
v73 patches7 repliesSuperseded
v63 patches2 repliesSuperseded
v52 patches3 repliesSuperseded
v42 patches1 replySuperseded
v31 patch4 repliesSuperseded
v21 patch2 repliesSuperseded
v11 patch1 replySuperseded

Changes in v12 from the cover letter

* Replace Patch 3/4 with reverting of the commit as suggested by Masahiro Yamada.

Patches in v12 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4certs: export load_certificate_list() to be used outside certs/certs/Makefile certs/blacklist.c certs/common.c +3 more+10 -141 reply
2/4integrity: make integrity_keyring_from_id() non-staticsecurity/integrity/digsig.c security/integrity/integrity.h+7 -10 replies
3/4Revert "certs: move scripts/extract-cert to certs/"MAINTAINERS certs/.gitignore certs/Makefile +4 more+16 -151 reply
4/4integrity: support including firmware ".platform" keys at build timescripts/Makefile security/integrity/Kconfig security/integrity/Makefile +3 more+74 -10 replies

Reviews trailers per patch

3 of 4 patches have a Reviewed-by or Acked-by.

PatchMimi ZoharNageswara R Sastry
SeriesT-b
1/4R-b
2/4R-b
3/4
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v12 thread

Cover letter [PATCH v12 0/4] integrity: support including firmware ".platform" keys at build time

Some firmware support secure boot by embedding static keys to verify the Linux kernel during boot. However, these firmware do not expose an interface for the kernel to load firmware keys onto the ".platform" keyring, preventing the kernel from verifying the kexec kernel image signature.

This patchset exports load_certificate_list() and defines a new function load_builtin_platform_cert() to load compiled in certificates onto the ".platform" keyring.

Changelog:
v12:
* Replace Patch 3/4 with reverting of the commit as suggested by Masahiro Yamada.

v11:
* Added a new patch to conditionally build extract-cert if PLATFORM_KEYRING is enabled.

v10:
* Fixed the externs warning for Patch 3.

v9:
* Rebased on Jarkko's repo -
git://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git

v8:
* Includes Jarkko's feedback on patch description and removed Reported-by for Patch 1.

v7:
* Incldues Jarkko's feedback on patch description for Patch 1 and 3.

v6:
* Includes Jarkko's feedback:
* Split Patch 2 into two.
* Update Patch description.

v5:
* Renamed load_builtin_platform_cert() to load_platform_certificate_list() and config INTEGRITY_PLATFORM_BUILTIN_KEYS to INTEGRITY_PLATFORM_KEYS, as suggested by Mimi Zohar.

v4:
* Split into two patches as per Mimi Zohar and Dimitri John Ledkov recommendation.

v3:
* Included Jarkko's feedback
** updated patch description to include approach.
** removed extern for function declaration in the .h file.
* Included load_certificate_list() within #ifdef CONFIG_KEYS condition.

v2:
* Fixed the error reported by kernel test robot
* Updated patch description based on Jarkko's feedback.

Nayna Jain (4):
certs: export load_certificate_list() to be used outside certs/
integrity: make integrity_keyring_from_id() non-static Revert "certs: move scripts/extract-cert to certs/"
integrity: support including firmware ".platform" keys at build time

 MAINTAINERS                                   |  1 +
 certs/.gitignore                              |  1 -
 certs/Makefile                                | 18 ++++++---------
 certs/blacklist.c                             |  1 -
 certs/common.c                                |  2 +-
 certs/common.h                                |  9 --------
 certs/system_keyring.c                        |  1 -
 include/keys/system_keyring.h                 |  6 +++++
 scripts/.gitignore                            |  1 +
 scripts/Makefile                              | 12 ++++++++--
 {certs => scripts}/extract-cert.c             |  2 +-
 scripts/remove-stale-files                    |  2 --
 security/integrity/Kconfig                    | 10 ++++++++
 security/integrity/Makefile                   | 15 +++++++++++-
 security/integrity/digsig.c                   |  2 +-
 security/integrity/integrity.h                |  9 ++++++++
 .../integrity/platform_certs/platform_cert.S  | 23 +++++++++++++++++++
 .../platform_certs/platform_keyring.c         | 23 +++++++++++++++++++
 18 files changed, 107 insertions(+), 31 deletions(-)
 delete mode 100644 certs/common.h
 rename {certs => scripts}/extract-cert.c (98%)
 create mode 100644 security/integrity/platform_certs/platform_cert.S

base-commit: fb5abce6b2bb5cb3d628aaa63fa821da8c4600f9

Signature · 1 line
2.34.1