Skip to content

occ: fsi and hwmon: Extract and provide the SBEFIFO FFDC

Eddie James linux-hwmon lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest4 patches 3 repliesIn review
  2. v34 patches 5 repliesSuperseded
  3. v23 patches 0 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v13 patches7 repliesSuperseded

Changes in v4 from the cover letter

- Rebase
- Add a check for valid FFDC length
- Add comments about SBE words being four bytes

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4fsi: occ: Use a large buffer for responsesdrivers/fsi/fsi-occ.c include/linux/fsi-occ.h+46 -660 replies
2/4fsi: occ: Store the SBEFIFO FFDC in the user response bufferdrivers/fsi/fsi-occ.c+48 -180 replies
3/4docs: ABI: testing: Document the OCC hwmon FFDC binary interfaceDocumentation/ABI/testing/sysfs-bus-platform-devices-occ-hwmon+13 -00 replies
4/4hwmon: (occ) Provide the SBEFIFO FFDC in binary sysfsdrivers/hwmon/occ/p9_sbe.c+85 -12 replies

Reviews trailers per patch

1 of 4 patches has a Reviewed-by or Acked-by.

PatchGuenter Roeck
1/4
2/4
3/4
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/4] occ: fsi and hwmon: Extract and provide the SBEFIFO FFDC

Currently, users have no way to obtain the FFDC (First Failure Data Capture) provided by the SBEFIFO when an operation fails. To remedy this, add code in the FSI OCC driver to store this FFDC in the user's response buffer and set the response length accordingly.
On the hwmon side, there is a need at the application level to perform side-band operations in response to SBE errors. Therefore, add a new binary sysfs file that provides the FFDC (or lack thereof) when there is an SBEFIFO error. Now applications can take action when an SBE error is detected.

Changes since v3:
- Rebase
- Add a check for valid FFDC length
- Add comments about SBE words being four bytes

Changes since v2:
- Add documentation

Changes since v1:
- Remove the magic value that indicated an SBE/SBEFIFO error with no FFDC.
- Remove binary sysfs state management and intead just clear the error flag when the whole FFDC has been read.

Eddie James (4):
fsi: occ: Use a large buffer for responses
fsi: occ: Store the SBEFIFO FFDC in the user response buffer
docs: ABI: testing: Document the OCC hwmon FFDC binary interface
hwmon: (occ) Provide the SBEFIFO FFDC in binary sysfs

 .../sysfs-bus-platform-devices-occ-hwmon      |  13 ++
 drivers/fsi/fsi-occ.c                         | 164 +++++++++---------
 drivers/hwmon/occ/p9_sbe.c                    |  86 ++++++++-
 include/linux/fsi-occ.h                       |   2 +
 4 files changed, 186 insertions(+), 79 deletions(-)
 create mode 100644 Documentation/ABI/testing/sysfs-bus-platform-devices-occ-hwmon
Signature · 1 line
2.27.0