Skip to content

KVM: selftests: Small fixes for dirty_log_perf_test

David Matlack kvm 2 versions – Applied

Status from this message: Queued these now, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 2 repliesApplied
  2. v13 patches 10 repliesSuperseded

Changes in v2 from the cover letter

- Add Ben and Andrew's SOB to patches 1 and 2
- Delete stray newline in patch 2 [Andrew]
- Make print_available_backing_src_types static [Andrew]
- Create a separate dirty bitmap per slot [Andrew, Ben]

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/3KVM: selftests: Change backing_src flag to -s in demand_paging_testtools/testing/selftests/kvm/demand_paging_test.c+5 -50 replies
2/3KVM: selftests: Refactor help message for -s backing_srctools/testing/selftests/kvm/access_tracking_perf_test.c tools/testing/selftests/kvm/demand_paging_test.c tools/testing/selftests/kvm/dirty_log_perf_test.c +3 more+25 -220 replies
3/3KVM: selftests: Create a separate dirty bitmap per slottools/testing/selftests/kvm/dirty_log_perf_test.c+39 -151 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchBen GardonAndrew Jones
1/3R-b R-b
2/3R-b R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] KVM: selftests: Small fixes for dirty_log_perf_test

This series fixes 2 bugs in dirty_log_perf_test:
- Incorrect interleaving of help messages for -s and -x (patch 2)
- Buffer overflow when using multiple slots (patch 3)

Both bugs were introduced by commit 609e6202ea5f ("KVM: selftests:
Support multiple slots in dirty_log_perf_test").

Patch 1 is a small tangentially related cleanup to use a consistent flag for the backing source across all selftests.

v2:
- Add Ben and Andrew's SOB to patches 1 and 2
- Delete stray newline in patch 2 [Andrew]
- Make print_available_backing_src_types static [Andrew]
- Create a separate dirty bitmap per slot [Andrew, Ben]

v1: https://lore.kernel.org/kvm/[email protected]/

David Matlack (3):
KVM: selftests: Change backing_src flag to -s in demand_paging_test
KVM: selftests: Refactor help message for -s backing_src
KVM: selftests: Create a separate dirty bitmap per slot

 .../selftests/kvm/access_tracking_perf_test.c |  6 +-
 .../selftests/kvm/demand_paging_test.c        | 13 ++--
 .../selftests/kvm/dirty_log_perf_test.c       | 63 +++++++++++++------
 .../testing/selftests/kvm/include/test_util.h |  4 +-
 .../selftests/kvm/kvm_page_table_test.c       |  7 +--
 tools/testing/selftests/kvm/lib/test_util.c   | 17 +++--
 6 files changed, 69 insertions(+), 41 deletions(-)
Signature · 1 line
2.33.0.464.g1972c5931b-goog