Skip to content

KVM: x86: Convey the exit reason, etc. to user-space on emulation failure

David Edmondson kvm lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v5 Latest4 patches 4 repliesIn review

Changes in v5 from the cover letter

- Add some Reviewed-by (Sean).
- Build-time complaint about sizing rather than run-time calculation (Sean).
- Clarify that the format of the auxiliary debug data is undefined (Sean).
- ndata_start -> info_start (Sean).
- sizeof(variable) rather than sizeof(type) (Sean).

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4KVM: x86: Clarify the kvm_run.emulation_failure structure layoutinclude/uapi/linux/kvm.h+6 -22 replies
2/4KVM: x86: Get exit_reason as part of kvm_x86_ops.get_exit_infoarch/x86/include/asm/kvm_host.h arch/x86/kvm/svm/svm.c arch/x86/kvm/trace.h +2 more+19 -131 reply
3/4KVM: x86: On emulation failure, convey the exit reason, etc. to userspacearch/x86/include/asm/kvm_host.h arch/x86/kvm/vmx/vmx.c arch/x86/kvm/x86.c +1 more+69 -181 reply
4/4KVM: x86: SGX must obey the KVM_INTERNAL_ERROR_EMULATION protocolarch/x86/kvm/vmx/sgx.c+5 -110 replies

Reviews trailers per patch

3 of 4 patches have a Reviewed-by or Acked-by.

PatchSean Christopherson
1/4
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/4] KVM: x86: Convey the exit reason, etc. to user-space on emulation failure

To help when debugging failures in the field, if instruction emulation fails, report the VM exit reason, etc. to userspace in order that it can be recorded.

The SGX changes here are compiled but untested.

v5:
- Add some Reviewed-by (Sean).
- Build-time complaint about sizing rather than run-time calculation (Sean).
- Clarify that the format of the auxiliary debug data is undefined (Sean).
- ndata_start -> info_start (Sean).
- sizeof(variable) rather than sizeof(type) (Sean).

v4:
- Update the API for preparing emulation failure report (Sean)
- sgx uses the provided API in all relevant cases (Sean)
- Clarify the intended layout of kvm_run.emulation_failure.

v3:
- Convey any debug data un-flagged after the ABI specified data in struct emulation_failure (Sean)
- Obey the ABI protocol in sgx_handle_emulation_failure() (Sean)

v2:
- Improve patch comments (dmatlock)
- Intel should provide the full exit reason (dmatlock)
- Pass a boolean rather than flags (dmatlock)
- Use the helper in kvm_task_switch() and kvm_handle_memory_failure() (dmatlock)
- Describe the exit_reason field of the emulation_failure structure (dmatlock)

David Edmondson (4):
KVM: x86: Clarify the kvm_run.emulation_failure structure layout
KVM: x86: Get exit_reason as part of kvm_x86_ops.get_exit_info
KVM: x86: On emulation failure, convey the exit reason, etc. to
userspace
KVM: x86: SGX must obey the KVM_INTERNAL_ERROR_EMULATION protocol

 arch/x86/include/asm/kvm_host.h | 10 +++--
 arch/x86/kvm/svm/svm.c          |  8 ++--
 arch/x86/kvm/trace.h            |  9 ++--
 arch/x86/kvm/vmx/nested.c       |  2 +-
 arch/x86/kvm/vmx/sgx.c          | 16 +++-----
 arch/x86/kvm/vmx/vmx.c          | 11 +++--
 arch/x86/kvm/x86.c              | 73 ++++++++++++++++++++++++++-------
 include/uapi/linux/kvm.h        | 14 ++++++-
 8 files changed, 99 insertions(+), 44 deletions(-)
Signature · 1 line
2.33.0