usb: typec: tipd: Add Apple M1 support
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest6 patches 3 repliesIn review
- v26 patches 3 repliesSuperseded
- v19 patches 21 repliesSuperseded
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | dt-bindings: usb: tps6598x: Add Apple CD321x compatibleDocumentation/ | +4 | 0 replies | |
| 2/6 | usb: typec: tipd: Split interrupt handlerdrivers/ | +65 | 1 reply | |
| 3/6 | usb: typec: tipd: Add short-circuit for no irqsdrivers/ | +6 | 0 replies | |
| 4/6 | usb: typec: tipd: Add support for Apple CD321Xdrivers/ drivers/ drivers/ | +91 | 1 reply | |
| 5/6 | usb: typec: tipd: Switch CD321X power state to S0drivers/ drivers/ | +43 | 1 reply | |
| 6/6 | usb: typec: tipd: Remove FIXME about testing with I2C_FUNC_I2Cdrivers/ | +0 | 0 replies |
Reviews trailers per patch
All 6 patches have a Reviewed-by or Acked-by.
| Patch | Alyssa Rosenzweig | Rob Herring | Heikki Krogerus |
|---|---|---|---|
| 1/6 | R-b | A-b | |
| 2/6 | R-b | ||
| 3/6 | R-b | ||
| 4/6 | R-b | ||
| 5/6 | R-b | R-b | |
| 6/6 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v3 0/6] usb: typec: tipd: Add Apple M1 support
Hi,
v1: https://lore.kernel.org/linux-usb/[email protected]/
v2: https://lore.kernel.org/linux-usb/[email protected]/
Thanks again to Heikki for your review of v2!
This series adds initial support for the Apple CD3217/3218 chip which is also known as Apple ACE1/2. These chips are used on Apple M1 machines. They are based on the TI TPS6598x chips with a few differences:
- The interrupt numbers have been changed
- The secondary i2c bus and its interrupt controller are connected to the system management controller and must not be disturbed
- The chip comes up in a low power state and must be booted using the "SPSS" (System Power State Switch maybe) command which is not documented in the TI manual
- The interrupt mask must be set up explicitly
The only difference to v2 is that now of_device_is_compatible instead of of_device_get_match_data is used to switch to the CD321x logic as suggested by Heikki.
Best,
Sven
Sven Peter (6):
dt-bindings: usb: tps6598x: Add Apple CD321x compatible
usb: typec: tipd: Split interrupt handler
usb: typec: tipd: Add short-circuit for no irqs
usb: typec: tipd: Add support for Apple CD321X
usb: typec: tipd: Switch CD321X power state to S0
usb: typec: tipd: Remove FIXME about testing with I2C_FUNC_I2C
.../devicetree/bindings/usb/ti,tps6598x.yaml | 4 + drivers/usb/typec/tipd/core.c | 206 +++++++++++++++--- drivers/usb/typec/tipd/tps6598x.h | 12 + drivers/usb/typec/tipd/trace.h | 23 ++ 4 files changed, 209 insertions(+), 36 deletions(-)
Signature · 1 line
2.25.1