Skip to content

generate BTF_KIND_TAG types from DW_TAG_LLVM_annotation dwarf tags

Yonghong Song bpf dwarves 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 2 repliesIn review
  2. v12 patches 3 repliesSuperseded

Changes in v2 from the cover letter

- handle returning error cases for btf_encoder__add_tag().

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2dwarf_loader: parse dwarf tag DW_TAG_LLVM_annotationdwarf_loader.c dwarves.h pahole.c+97 -60 replies
2/2btf_encoder: generate BTF_KIND_TAG from llvm annotationsbtf_encoder.c+62 -10 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchAndrii Nakryiko
1/2A-b
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH dwarves v2 0/2] generate BTF_KIND_TAG types from DW_TAG_LLVM_annotation dwarf tags

LLVM has implemented btf_tag attribute ([1]) which intended to provide a "string" tag for struct/union or its member, var, a func or its parameter. Such a "string" tag will be encoded in dwarf. For non-BPF target like x86_64, pahole needs to convert those dwarf btf_tag annotations to BTF so kernel can utilize these "string" tags for bpf program verification, etc.

Patch 1 enhanced dwarf_loader to encode DW_TAG_LLVM_annotation tags into internal data structure and Patch 2 will encode such information to BTF with BTF_KIND_TAGs.

[1] https://reviews.llvm.org/D106614

Changelog:
v1 -> v2:
- handle returning error cases for btf_encoder__add_tag().

Yonghong Song (2):
dwarf_loader: parse dwarf tag DW_TAG_LLVM_annotation
btf_encoder: generate BTF_KIND_TAG from llvm annotations

 btf_encoder.c  | 63 ++++++++++++++++++++++++++++++++++++-
 dwarf_loader.c | 85 ++++++++++++++++++++++++++++++++++++++++++++++----
 dwarves.h      | 10 ++++++
 pahole.c       |  8 +++++
 4 files changed, 159 insertions(+), 7 deletions(-)
Signature · 1 line
2.30.2