Re-enable ENQCMD and PASID MSR
Status from this message: The following commit has been merged into the x86/pasid branch of tip:
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest11 patches 89 repliesApplied
- v311 patches 15 repliesSuperseded
- v211 patches 14 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 8 patches | 68 replies | Superseded |
Changes in v4 from the cover letter
- Update commit message in patch #4 (Thomas).
- Update commit message in patch #5 (Thomas).
- Add "Reviewed-by: Thomas Gleixner <[email protected]>" in patch #1-#3 and patch #6-#9 (Thomas).
- Rebased to 5.17-rc3.
Patches in v4 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/11 | iommu/sva: Rename CONFIG_IOMMU_SVA_LIB to CONFIG_IOMMU_SVAdrivers/ drivers/ drivers/ +1 more | +8 | 1 reply | |
| 2/11 | mm: Change CONFIG option for mm->pasid fieldinclude/ kernel/ | +2 | 1 reply | |
| 3/11 | iommu/ioasid: Introduce a helper to check for valid PASIDsinclude/ | +9 | 1 reply | |
| 4/11 | kernel/fork: Initialize mm's PASIDinclude/ kernel/ mm/ | +16 | 1 reply | |
| 5/11 | iommu/sva: Assign a PASID to mm on PASID allocation and free it on mm exitdrivers/ drivers/ drivers/ +6 more | +38 | 83 replies | |
| 6/11 | x86/fpu: Clear PASID when copying fpstatearch/ | +7 | 0 replies | |
| 7/11 | sched: Define and initialize a flag to identify valid PASID in the taskinclude/ kernel/ | +7 | 0 replies | |
| 8/11 | x86/traps: Demand-populate PASID MSR via #GParch/ | +55 | 0 replies | |
| 9/11 | x86/cpufeatures: Re-enable ENQCMDarch/ | +5 | 0 replies | |
| 10/11 | tools/objtool: Check for use of the ENQCMD instruction in the kerneltools/ | +10 | 0 replies | |
| 11/11 | docs: x86: Change documentation for SVA (Shared Virtual Addressing)Documentation/ | +41 | 1 reply |
Reviews trailers per patch
All 11 patches have a Reviewed-by or Acked-by.
| Patch | Tony Luck | Thomas Gleixner | Ashok Raj | Josh Poimboeuf | Lu Baolu | Jacob Pan | Joerg Roedel | Zhangfei Gao | Jean-Philippe Brucker |
|---|---|---|---|---|---|---|---|---|---|
| 1/11 | R-b | R-b | R-b | ||||||
| 2/11 | R-b | R-b | R-b | ||||||
| 3/11 | R-b | R-b | R-b | ||||||
| 4/11 | R-b | R-b | |||||||
| 5/11 | R-b | R-b | R-b | R-b | A-b A-b | T-b T-b | R-b | ||
| 6/11 | R-b | R-b | |||||||
| 7/11 | R-b | R-b | |||||||
| 8/11 | R-b | R-b | |||||||
| 9/11 | R-b | R-b | |||||||
| 10/11 | R-b | A-b | |||||||
| 11/11 | R-b | A-b | Originally-by |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 9 reviewers.
Cover letter [PATCH v4 00/11] Re-enable ENQCMD and PASID MSR
Problems in the old code to manage SVM (Shared Virtual Memory) devices and the PASID (Process Address Space ID) led to that code being disabled.
Subsequent discussions resulted in a far simpler approach:
1) PASID life cycle is from first allocation by a process until that process exits.
2) All tasks begin with PASID disabled
3) The #GP fault handler tries to fix faulting ENQCMD instructions very early (thus avoiding complexities of the XSAVE infrastructure)
Change Log:
v4:
- Update commit message in patch #4 (Thomas).
- Update commit message in patch #5 (Thomas).
- Add "Reviewed-by: Thomas Gleixner <[email protected]>" in patch #1-#3 and patch #6-#9 (Thomas).
- Rebased to 5.17-rc3.
v3 can be found at https://lore.kernel.org/lkml/[email protected]/T/#m039e1a201e9894d99b117fa6005bc05724a5a4bb
v3:
- Rename mm_pasid_get() to mm_pasid_set() in patch #5 (Thomas).
- Remove ioasid_get() because it's not used any more when the IOASID is freed on mm exit in patch #5 (Thomas).
- Remove PASID's refcount exercise in ioasid_put() and rename ioasid_put() to ioasid_free() in patch #5 and #11 (Thomas).
- Add Acked-by: Josh Poimboeuf <[email protected]> in patch #10.
v2 can be found at https://lore.kernel.org/lkml/[email protected]/
v2:
- Free PASID on mm exit instead of in exit(2) or unbind() (Thomas, AndyL, PeterZ)
- Directly write IA32_PASID MSR in fixup while local IRQ is still disabled (Thomas)
- Simplify handling ENQCMD in objtool (PeterZ and Josh)
- Define mm_pasid_get(), mm_pasid_drop(), and mm_pasid_init() in mm and call the functions from IOMMU (Dave Hansen).
- A few changes in the #GP fixup function (Dave Hansen, Tony Luck).
- Initial PASID value is changed to INVALID_PASID (Ashok Raj and Jacob Pan).
- Add mm_pasid_init(), mm_pasid_get(), and mm_pasid_drop() functions in mm. So the mm's PASID operations are generic for both X86 and ARM (Dave Hansen).
- Rename CONFIG_IOMMU_SVA_LIB to more useful and accurate CONFIG_IOMMU_SVA
- Use CONFIG_IOMMU_SVA for PASID processing condition (Jacob)
- The patch that cleans up old update_pasid() function is in upstream now (commit: 00ecd5401349 "iommu/vt-d: Clean up unused PASID updating functions") and therefore it's removed from this version.
v1 can be found at https://lore.kernel.org/lkml/[email protected]/T/#md6d542091da1d1159eda0a44a16e57d0c0dfb209
Fenghua Yu (10):
iommu/sva: Rename CONFIG_IOMMU_SVA_LIB to CONFIG_IOMMU_SVA
mm: Change CONFIG option for mm->pasid field
iommu/ioasid: Introduce a helper to check for valid PASIDs kernel/fork: Initialize mm's PASID
iommu/sva: Assign a PASID to mm on PASID allocation and free it on mm
exit
x86/fpu: Clear PASID when copying fpstate
x86/traps: Demand-populate PASID MSR via #GP x86/cpufeatures: Re-enable ENQCMD
tools/objtool: Check for use of the ENQCMD instruction in the kernel
docs: x86: Change documentation for SVA (Shared Virtual Addressing)
Peter Zijlstra (1):
sched: Define and initialize a flag to identify valid PASID in the
task
Documentation/x86/sva.rst | 53 ++++++++++++++---- arch/x86/include/asm/disabled-features.h | 7 ++- arch/x86/kernel/fpu/core.c | 7 +++ arch/x86/kernel/traps.c | 55 +++++++++++++++++++ drivers/iommu/Kconfig | 6 +- drivers/iommu/Makefile | 2 +- .../iommu/arm/arm-smmu-v3/arm-smmu-v3-sva.c | 5 +- drivers/iommu/intel/Kconfig | 2 +- drivers/iommu/intel/iommu.c | 4 +- drivers/iommu/intel/svm.c | 9 --- drivers/iommu/ioasid.c | 39 ++----------- drivers/iommu/iommu-sva-lib.c | 39 ++++--------- drivers/iommu/iommu-sva-lib.h | 7 +-- include/linux/ioasid.h | 21 +++---- include/linux/mm_types.h | 2 +- include/linux/sched.h | 3 + include/linux/sched/mm.h | 26 +++++++++ kernel/fork.c | 15 +++-- mm/init-mm.c | 4 ++ tools/objtool/arch/x86/decode.c | 11 +++- 20 files changed, 197 insertions(+), 120 deletions(-)
Signature · 6 lines
2.35.1 _______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommu