x86/mce: Remove indirect calls
Status from this message: The following commit has been merged into the ras/core branch of tip:
Get series with b4
b4 am [email protected]Versions newest first
Changelog from the cover letter
----------
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | x86/mce: Get rid of the mce_severity function pointerarch/ arch/ arch/ +1 more | +6 | 0 replies | |
| 2/5 | x86/mce: Get rid of machine_check_vectorarch/ arch/ arch/ +2 more | +53 | 0 replies | |
| 3/5 | x86/mce: Get rid of msr_opsarch/ arch/ arch/ | +42 | 0 replies | |
| 4/5 | x86/mce: Get rid of the ->quirk_no_way_out() indirect callarch/ arch/ | +35 | 0 replies | |
| 5/5 | x86/mce: Sort mca_config members to get rid of unnecessary paddingarch/ | +6 | 0 replies |
Reviews trailers per patch
None of the 5 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Tony Luck |
|---|---|
| Series | R-b |
| 1/5 | |
| 2/5 | |
| 3/5 | |
| 4/5 | |
| 5/5 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v1 0/5] x86/mce: Remove indirect calls
From: Borislav Petkov <[email protected]>
Hi,
here's v1 with all review comments addressed.
Changelog:
----------
v0:
this is the first part of me trying to noinstr-ify the mce mess properly. That one is dealing with making all indirect calls on the #MC exception path, direct, to avoid the compiler from adding ratpoline thunks which objtool doesn't like. And when you look at the changes, you probably would go, gee, why did we ever did indirect calls - it is even more readable with direct calls and there are practically no downsides. So let's remove former.
There's another patch ontop which does the actual noinstr annotation but that takes longer currently due to objtool changes in tip.
So for now, the first part.
As always, constructive review is welcome.
Borislav Petkov (5):
x86/mce: Get rid of the mce_severity function pointer x86/mce: Get rid of machine_check_vector
x86/mce: Get rid of msr_ops
x86/mce: Get rid of the ->quirk_no_way_out() indirect call x86/mce: Sort mca_config members to get rid of unnecessary padding
arch/x86/include/asm/mce.h | 12 -- arch/x86/kernel/cpu/mce/amd.c | 10 +- arch/x86/kernel/cpu/mce/core.c | 217 ++++++++++++----------------- arch/x86/kernel/cpu/mce/internal.h | 59 +++++--- arch/x86/kernel/cpu/mce/p5.c | 6 +- arch/x86/kernel/cpu/mce/severity.c | 11 +- arch/x86/kernel/cpu/mce/winchip.c | 6 +- 7 files changed, 141 insertions(+), 180 deletions(-)
Signature · 1 line
2.29.2