Skip to content

sock_map: fix ->poll() and update selftests

Cong Wang bpf netdev 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest4 patches 2 repliesIn review
  2. v34 patches 4 repliesSuperseded
  3. v24 patches 2 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v13 patches2 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4net: rename ->stream_memory_read to ->sock_is_readableinclude/net/sock.h include/net/tls.h net/ipv4/tcp.c +3 more+14 -110 replies
2/4skmsg: extract and reuse sk_msg_is_readable()include/linux/skmsg.h net/core/skmsg.c net/ipv4/tcp_bpf.c+16 -140 replies
3/4net: implement ->sock_is_readable() for UDP and AF_UNIXnet/ipv4/udp.c net/ipv4/udp_bpf.c net/unix/af_unix.c +1 more+10 -00 replies
4/4selftests/bpf: use recv_timeout() instead of retriestools/testing/selftests/bpf/prog_tests/sockmap_listen.c+20 -550 replies

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJohn FastabendJakub Sitnicki
SeriesA-b A-b R-b
1/4
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [Patch bpf v4 0/4] sock_map: fix ->poll() and update selftests

From: Cong Wang <[email protected]>

This patchset fixes ->poll() for sockets in sockmap and updates selftests accordingly with select(). Please check each patch for more details.

Fixes c50524ec4e3a ("Merge branch 'sockmap: add sockmap support for unix datagram socket'")
Fixes 89d69c5d0fbc ("Merge branch 'sockmap: introduce BPF_SK_SKB_VERDICT and support UDP'")

---
v4: add a comment in udp_poll()

v3: drop sk_psock_get_checked()
reuse tcp_bpf_sock_is_readable()

v2: rename and reuse ->stream_memory_read()
fix a compile error in sk_psock_get_checked()

Cong Wang (3):
net: rename ->stream_memory_read to ->sock_is_readable
skmsg: extract and reuse sk_msg_is_readable()
net: implement ->sock_is_readable() for UDP and AF_UNIX

Yucong Sun (1):
selftests/bpf: use recv_timeout() instead of retries

 include/linux/skmsg.h                         |  1 +
 include/net/sock.h                            |  8 +-
 include/net/tls.h                             |  2 +-
 net/core/skmsg.c                              | 14 ++++
 net/ipv4/tcp.c                                |  5 +-
 net/ipv4/tcp_bpf.c                            | 15 +---
 net/ipv4/udp.c                                |  3 +
 net/ipv4/udp_bpf.c                            |  1 +
 net/tls/tls_main.c                            |  4 +-
 net/tls/tls_sw.c                              |  2 +-
 net/unix/af_unix.c                            |  4 +
 net/unix/unix_bpf.c                           |  2 +
 .../selftests/bpf/prog_tests/sockmap_listen.c | 75 +++++--------------
 13 files changed, 58 insertions(+), 78 deletions(-)
Signature · 1 line
2.30.2