Skip to content

KVM: arm64: vgic: Missing checks for REDIST/CPU and ITS regions above the VM IPA size

Ricardo Koller kvm kvmarm 2 versions – Applied

Status from this message: Applied to next, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest11 patches 11 repliesApplied
  2. v310 patches 27 repliesSuperseded

Changes from the cover letter

v4: better vgic_check_iorange, drop vgic_check_ioaddr, minor changes on the
selftests patches (better comments, title).
v3: add missing checks for GICv2 and the ITS, plus tests for the fixes.
v2: adding a test for KVM_VGIC_V3_ADDR_TYPE_REDIST_REGION, and returning E2BIG
instead of EINVAL (thanks Alexandru and Eric).

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/11kvm: arm64: vgic: Introduce vgic_check_iorangearch/arm64/kvm/vgic/vgic-kvm-device.c arch/arm64/kvm/vgic/vgic.h+26 -00 replies
2/11KVM: arm64: vgic-v3: Check redist region is not above the VM IPA sizearch/arm64/kvm/vgic/vgic-mmio-v3.c arch/arm64/kvm/vgic/vgic-v3.c+8 -40 replies
3/11KVM: arm64: vgic-v2: Check cpu interface region is not above the VM IPA sizearch/arm64/kvm/vgic/vgic-kvm-device.c+5 -20 replies
4/11KVM: arm64: vgic-v3: Check ITS region is not above the VM IPA sizearch/arm64/kvm/vgic/vgic-its.c+2 -20 replies
5/11KVM: arm64: vgic: Drop vgic_check_ioaddr()arch/arm64/kvm/vgic/vgic-kvm-device.c arch/arm64/kvm/vgic/vgic.h+4 -251 reply
6/11KVM: arm64: selftests: Make vgic_init gic version agnostictools/testing/selftests/kvm/aarch64/vgic_init.c+95 -611 reply
7/11KVM: arm64: selftests: Make vgic_init/vm_gic_create version agnostictools/testing/selftests/kvm/aarch64/vgic_init.c+10 -91 reply
8/11KVM: arm64: selftests: Add some tests for GICv2 in vgic_inittools/testing/selftests/kvm/aarch64/vgic_init.c+79 -322 replies
9/11KVM: arm64: selftests: Add tests for GIC redist/cpuif partially above IPA rangetools/testing/selftests/kvm/aarch64/vgic_init.c+26 -122 replies
10/11KVM: arm64: selftests: Add test for legacy GICv3 REDIST base partially above IPA rangetools/testing/selftests/kvm/aarch64/vgic_init.c+34 -01 reply
11/11KVM: arm64: selftests: Add init ITS device testtools/testing/selftests/kvm/aarch64/vgic_init.c+42 -02 replies

Reviews trailers per patch

All 11 patches have a Reviewed-by or Acked-by.

PatchEric AugerAndrew Jones
1/11R-b
2/11R-b
3/11R-b
4/11R-b
5/11R-b
6/11R-b R-b
7/11R-b R-b
8/11R-b R-b
9/11R-b R-b
10/11R-b R-b
11/11R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 00/11] KVM: arm64: vgic: Missing checks for REDIST/CPU and ITS regions above the VM IPA size

KVM doesn't check for redist, CPU interface, and ITS regions that extend partially above the guest addressable IPA range (phys_size). This can happen when using the V[2|3]_ADDR_TYPE_CPU, ADDR_TYPE_REDIST[_REGION], or ITS_ADDR_TYPE attributes to set a new region that extends partially above phys_size (with the base below phys_size). The issue is that vcpus can potentially run into a situation where some redistributors are addressable and others are not, or just the first half of the ITS is addressable.

Patches 1-5 fixes the issue for GICv2 and GICv3 (and the ITS). Patches 6-11 add some selftests for all these fixes. While adding these tests, these add support for some extra GICv2 and ITS device tests.

Changes:
v4: better vgic_check_iorange, drop vgic_check_ioaddr, minor changes on the
selftests patches (better comments, title).
v3: add missing checks for GICv2 and the ITS, plus tests for the fixes.
v2: adding a test for KVM_VGIC_V3_ADDR_TYPE_REDIST_REGION, and returning E2BIG
instead of EINVAL (thanks Alexandru and Eric).

Ricardo Koller (11):
kvm: arm64: vgic: Introduce vgic_check_iorange
KVM: arm64: vgic-v3: Check redist region is not above the VM IPA size
KVM: arm64: vgic-v2: Check cpu interface region is not above the VM
IPA size
KVM: arm64: vgic-v3: Check ITS region is not above the VM IPA size
KVM: arm64: vgic: Drop vgic_check_ioaddr()
KVM: arm64: selftests: Make vgic_init gic version agnostic
KVM: arm64: selftests: Make vgic_init/vm_gic_create version agnostic
KVM: arm64: selftests: Add some tests for GICv2 in vgic_init
KVM: arm64: selftests: Add tests for GIC redist/cpuif partially above
IPA range
KVM: arm64: selftests: Add test for legacy GICv3 REDIST base partially
above IPA range
KVM: arm64: selftests: Add init ITS device test

 arch/arm64/kvm/vgic/vgic-its.c                |   4 +-
 arch/arm64/kvm/vgic/vgic-kvm-device.c         |  25 +-
 arch/arm64/kvm/vgic/vgic-mmio-v3.c            |   6 +-
 arch/arm64/kvm/vgic/vgic-v3.c                 |   6 +-
 arch/arm64/kvm/vgic/vgic.h                    |   5 +-
 .../testing/selftests/kvm/aarch64/vgic_init.c | 366 +++++++++++++-----
 6 files changed, 298 insertions(+), 114 deletions(-)
Signature · 1 line
2.33.0.800.g4c38ced690-goog