Skip to content

PCI: aardvark controller fixes

Marek Behún linux-pci 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest13 patches 7 repliesIn review
  2. v113 patches 33 repliesSuperseded

Changes in v2 from the cover letter

- updated commit message in patch 6 as suggested by Mark
- updated patch 6 to also drop the early return
- changed the LTSSM definitions to enum in patch 12
- dropped the Fixes tags for those patches where it was inappropriate

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13PCI: Add PCI_EXP_DEVCTL_PAYLOAD_* macrosinclude/uapi/linux/pci_regs.h+6 -00 replies
2/13PCI: aardvark: Fix PCIe Max Payload Size settingdrivers/pci/controller/pci-aardvark.c+2 -10 replies
3/13PCI: aardvark: Don't spam about PIO Response Statusdrivers/pci/controller/pci-aardvark.c+1 -10 replies
4/13PCI: aardvark: Fix preserving PCI_EXP_RTCTL_CRSSVE flag on emulated bridgedrivers/pci/controller/pci-aardvark.c+1 -00 replies
5/13PCI: aardvark: Fix configuring Reference clockdrivers/pci/controller/pci-aardvark.c+8 -10 replies
6/13PCI: aardvark: Do not clear status bits of masked interruptsdrivers/pci/controller/pci-aardvark.c+0 -60 replies
7/13PCI: aardvark: Do not unmask unused interruptsdrivers/pci/controller/pci-aardvark.c+3 -33 replies
8/13PCI: aardvark: Deduplicate code in advk_pcie_rd_conf()drivers/pci/controller/pci-aardvark.c+20 -280 replies
9/13PCI: aardvark: Implement re-issuing config requests on CRS responsedrivers/pci/controller/pci-aardvark.c+43 -240 replies
10/13PCI: aardvark: Simplify initialization of rootcap on virtual bridgedrivers/pci/controller/pci-aardvark.c+4 -100 replies
11/13PCI: aardvark: Fix link trainingdrivers/pci/controller/pci-aardvark.c+34 -832 replies
12/13PCI: aardvark: Fix checking for link up via LTSSM statedrivers/pci/controller/pci-aardvark.c+70 -60 replies
13/13PCI: aardvark: Fix reporting Data Link Layer Link Activedrivers/pci/controller/pci-aardvark.c+28 -10 replies

Reviews trailers per patch

11 of 13 patches have a Reviewed-by or Acked-by.

PatchMarek BehúnBjorn Helgaas
1/13R-b R-b
2/13R-b
3/13
4/13R-b
5/13R-b
6/13R-b
7/13R-b
8/13
9/13R-b
10/13R-b
11/13R-b
12/13R-b
13/13R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/13] PCI: aardvark controller fixes

Hi Lorenzo,

as requested I am sending v2 of this series.

Changes since v1:
- updated commit message in patch 6 as suggested by Mark
- updated patch 6 to also drop the early return
- changed the LTSSM definitions to enum in patch 12
- dropped the Fixes tags for those patches where it was inappropriate

Marek Behún (2):
PCI: aardvark: Don't spam about PIO Response Status
PCI: aardvark: Deduplicate code in advk_pcie_rd_conf()

Pali Rohár (11):
PCI: Add PCI_EXP_DEVCTL_PAYLOAD_* macros
PCI: aardvark: Fix PCIe Max Payload Size setting
PCI: aardvark: Fix preserving PCI_EXP_RTCTL_CRSSVE flag on emulated
bridge
PCI: aardvark: Fix configuring Reference clock
PCI: aardvark: Do not clear status bits of masked interrupts
PCI: aardvark: Do not unmask unused interrupts
PCI: aardvark: Implement re-issuing config requests on CRS response
PCI: aardvark: Simplify initialization of rootcap on virtual bridge
PCI: aardvark: Fix link training
PCI: aardvark: Fix checking for link up via LTSSM state
PCI: aardvark: Fix reporting Data Link Layer Link Active

 drivers/pci/controller/pci-aardvark.c | 372 +++++++++++++++-----------
 include/uapi/linux/pci_regs.h         |   6 +
 2 files changed, 217 insertions(+), 161 deletions(-)
Signature · 1 line
2.32.0