target/i386/sev: Housekeeping SEV + measured Linux SEV guest
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
Changes in v4 from the cover letter
- Rebased ('Measured Linux SEV guest' from Dov [1] merged)
- Addressed Paolo & David review comments
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/23 | qapi/misc-target: Wrap long 'SEV Attestation Report' long linesqapi/ | +10 | 0 replies | |
| 2/23 | qapi/misc-target: Group SEV QAPI definitionsqapi/ | +40 | 0 replies | |
| 3/23 | target/i386/kvm: Introduce i386_softmmu_kvm Meson source settarget/ | +5 | 0 replies | |
| 4/23 | target/i386/kvm: Restrict SEV stubs to x86 architectureaccel/ target/ target/ | +2 | 0 replies | |
| 5/23 | target/i386/sev: Prefix QMP errors with 'SEV'target/ target/ | +12 | 1 reply | |
| 6/23 | target/i386/monitor: Return QMP error when SEV is not enabled for guesttarget/ | +5 | 0 replies | |
| 7/23 | target/i386/cpu: Add missing 'qapi/error.h' headertarget/ | +1 | 0 replies | |
| 8/23 | target/i386/sev_i386.h: Remove unused headerstarget/ target/ | +1 | 0 replies | |
| 9/23 | target/i386/sev: Remove sev_get_me_mask()target/ target/ target/ | +0 | 0 replies | |
| 10/23 | target/i386/sev: Mark unreachable code with g_assert_not_reached()target/ | +2 | 0 replies | |
| 11/23 | target/i386/sev: sev_get_attestation_report use g_autofreetarget/ | +3 | 0 replies | |
| 12/23 | target/i386/sev: Use g_autofree in sev_launch_get_measure()target/ | +4 | 2 replies | |
| 13/23 | target/i386/sev: Restrict SEV to system emulationtarget/ target/ target/ | +63 | 0 replies | |
| 14/23 | target/i386/sev: Rename sev_i386.h -> sev.hhw/ target/ target/ +5 more | +7 | 1 reply | |
| 15/23 | target/i386/sev: Declare system-specific functions in 'sev.h'hw/ include/ target/ +3 more | +13 | 0 replies | |
| 16/23 | target/i386/sev: Remove stubs by using code elisiontarget/ target/ target/ +1 more | +20 | 6 replies | |
| 17/23 | target/i386/sev: Move qmp_query_sev_attestation_report() to sev.ctarget/ target/ target/ +1 more | +13 | 0 replies | |
| 18/23 | target/i386/sev: Move qmp_sev_inject_launch_secret() to sev.ctarget/ target/ target/ | +34 | 0 replies | |
| 19/23 | target/i386/sev: Move qmp_query_sev_capabilities() to sev.ctarget/ target/ target/ +1 more | +7 | 0 replies | |
| 20/23 | target/i386/sev: Move qmp_query_sev_launch_measure() to sev.ctarget/ target/ target/ +1 more | +20 | 0 replies | |
| 21/23 | target/i386/sev: Move qmp_query_sev() & hmp_info_sev() to sev.ctarget/ target/ target/ +1 more | +45 | 0 replies | |
| 22/23 | monitor: Reduce hmp_info_sev() declarationinclude/ include/ target/ +1 more | +3 | 0 replies | |
| 23/23 | MAINTAINERS: Cover SEV-related files with X86/KVM sectionMAINTAINERS | +2 | 1 reply |
Reviews trailers per patch
21 of 23 patches have a Reviewed-by or Acked-by.
| Patch | Markus Armbruster | Paolo Bonzini | Dr. David Alan Gilbert | Connor Kuehl | Brijesh Singh | Eric Blake |
|---|---|---|---|---|---|---|
| 1/23 | R-b | R-b | ||||
| 2/23 | R-b | |||||
| 3/23 | R-b | |||||
| 4/23 | R-b | |||||
| 5/23 | R-b | |||||
| 6/23 | R-b | R-b | ||||
| 7/23 | R-b | R-b | R-b | |||
| 8/23 | R-b | R-b | ||||
| 9/23 | R-b | R-b | R-b | |||
| 10/23 | R-b | R-b | ||||
| 11/23 | R-b | R-b | R-b | |||
| 12/23 | ||||||
| 13/23 | R-b | |||||
| 14/23 | R-b | |||||
| 15/23 | R-b | |||||
| 16/23 | R-b | |||||
| 17/23 | R-b | |||||
| 18/23 | R-b | |||||
| 19/23 | R-b | |||||
| 20/23 | R-b | |||||
| 21/23 | R-b | |||||
| 22/23 | R-b | |||||
| 23/23 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.
Cover letter [PATCH v4 00/23] target/i386/sev: Housekeeping SEV + measured Linux SEV guest
Missing review:
0005-target-i386-sev-Prefix-QMP-errors-with-SEV.patch 0012-target-i386-sev-Use-g_autofree-in-sev_launch_get_mea.patch 0014-target-i386-sev-Rename-sev_i386.h-sev.h.patch 0016-target-i386-sev-Remove-stubs-by-using-code-elision.patch 0023-MAINTAINERS-Cover-SEV-related-files-with-X86-KVM-sec.patch
Hi,
While testing James & Dov patch:
https://www.mail-archive.com/[email protected]/msg810571.html
I wasted some time trying to figure out how OVMF was supposed to behave until realizing the binary I was using was built without SEV support... Then wrote this series to help other developers to not hit the same problem.
Since v3:
- Rebased ('Measured Linux SEV guest' from Dov [1] merged)
- Addressed Paolo & David review comments
Since v2:
- Rebased on top of SGX
- Addressed review comments from Markus / David
- Included/rebased 'Measured Linux SEV guest' from Dov [1]
- Added orphean MAINTAINERS section
[1] https://lore.kernel.org/qemu-devel/[email protected]/
Supersedes: <[email protected]>
Dr. David Alan Gilbert (1):
target/i386/sev: sev_get_attestation_report use g_autofree
Philippe Mathieu-Daudé (22):
qapi/misc-target: Wrap long 'SEV Attestation Report' long lines qapi/misc-target: Group SEV QAPI definitions target/i386/kvm: Introduce i386_softmmu_kvm Meson source set target/i386/kvm: Restrict SEV stubs to x86 architecture target/i386/sev: Prefix QMP errors with 'SEV' target/i386/monitor: Return QMP error when SEV is not enabled for
guest
target/i386/cpu: Add missing 'qapi/error.h' header target/i386/sev_i386.h: Remove unused headers target/i386/sev: Remove sev_get_me_mask() target/i386/sev: Mark unreachable code with g_assert_not_reached() target/i386/sev: Use g_autofree in sev_launch_get_measure() target/i386/sev: Restrict SEV to system emulation target/i386/sev: Rename sev_i386.h -> sev.h target/i386/sev: Declare system-specific functions in 'sev.h' target/i386/sev: Remove stubs by using code elision target/i386/sev: Move qmp_query_sev_attestation_report() to sev.c target/i386/sev: Move qmp_sev_inject_launch_secret() to sev.c target/i386/sev: Move qmp_query_sev_capabilities() to sev.c target/i386/sev: Move qmp_query_sev_launch_measure() to sev.c target/i386/sev: Move qmp_query_sev() & hmp_info_sev() to sev.c
monitor: Reduce hmp_info_sev() declaration
MAINTAINERS: Cover SEV-related files with X86/KVM section
qapi/misc-target.json | 77 ++++++------
include/monitor/hmp-target.h | 1 +
include/monitor/hmp.h | 1 -
include/sysemu/sev.h | 28 -----
target/i386/{sev_i386.h => sev.h} | 35 ++++--
hw/i386/pc_sysfw.c | 2 +-
hw/i386/x86.c | 2 +-
target/i386/cpu.c | 16 +--
target/i386/kvm/kvm.c | 3 +-
{accel => target/i386}/kvm/sev-stub.c | 2 +-
target/i386/monitor.c | 92 +--------------
target/i386/sev-stub.c | 88 --------------
target/i386/sev-sysemu-stub.c | 70 +++++++++++
target/i386/sev.c | 164 +++++++++++++++++++-------
MAINTAINERS | 2 +
accel/kvm/meson.build | 1 -
target/i386/kvm/meson.build | 8 +-
target/i386/meson.build | 4 +-
18 files changed, 279 insertions(+), 317 deletions(-)
delete mode 100644 include/sysemu/sev.h
rename target/i386/{sev_i386.h => sev.h} (62%)
rename {accel => target/i386}/kvm/sev-stub.c (94%)
delete mode 100644 target/i386/sev-stub.c
create mode 100644 target/i386/sev-sysemu-stub.cSignature · 1 line
2.31.1