Parallel submission aka multi-bb execbuf
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest26 patches 53 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/26 | drm/i915/guc: Move GuC guc_id allocation under submission state sub-structdrivers/ drivers/ drivers/ | +47 | 3 replies | |
| 2/26 | drm/i915/guc: Take GT PM ref when deregistering contextdrivers/ drivers/ drivers/ +3 more | +121 | 3 replies | |
| 2/26 | drm/i915/guc: Take GT PM ref when deregistering contextdrivers/ drivers/ drivers/ +3 more | +121 | 0 replies | |
| 3/26 | drm/i915/guc: Take engine PM when a context is pinned with GuC submissiondrivers/ drivers/ drivers/ +2 more | +89 | 4 replies | |
| 4/26 | drm/i915/guc: Don't call switch_to_kernel_context with GuC submissiondrivers/ | +13 | 1 reply | |
| 5/26 | drm/i915: Add logical engine mappingdrivers/ drivers/ drivers/ +2 more | +62 | 1 reply | |
| 6/26 | drm/i915: Expose logical engine instance to userdrivers/ include/ | +9 | 0 replies | |
| 7/26 | drm/i915/guc: Introduce context parent-child relationshipdrivers/ drivers/ drivers/ | +91 | 2 replies | |
| 8/26 | drm/i915/guc: Add multi-lrc context registrationdrivers/ drivers/ drivers/ +2 more | +131 | 4 replies | |
| 9/26 | drm/i915/guc: Ensure GuC schedule operations do not operate on child contextsdrivers/ | +12 | 1 reply | |
| 10/26 | drm/i915/guc: Assign contexts in parent-child relationship consecutive guc_idsdrivers/ drivers/ | +86 | 5 replies | |
| 11/26 | drm/i915/guc: Implement parallel context pin / unpin functionsdrivers/ | +70 | 0 replies | |
| 12/26 | drm/i915/guc: Implement multi-lrc submissiondrivers/ drivers/ drivers/ +3 more | +335 | 2 replies | |
| 13/26 | drm/i915/guc: Insert submit fences between requests in parent-child relationshipdrivers/ drivers/ drivers/ +1 more | +108 | 0 replies | |
| 14/26 | drm/i915/guc: Implement multi-lrc resetdrivers/ drivers/ | +63 | 2 replies | |
| 15/26 | drm/i915/guc: Update debugfs for GuC multi-lrcdrivers/ | +39 | 1 reply | |
| 16/26 | drm/i915: Fix bug in user proto-context creation that leaked contextsdrivers/ | +4 | 1 reply | |
| 17/26 | drm/i915/guc: Connect UAPI to GuC multi-lrc interfacedrivers/ drivers/ drivers/ +6 more | +489 | 2 replies | |
| 18/26 | drm/i915/doc: Update parallel submit doc to point to i915_drm.hDocumentation/ Documentation/ | +2 | 0 replies | |
| 19/26 | drm/i915/guc: Add basic GuC multi-lrc selftestdrivers/ drivers/ drivers/ | +181 | 0 replies | |
| 20/26 | drm/i915/guc: Implement no mid batch preemption for multi-lrcdrivers/ drivers/ drivers/ +1 more | +324 | 2 replies | |
| 21/26 | drm/i915: Multi-BB execbufdrivers/ drivers/ drivers/ +4 more | +599 | 4 replies | |
| 22/26 | drm/i915/guc: Handle errors in multi-lrc requestsdrivers/ | +68 | 2 replies | |
| 23/26 | drm/i915: Make request conflict tracking understand parallel submitsdrivers/ | +29 | 5 replies | |
| 24/26 | drm/i915: Update I915_GEM_BUSY IOCTL to understand composite fencesdrivers/ drivers/ drivers/ | +58 | 3 replies | |
| 25/26 | drm/i915: Enable multi-bb execbufdrivers/ | +0 | 0 replies | |
| 26/26 | drm/i915/execlists: Weak parallel submission support for execlistsdrivers/ drivers/ drivers/ +2 more | +64 | 0 replies |
Reviews trailers per patch
12 of 27 patches have a Reviewed-by or Acked-by.
| Patch | Tvrtko Ursulin | John Harrison | Daniel Vetter | Daniele Ceraolo Spurio |
|---|---|---|---|---|
| 1/26 | ||||
| 2/26 | ||||
| 2/26 | ||||
| 3/26 | ||||
| 4/26 | R-b | R-b | ||
| 5/26 | R-b | |||
| 6/26 | R-b | |||
| 7/26 | R-b | |||
| 8/26 | ||||
| 9/26 | R-b | |||
| 10/26 | R-b | |||
| 11/26 | ||||
| 12/26 | ||||
| 13/26 | R-b | |||
| 14/26 | ||||
| 15/26 | R-b | |||
| 16/26 | R-b | R-b | ||
| 17/26 | ||||
| 18/26 | R-b | |||
| 19/26 | R-b | |||
| 20/26 | ||||
| 21/26 | ||||
| 22/26 | ||||
| 23/26 | ||||
| 24/26 | R-b | |||
| 25/26 | ||||
| 26/26 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH 00/26] Parallel submission aka multi-bb execbuf
As discussed in [1] we are introducing a new parallel submission uAPI for the i915 which allows more than 1 BB to be submitted in an execbuf IOCTL. This is the implemenation for both GuC and execlists.
In addition to selftests in the series, an IGT is available implemented in the first 4 patches [2].
The execbuf IOCTL changes have been done in a single large patch (#21) as all the changes flow together and I believe a single patch will be better if some one has to lookup this change in the future. Can split in a series of smaller patches if desired.
This code is available in a public [3] repo for UMD teams to test there code on.
v2: Drop complicated state machine to block in kernel if no guc_ids available, perma-pin parallel contexts, reworker execbuf IOCTL to be a series of loops inside the IOCTL rather than 1 large one on the outside, address Daniel Vetter's comments
v3: Address John Harrison's comments, add a couple of patches which fix bugs found internally
[1] https://patchwork.freedesktop.org/series/92028/
[2] https://patchwork.freedesktop.org/series/93071/
[3] https://gitlab.freedesktop.org/mbrost/mbrost-drm-intel/-/tree/drm-intel-parallel
Matthew Brost (26):
drm/i915/guc: Move GuC guc_id allocation under submission state
sub-struct
drm/i915/guc: Take GT PM ref when deregistering context drm/i915/guc: Take engine PM when a context is pinned with GuC
submission
drm/i915/guc: Don't call switch_to_kernel_context with GuC submission drm/i915: Add logical engine mapping
drm/i915: Expose logical engine instance to user drm/i915/guc: Introduce context parent-child relationship drm/i915/guc: Add multi-lrc context registration drm/i915/guc: Ensure GuC schedule operations do not operate on child
contexts
drm/i915/guc: Assign contexts in parent-child relationship consecutive
guc_ids
drm/i915/guc: Implement parallel context pin / unpin functions drm/i915/guc: Implement multi-lrc submission
drm/i915/guc: Insert submit fences between requests in parent-child
relationship
drm/i915/guc: Implement multi-lrc reset
drm/i915/guc: Update debugfs for GuC multi-lrc
drm/i915: Fix bug in user proto-context creation that leaked contexts drm/i915/guc: Connect UAPI to GuC multi-lrc interface drm/i915/doc: Update parallel submit doc to point to i915_drm.h drm/i915/guc: Add basic GuC multi-lrc selftest drm/i915/guc: Implement no mid batch preemption for multi-lrc drm/i915: Multi-BB execbuf
drm/i915/guc: Handle errors in multi-lrc requests drm/i915: Make request conflict tracking understand parallel submits drm/i915: Update I915_GEM_BUSY IOCTL to understand composite fences drm/i915: Enable multi-bb execbuf
drm/i915/execlists: Weak parallel submission support for execlists
Documentation/gpu/rfc/i915_parallel_execbuf.h | 122 -- Documentation/gpu/rfc/i915_scheduler.rst | 4 +- drivers/gpu/drm/i915/gem/i915_gem_busy.c | 60 +- drivers/gpu/drm/i915/gem/i915_gem_context.c | 225 ++- .../gpu/drm/i915/gem/i915_gem_context_types.h | 6 + .../gpu/drm/i915/gem/i915_gem_execbuffer.c | 796 ++++++--- drivers/gpu/drm/i915/gt/intel_context.c | 50 +- drivers/gpu/drm/i915/gt/intel_context.h | 54 +- drivers/gpu/drm/i915/gt/intel_context_types.h | 73 +- drivers/gpu/drm/i915/gt/intel_engine.h | 12 +- drivers/gpu/drm/i915/gt/intel_engine_cs.c | 66 +- drivers/gpu/drm/i915/gt/intel_engine_pm.c | 13 + drivers/gpu/drm/i915/gt/intel_engine_pm.h | 37 + drivers/gpu/drm/i915/gt/intel_engine_types.h | 7 + .../drm/i915/gt/intel_execlists_submission.c | 63 +- drivers/gpu/drm/i915/gt/intel_gt_pm.h | 14 + drivers/gpu/drm/i915/gt/intel_lrc.c | 7 + drivers/gpu/drm/i915/gt/selftest_execlists.c | 12 +- .../gpu/drm/i915/gt/uc/abi/guc_actions_abi.h | 1 + drivers/gpu/drm/i915/gt/uc/intel_guc.c | 26 + drivers/gpu/drm/i915/gt/uc/intel_guc.h | 49 +- drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c | 2 +- drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 24 +- drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h | 27 +- .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 1456 ++++++++++++++--- .../drm/i915/gt/uc/selftest_guc_multi_lrc.c | 179 ++ drivers/gpu/drm/i915/i915_query.c | 2 + drivers/gpu/drm/i915/i915_request.c | 143 +- drivers/gpu/drm/i915/i915_request.h | 23 + drivers/gpu/drm/i915/i915_vma.c | 21 +- drivers/gpu/drm/i915/i915_vma.h | 13 +- drivers/gpu/drm/i915/intel_wakeref.h | 12 + .../drm/i915/selftests/i915_live_selftests.h | 1 + include/uapi/drm/i915_drm.h | 139 +- 34 files changed, 3038 insertions(+), 701 deletions(-) delete mode 100644 Documentation/gpu/rfc/i915_parallel_execbuf.h create mode 100644 drivers/gpu/drm/i915/gt/uc/selftest_guc_multi_lrc.c
Signature · 1 line
2.32.0