Skip to content

i2c:imx: Deliver a timely stop on slave side, fix recv

[email protected] linux-i2c lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 2 repliesIn review
  2. v13 patches 7 repliesSuperseded

Changes in v2 from the cover letter

* Added a comment on the hrtimer cancel on why the return value didn't need to be checked.

* Combine the hrtimer patch into the main timer patch.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2i2c:imx: Add timer for handling the stop conditiondrivers/i2c/busses/i2c-imx.c+73 -190 replies
2/2i2c:imx: Add an extra read at the end of an I2C slave readdrivers/i2c/busses/i2c-imx.c+9 -02 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchAndrew ManleyOleksij Rempel
1/2T-b R-b R-b
2/2T-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] i2c:imx: Deliver a timely stop on slave side, fix recv

I was working on an application that needs the stop condition immediately. So this adds a timer after each byte is received/sent and if the bus is idle at the timeout, send the stop.

Also, I noticed when you use the i2c-slave-eeprom, if you read some data and then read some data again, the last byte of the first read will be the first byte of the second read. This is because i2c-slave-eeprom expects a read-ahead. That's what the documentation says, at least.

Thanks to Uwe Kleine-König and Oleksij Rempel for reviewing.

-corey

Changes since v1:

* Added a comment on the hrtimer cancel on why the return value didn't need to be checked.

* Combine the hrtimer patch into the main timer patch.